Dear Maintainer,


While working on my 'hkl' package I now have an FTBFS due to the 0.9.2 cglm version


The error is

hkl-binoculars-geometry.c: In function ‘hkl_binoculars_parameter_transformation_get’:
hkl-binoculars-geometry.c:45:45: error: incompatible type for argument 1 of ‘glms_rotate_atm’
   45 |                         r = glms_rotate_atm(m, pivot, angle, axis);
      |                                             ^
      |                                             |
      |                                             mat4s
In file included from /usr/include/cglm/struct.h:28,
                 from hkl-binoculars-private.h:25,
                 from hkl-binoculars-geometry.c:25:
/usr/include/cglm/struct/affine.h:135:23: note: expected ‘vec3s’ but argument is of type ‘mat4s’
  135 | glms_rotate_atm(vec3s pivot, float angle, vec3s axis) {
      |                 ~~~~~~^~~~~

And Indeed a diff between 0.9.2 and 0.9.1 gives

diff --git a/include/cglm/struct/affine.h b/include/cglm/struct/affine.h
index bc62846..2e24fd5 100644
--- a/include/cglm/struct/affine.h
+++ b/include/cglm/struct/affine.h
@@ -22,7 +22,7 @@
    CGLM_INLINE mat4s glms_rotate_make(float angle, vec3s axis);
    CGLM_INLINE mat4s glms_rotate(mat4s m, float angle, vec3s axis);
    CGLM_INLINE mat4s glms_rotate_at(mat4s m, vec3s pivot, float angle, vec3s axis);
-   CGLM_INLINE mat4s glms_rotate_atm(mat4s m, vec3s pivot, float angle, vec3s axis);
+   CGLM_INLINE mat4s glms_rotate_atm(vec3s pivot, float angle, vec3s axis);
    CGLM_INLINE mat4s glms_spin(mat4s m, float angle, vec3s axis);
    CGLM_INLINE vec3s glms_decompose_scalev(mat4s m);
    CGLM_INLINE bool  glms_uniscaled(mat4s m);

it it expected ?

I do not know how many project are affected by this API breakage since build-rdeps is not working anymore on my system.

It would be great to upload into experimental and request a full rebuild of all rdeps.

Thanks for considering

Frederic