#1064849 dh-exec: Renaming a file using ${env:VARIABLE} substitution does not work

Package:
dh-exec
Source:
dh-exec
Description:
Scripts to help with executable debhelper files
Submitter:
Marco Trevisan
Date:
2024-02-27 06:24:03 UTC
Severity:
normal
#1064849#5
Date:
2024-02-26 17:16:37 UTC
From:
To:
Dear Maintainer,

When using dh-exec to rename a file using a path provided as variable in
debian/rules such as:

usr/bin/foo-bin => ${env:FOO_INSTALL_PATH}/foo

Does not work and I get this failure:

  with FOO_INSTALL_PATH := /usr/libexec/

  dh_install: warning: Cannot find (any matches for)
  "debian/tmp/dh-exec.RyaTa0ew//usr/libexec/foo" (tried in ., debian/tmp)

dh_install: warning: foo-package missing files: debian/tmp/dh-exec.RyaTa0ew//usr/libexec/foo
dh_install: error: missing files, aborting.

In fact in debian/tmp I have:

  debian/tmp/dh-exec.RyaTa0ew/${env:FOO_INSTALL_PATH}
  debian/tmp/dh-exec.RyaTa0ew/${env:FOO_INSTALL_PATH}/foo

The replacement works fine when using normal debhelper syntax and so
when not using `=>` to rename.

Architecture: amd64 (x86_64)
Foreign Architectures: i386

Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), LANGUAGE=it_IT:en_US:en
Shell: /bin/sh linked to /usr/bin/dash
LSM: AppArmor: enabled

Versions of packages dh-exec depends on:
ii  debhelper     13.14.1ubuntu1
ii  perl          5.38.2-3

dh-exec recommends no packages.

dh-exec suggests no packages.

#1064849#10
Date:
2024-02-26 17:24:01 UTC
From:
To:
It's worth mentioning that using ${FOO_INSTALL_PATH} instead works, but
I feel it would be better to also support debhelper's ${env:VARIABLE}
format as it's a bit safer.

I'm unsure if that would break further debhelper substitutions, but I
feel that some cases like this could be handled better to have a more
consistent behavior with recent dh.

#1064849#13
Date:
2024-02-27 06:04:41 UTC
From:
To:
Hello,

Bug #1064849 in dh-exec reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/debian/dh-exec/-/commit/80726b7f7eae0a38e205153a82f10c92facc0be5
------------------------------------------------------------------------
dh-exec-subst: use env:ENV_VAR substition too

Templates can use ${FOO} or ${env:FOO} with the second
form how most of other parts of debhelper work.

Closes: #1064849
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1064849

#1064849#20
Date:
2024-02-27 06:20:11 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
dh-exec, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1064849@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Craig Small <csmall@debian.org> (supplier of updated dh-exec package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 27 Feb 2024 17:03:00 +1100
Source: dh-exec
Architecture: source
Version: 0.29
Distribution: unstable
Urgency: medium
Maintainer: Craig Small <csmall@debian.org>
Changed-By: Craig Small <csmall@debian.org>
Closes: 1064849
Changes:
 dh-exec (0.29) unstable; urgency=medium
 .
   * dh-exec-subst: use env:ENV_VAR substition too Closes: #1064849
   * Change build-dep pkg-config -> pkgconf
   * Moved/updated manpages
Checksums-Sha1:
 9555fda0701fc94be6d3c04c24faaeb71680f7b2 1621 dh-exec_0.29.dsc
 de443e150c9d8d80fe3ea024ffd200f25c8bf6c4 36252 dh-exec_0.29.tar.xz
 6c315a95116d17db4b2779f987cd48ffbde5bfb9 6701 dh-exec_0.29_amd64.buildinfo
Checksums-Sha256:
 ba8e7c0682edb219364cb7db228009294f8ebf2e2a11d7f57e9b5c9e98fe8a55 1621 dh-exec_0.29.dsc
 e4ab37cbc237f4e0ba3dabc763a84d8030538ec36f018e28fe12795fe64f8e97 36252 dh-exec_0.29.tar.xz
 c974cf49a0ec8903574c5c63dcae2ca32c5b425c05c03621e8dd44fe8d597ebb 6701 dh-exec_0.29_amd64.buildinfo
Files:
 f1efc9488fceabaca942ef41e2d31a8b 1621 devel optional dh-exec_0.29.dsc
 7188ee86a59133d4bff969615c9b58b6 36252 devel optional dh-exec_0.29.tar.xz
 603f110d9ed225d292d32234c48a55fa 6701 devel optional dh-exec_0.29_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXT3w9TizJ8CqeneiAiFmwP88hOMFAmXde1AACgkQAiFmwP88
hOONIBAAly1t2taOfScA3k5jdEDF8s8i70wpuhYShd3k7x1s27kA0L7EqcyJFebR
983tH141b1PaOI3HrV6x8r7wWMmqAnixF90un/35bkwIGwFxEefvL2PNknHaAeQ/
WI7W8HcVjYISvpXfdloyMdzrYWOG4uAm3NgToPtZhJpydZKPlURQNTFmLNrwwG1h
brs7BBgaB3XGnQ14i9ZAhHWJeIZCTuIOW1uKa8fTeWjdVG/OuykHtdt0FCuF1V/3
n5VecIaECPPgr/lFMv0jByLQA/XFPaJXaM5UUmco9V01lpa+AlStKNLsGmIxk3+z
e9dOHCLdwa9G8ZUdpKzjAmGVSHXndMuXYKmCvQLBPxNeOUFYTQuJdPuLPdXj2oiM
+JFdlozyYJJEDhYtAMzX5mvj/hndU5T9cCCnMCuQL4jpoOtDDSgXDdlvx1q1Ez+M
9kZlWC0MkfvzQWO4NWNf1GUNbMrdnIDZHduIVw5bk/9uj8ah1GkicFVyd6r3hW1F
HyfKVe2bj7OWX1QNiHTuU/aX0owTQqhwBFw0swEV88tuXUTPwex1YzdR0RMya1FK
8JsEYAgxKQvBQdrFxPovlwVMWgWTDuFLE0rHvi5XEfS23bD6/x9PJ54vjD/rTm/d
UIwh8ANSQswNWS4qx4CZwV01dUWGUYmhNcUbHZ6Ii7P5mU6loBo=
=Zqi1
-----END PGP SIGNATURE-----