- Package:
- sponsorship-requests
- Source:
- sponsorship-requests
- Submitter:
- itd
- Date:
- 2025-08-11 13:55:01 UTC
- Severity:
- normal
- Tags:
Dear mentors, I am looking for a sponsor for my package "batsignal": * Package name : batsignal Version : 1.8.0-1 Upstream contact : https://github.com/electrickite/batsignal * URL : https://github.com/electrickite/batsignal * License : ISC * Vcs : https://salsa.debian.org/itd/batsignal Section : utils The source builds the following binary packages: batsignal - Lightweight battery daemon written in C To access further information about this package, please visit the following URL: https://mentors.debian.net/package/batsignal/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/b/batsignal/batsignal_1.8.0-1.dsc Changes for the initial release: batsignal (1.8.0-1) unstable; urgency=medium . * Initial release. I would like to move the Vcs to /debian/batsignal, whenever that is convenient. Regards, -- itd
Hi itd,
(Policy requires that the "Maintainer" has "their correct name and a working email
address", see Policy §3.3. I know that there are exceptions, but I'm not
sure about the conditions they require (for DMs/DDs, at least DAM needs
to know your name, but I don't know the rules for Debian Contributors.
Due to that, I will not sponsor this package, but I can certainly review the
package.)
Closes: #xxxx stanca.
Let me know your salsa username and I'll make that happen.
A short, possibly incomplete review:
- d/copyright: I suggest to have the same license for debian/* as for
upstream, as this eases forwarding patches etc. Though ISC is
considered by the FSF to be compatible with the GPL, this is likely
fine too to keep it at is is.
- d/watch / this dsc
uscan download this:
c8c2a048f4aa105aae389d9d765b76057d4998dbfc29a7dfeaf66351eaa7cba1 batsignal_1.8.0.orig.tar.gz
your dsc contains:
d02e5c821d41e72c30d00bb88759287f9b74225e1217158e5e59f11ba03d5a5b batsignal_1.8.0.orig.tar.xz
when constructing your dsc, please make sure to use the same file as
uscan would produce. (I've verified that the content of both orig files is identical)
Package looks good, otherwise. Make sure to remove the moreinfo tag when
the above issues are fixed.
Cheers,
Hi tobi, Tobias Frost <tobi@debian.org> writes: understood, thanks for the review! Will look into this. Makes sense and works for me. Updated. Ouch, sorry about that. If I understand diffoscope correctly it's indeed only the timestamps that differ. d/watch's version uses the date of the upstream repo's 1.8.0 tag. My version, created via gbp, uses the date of my repo's upstream/1.8.0 tag. I'll try to figure out how to solve this. Not fixed so not removed. Thanks again! Regards itd
Without knowing for certain, I would suspect that the problem is that gbp is repacking your orig.tar as an .xz (the upstream is .gz). That is fine if a repack is intended, but in that case the file name should be something more like batsignal_1.8.0+dfsg.orig.tar.xz or batsignal_1.8.0+ds.orig.tar.xz. If you do intend to repackage the upstream tarball you should indicate it in the package version (+dfsg for upstream tarballs that need non-free components removed and +ds for tarballs that have things removed for reasons like size). https://wiki.debian.org/DebianMentorsFaq#What_does_.2BIBw-dfsg.2BIB0_or_.2BIBw-ds. 2BIB0_in_the_version_string_mean.3F[1] If you don’t intend to repackage the upstream tarball you probably need to modify your configuration to not do so.-------- [1] https://wiki.debian.org/DebianMentorsFaq#What_does_.2BIBw-dfsg.2BIB0_or_.2BIBw-ds.2BIB0_in_the_version_string_mean.3F
Preparing an ITP bug for d/changelog by cloning and updating the clone.
Hi, Soren Stoutner <soren@debian.org> writes: looks like the problem was caused by a forgotten USCAN_REPACK=yes in ~/.devscripts combined with a missing pristine-tar branch to allow gbp to recreate the upstream tarball. Thanks for the help! Best regards itd
Hi again, itd <itd@net.in.tum.de> writes: with 27dcd276 debian/changelog closes bug #1067606. As mentioned, looks like this was caused by a misconfiguration of uscan and gbp on my side, sorry. I've unset the uscan variable, added, and pushed the missing pristine-tar branch. With these changes the hash matches. Updated package dput to mentors. Regards itd
Good day itd, It has been a number of months and I will do a full review here to see where we are with your package submission. Preamble... Thanks for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the subitter to make any alterations based upon information provided in the review. Review... 1. Build: Good 2. Lintian: Good 3. Licenses: Good 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 5. Reproducible builds (reporotest)[1]: Good 6. Install (No previous installs): Good 7. Upgrade (Over previous installs if any): N/A Additional... A. Update 'Standards-Version' in 'debian/control' to 4.7.0 as per current Debian policy[2]. B. Add your salsa repository[2] as VCS fields in 'debian/control'. C. Add a 'Files: debian/*' section to 'debian/copyright'. Sponsorship is not likely to take place without this. Summary... I believe 'batsignal' is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method [2] https://salsa.debian.org/itd/batsignal Regards Phil
Good day itd, It has been a number of months and I will do a full review here to see where we are with your package submission. Preamble... Thanks for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the subitter to make any alterations based upon information provided in the review. Review... 1. Build: Good 2. Lintian: Good 3. Licenses: Good 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 5. Reproducible builds (reporotest)[1]: Good 6. Install (No previous installs): Good 7. Upgrade (Over previous installs if any): N/A Additional... A. Update 'Standards-Version' in 'debian/control' to 4.7.0 as per current Debian policy[2]. B. Add your salsa repository[2] as VCS fields in 'debian/control'. C. Add a 'Files: debian/*' section to 'debian/copyright'. Sponsorship is not likely to take place without this. Summary... I believe 'batsignal' is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method [2] https://salsa.debian.org/itd/batsignal Regards Phil
Hi, thanks for the reviews both here and on mentors.d.n. Phil Wyett <philip.wyett@kathenas.org> writes: Done in 8224ed05. I would prefer to have this package in the /debian group. Once that is feasible, I will update/add these fields. After switching the license for debian/* to ISC, I combined the stanzas. To me, the situation seemed similar to example 5.2.1 from [1]: Best regards itd PS: Sorry for the delay. Life happened.
It has become almost ubiquitous in Debian for there to exist a separate debian/* stanza, because it improves readability and separation between upstream copyright and licensing statements and Debian copyright and licensing statements. However, if you feel strongly about them being combined, I would suggest you add a detailed Comment section explaining that they are combined and (probably) listing which of the copyright statements apply to upstream and which apply to Debian. The practical result of this is that it will probably take more lines to combine them then to keep them separate.
itd, Preamble ======== Thank you for taking the time to prepare this package and your ongoing contribution to the Debian project. This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer. For information on each of the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Tests ===== Test 1 (reproducibility): Pass - None blocking. Test 2 (pbuilder): Pass Test 3 (build twice): Pass Test 4 (sbuild): Pass Test 5 (ratt): Pass- None blocking. Test 6 (debian/watch): Pass Test 7 (licenserecon): Pass Test 8 (first run): Pass Comment ======= As Soren has stated in another comment, it would be beneficial to have a separate 'Files: debian/*' for clarity of information and who has done what. Summary ======= I believe 'batsignal' is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready and appropriate for the distribution. Regards Phil
itd, Preamble ======== Thank you for taking the time to prepare this package and your ongoing contribution to the Debian project. This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer. For information on each of the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Tests ===== Test 1 (reproducibility): Pass - None blocking. Test 2 (pbuilder): Pass Test 3 (build twice): Pass Test 4 (sbuild): Pass Test 5 (ratt): Pass- None blocking. Test 6 (debian/watch): Pass Test 7 (licenserecon): Pass Test 8 (first run): Pass Comment ======= As Soren has stated in another comment, it would be beneficial to have a separate 'Files: debian/*' for clarity of information and who has done what. Summary ======= I believe 'batsignal' is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready and appropriate for the distribution. Regards Phil
Debian upload Hi, It would be nice to see 'batsignal' on Salsa and may encourage more DDs to take a look at the package. Regards Phil
Debian upload Hi, It would be nice to see 'batsignal' on Salsa and may encourage more DDs to take a look at the package. Regards Phil
Hi, Phil Wyett <philip.wyett@kathenas.org> writes: https://salsa.debian.org/debian/batsignal (salsa.d.o/itd/batsignal is archived.) Other changes: d/control Vcs fields added, Standards-Version and d/changelog date bumped. Regards itd
Hi itd, I have had a browse and it all looks good. The package is 'confirmed' and I do hope a DD can find the time to review and possibly upload into Debian.