#1067113 libhiredis-dev: cmake config incompatible with upstream

Package:
libhiredis-dev
Source:
libhiredis-dev
Description:
minimalistic C client library for Redis (development files)
Submitter:
Sylvain Joubert
Date:
2024-03-18 17:45:03 UTC
Severity:
normal
#1067113#5
Date:
2024-03-18 15:52:18 UTC
From:
To:
Dear Maintainer,

The CMake config provided by this package seems incompatible with the upstream
one.
Currently, the package provides data under the name "Hiredis" with a capital
leading H, while upstream is named "hiredis" lowercase
".../cmake/Hiredis/HiredisConfig{,Version}.cmake" vs.
".../cmake/hiredis/hiredis-config.cmake" (see
https://github.com/redis/hiredis/blob/master/CMakeLists.txt#L137-L150)

This means that a client CMake project can't switch transparently between an
Debian install and a custom cmake build of hiredis.

Could you rename the cmake configuration provided by Debian to match upstream,
or even build hiredis using the official CMake support?

Thanks.

#1067113#10
Date:
2024-03-18 17:34:30 UTC
From:
To:
[adding <debian@tomlee.co> to CC]

Sylvain Joubert wrote:

I'm looping in Tom Lee here as they added the CMake changes back in
2018 (via #784768?).

Yes, perhaps these changes are simply not needed anymore. However, I
don't quite understand the changes made in 07_cmake.patch completely
to make a determination on my own. I think I might know how to fix
this (eg. change the definition of CMAKE_PATH and then update
libhiredis-dev.install to match?), but, again, I'm just not familiar
enough.

No objection to solving this issue in a general sense, though. :)


Regards,