Dear mentors, I am looking for a sponsor for my package "batsignal": * Package name : batsignal Version : 1.8.0-1 Upstream contact : https://github.com/electrickite/batsignal * URL : https://github.com/electrickite/batsignal * License : ISC * Vcs : https://salsa.debian.org/itd/batsignal Section : utils The source builds the following binary packages: batsignal - Lightweight battery daemon written in C To access further information about this package, please visit the following URL: https://mentors.debian.net/package/batsignal/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/b/batsignal/batsignal_1.8.0-1.dsc Changes for the initial release: batsignal (1.8.0-1) unstable; urgency=medium . * Initial release. I would like to move the Vcs to /debian/batsignal, whenever that is convenient. Regards, -- itd
Hi itd,
(Policy requires that the "Maintainer" has "their correct name and a working email
address", see Policy §3.3. I know that there are exceptions, but I'm not
sure about the conditions they require (for DMs/DDs, at least DAM needs
to know your name, but I don't know the rules for Debian Contributors.
Due to that, I will not sponsor this package, but I can certainly review the
package.)
Closes: #xxxx stanca.
Let me know your salsa username and I'll make that happen.
A short, possibly incomplete review:
- d/copyright: I suggest to have the same license for debian/* as for
upstream, as this eases forwarding patches etc. Though ISC is
considered by the FSF to be compatible with the GPL, this is likely
fine too to keep it at is is.
- d/watch / this dsc
uscan download this:
c8c2a048f4aa105aae389d9d765b76057d4998dbfc29a7dfeaf66351eaa7cba1 batsignal_1.8.0.orig.tar.gz
your dsc contains:
d02e5c821d41e72c30d00bb88759287f9b74225e1217158e5e59f11ba03d5a5b batsignal_1.8.0.orig.tar.xz
when constructing your dsc, please make sure to use the same file as
uscan would produce. (I've verified that the content of both orig files is identical)
Package looks good, otherwise. Make sure to remove the moreinfo tag when
the above issues are fixed.
Cheers,
Hi tobi, Tobias Frost <tobi@debian.org> writes: understood, thanks for the review! Will look into this. Makes sense and works for me. Updated. Ouch, sorry about that. If I understand diffoscope correctly it's indeed only the timestamps that differ. d/watch's version uses the date of the upstream repo's 1.8.0 tag. My version, created via gbp, uses the date of my repo's upstream/1.8.0 tag. I'll try to figure out how to solve this. Not fixed so not removed. Thanks again! Regards itd
Without knowing for certain, I would suspect that the problem is that gbp is repacking your orig.tar as an .xz (the upstream is .gz). That is fine if a repack is intended, but in that case the file name should be something more like batsignal_1.8.0+dfsg.orig.tar.xz or batsignal_1.8.0+ds.orig.tar.xz. If you do intend to repackage the upstream tarball you should indicate it in the package version (+dfsg for upstream tarballs that need non-free components removed and +ds for tarballs that have things removed for reasons like size). https://wiki.debian.org/DebianMentorsFaq#What_does_.2BIBw-dfsg.2BIB0_or_.2BIBw-ds. 2BIB0_in_the_version_string_mean.3F[1] If you don’t intend to repackage the upstream tarball you probably need to modify your configuration to not do so.-------- [1] https://wiki.debian.org/DebianMentorsFaq#What_does_.2BIBw-dfsg.2BIB0_or_.2BIBw-ds.2BIB0_in_the_version_string_mean.3F
Preparing an ITP bug for d/changelog by cloning and updating the clone.
Dear mentors, I've lost interest in this package and am no longer looking for a sponsor. Other packages such as [0] provide sufficiently similar functionality. The proposed package remains available on salsa.d.o [1]. [0]: https://tracker.debian.org/pkg/poweralertd [1]: https://salsa.debian.org/debian/batsignal Regards, itd