#1067627 FTBFS: error: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘long int’

Package:
src:xpra
Source:
src:xpra
Submitter:
Andrey Rakhmatullin
Date:
2024-04-04 12:21:03 UTC
Severity:
normal
Tags:
#1067627#5
Date:
2024-03-24 19:34:21 UTC
From:
To:
https://buildd.debian.org/status/fetch.php?pkg=xpra&arch=i386&ver=3.1.5%2Bdfsg1-0.2%2Bb3&stamp=1710056306&raw=0

xpra/x11/bindings/keyboard_bindings.c: In function ‘__Pyx_PyInt_AndObjC’:
xpra/x11/bindings/keyboard_bindings.c:30158:36: error: comparison of integer
expressions of different signedness: ‘long unsigned int’ and ‘long int’
[-Werror=sign-compare]
30158 |         if ((intval & PyLong_MASK) == intval) {
      |                                    ^~
xpra/x11/bindings/keyboard_bindings.c:30160:71: error: operand of ‘?:’ changes
signedness from ‘long int’ to ‘long unsigned int’ due to unsignedness of other
operand [-Werror=sign-compare]
30160 |             long result = intval & (likely(__Pyx_PyLong_IsPos(op1)) ?
last_digit : (PyLong_MASK - last_digit + 1));
      |
^~~~~~~~~~


Note that the package enables -Werror.

#1067627#10
Date:
2024-04-04 12:18:24 UTC
From:
To:
https://buildd.debian.org/status/fetch.php?pkg=xpra&arch=i386&ver=3.1.5%2Bdfsg1-0.2%2Bb3&stamp=1710056306&raw=0
‘__Pyx_PyInt_AndObjC’:
integer
int’
changes
of other
(likely(__Pyx_PyLong_IsPos(op1)) ?

I applied the attached patch to the Ubuntu package to disable -Werror
for the package build.