Hey Anthony,

I noticed that this upload breaks autopkgtest
for golang-github-golang-protobuf-1-5, cf.
https://tracker.debian.org/pkg/golang-google-protobuf

40s # github.com/golang/protobuf/protoc-gen-go/descriptor
682
<https://ci.debian.net/packages/g/golang-github-golang-protobuf-1-5/testing/amd64/44515037/#L682>
40s src/
github.com/golang/protobuf/protoc-gen-go/descriptor/descriptor.pb.go:106:61:
undefined: descriptorpb.Default_FileOptions_PhpGenericServices
683
<https://ci.debian.net/packages/g/golang-github-golang-protobuf-1-5/testing/amd64/44515037/#L683>
40s google.golang.org/protobuf/reflect/protodesc
684
<https://ci.debian.net/packages/g/golang-github-golang-protobuf-1-5/testing/amd64/44515037/#L684>
do you know what's going on here?

This seems to block migration of quite a few other packages, including
security updates for buildah and libpod.

Hi Anthony,

  A few weeks ago you uploaded a new version of golang-google-protobuf
to unstable which caused a FTBFS in golang-github-golang-protobuf-1-5
v1.5.3 [1,2,3]. This has been blocking the transition of various golang
packages from unstable to testing.

  I've verified that v1.5.4 of golang-github-golang-protobuf-1-5 builds
fine on my amd64 system. `build-rdeps golang-github-golang-protobuf-1-
5-dev` identifies 219 rdeps in main, so I haven't kicked off a `ratt`
run testing for any build regressions with the newer version yet.

  Are you waiting on something specific before updating golang-github-
golang-protobuf-1-5?

Thanks,
Mathias

[1] -- https://qa.debian.org/excuses.php?package=golang-google-protobuf
[2] -- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068136
[3] -- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1069368

This is a known regression in 1.5.3, see
https://github.com/golang/protobuf/issues/1596#issuecomment-1981208282

  Since that appears to be the only change in v1.5.4, would there be
any concerns with uploading that version to unstable? This breakage is
starting to cause FTBFS bugs to be filed against affected packages,
such as hugo (#1069371).

Mathias

Hi Reinhard, Mathias and Shengjing,

Thank you for bringing this to my attention, and sorry for my late response!
Thank you also for your detailed investigation!  Very much appreciated!

I don't see any concern uploading v1.5.4 especially how it fixes the
regression and FTBFS
with v1.5.3, and I'll be uploading golang-github-golang-protobuf-1-5
1.5.4-1 very shortly.

Cheers,
Anthony

We believe that the bug you reported is fixed in the latest version of
golang-github-golang-protobuf-1-5, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1068136@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Anthony Fok <foka@debian.org> (supplier of updated golang-github-golang-protobuf-1-5 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 21 Apr 2024 22:13:50 -0600
Source: golang-github-golang-protobuf-1-5
Architecture: source
Version: 1.5.4-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed-By: Anthony Fok <foka@debian.org>
Closes: 1068136 1069368
Changes:
 golang-github-golang-protobuf-1-5 (1.5.4-1) unstable; urgency=medium
 .
   * Team upload
   * New upstream version 1.5.4 (Closes: #1068136, #1069368)
   * Bump versioned dependencies as per go.mod
   * Bump Standards-Version to 4.7.0 (no change)
Checksums-Sha1:
 407091a7cc5d76320130036411fc506fc37e7b3d 2492 golang-github-golang-protobuf-1-5_1.5.4-1.dsc
 cfdbab166aa33a1c5b82be00f7b061abda21be7a 172992 golang-github-golang-protobuf-1-5_1.5.4.orig.tar.gz
 f82560c1744eb1801d49f7e08d610ad0e62af7bb 2920 golang-github-golang-protobuf-1-5_1.5.4-1.debian.tar.xz
 1b466e9bcd29477cc58d51df9a0f2c4ebe140469 6989 golang-github-golang-protobuf-1-5_1.5.4-1_amd64.buildinfo
Checksums-Sha256:
 1d55aaf89da480177cb18d8c39bc6e06dab52d1163aea255184f0bb5e2939fe2 2492 golang-github-golang-protobuf-1-5_1.5.4-1.dsc
 d75e6960ecfabaaa83a7261b1b630d24e9c63aca79615fb15bf33e11b62fd019 172992 golang-github-golang-protobuf-1-5_1.5.4.orig.tar.gz
 fddb1fa98f8a1985c10a484cf719ded873ce29cd84bca8781bf5b1556daa2432 2920 golang-github-golang-protobuf-1-5_1.5.4-1.debian.tar.xz
 e085d276b86752bb8c61f9bfec8d130504a84de0d08c970499d9afc0a97ebeab 6989 golang-github-golang-protobuf-1-5_1.5.4-1_amd64.buildinfo
Files:
 7a0e5492e95146f382d8de62ba43cd18 2492 golang optional golang-github-golang-protobuf-1-5_1.5.4-1.dsc
 bbdaed5e0de5a93ab968a851e4cec2c0 172992 golang optional golang-github-golang-protobuf-1-5_1.5.4.orig.tar.gz
 971cda71f821812e87b83d34c94cf710 2920 golang optional golang-github-golang-protobuf-1-5_1.5.4-1.debian.tar.xz
 ae5535e9793849e74ff289735f6e6e24 6989 golang optional golang-github-golang-protobuf-1-5_1.5.4-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEEFCQhsZrUqVmW+VBy6iUAtBLFms8FAmYl5SsQHGZva2FAZGVi
aWFuLm9yZwAKCRDqJQC0EsWaz4R+D/0e/ehfd/jWRpnCMZGtAFvHcq+Q41/FS7iF
nPGefTgflzU+h50fz6PTBNeZ6FZjNblb5+W1YPGhGrjZqpiU9lk/FpCFX6pHXmm3
TwcOH+dT15fQEmHlRFquLvUJCqV16DuDesaZcRCvOphRqV5jgTmlJYxI7pvsBrsw
k9BOSfOdzaZYzqTDdawIPYVb4WEMRkeJ1xnLOAbFR52PTIRV8A8xEeS9M855DfuY
z6obs8HGvFH+rvrDYNcvhsWaZXTAmgrlghoGAAgyEM8UBl2xJGGHzU76L1d4SEfA
5YIkA6cbus18EwC7FUUP4yZgaXV0JbqAkXcuETUSCvEaLStN/kaky54iHqec31rx
eK2UU22VgvDlQjtKypWVyrxtmQolLa85Jozfrf7wEFAT11gjB+wYvIOQ3WPC5hLJ
LBaOO6nOI+hU/RvnFCQay5imBAKbmo1ZJTL8Gsz9pQP//cDpM1BGOP3MbbGUI2Hj
bmaoqYErGUgy5mPFffkC68ARp3cSVRps7nn9vi8Qhg6Epy+QYFWFdiZKob25KDRJ
0VFb90kf6q6H8dNuwnkV5/NDA4xcoddps/FFQ5jnm5UqxRl8NTmMhDCYomfACm6c
hx0ePSMEM29FQmbr2xFVrfmS7onMBgByE+yWk6WXgbOUtdqzBXAGlXMdNA+sju39
xnEOrPhtEg==
=JAUe
-----END PGP SIGNATURE-----