drwxr-xr-x root/root         0 2023-01-22 01:39 ./
drwxr-xr-x root/root         0 2023-01-22 01:39 ./usr/
-rw-r--r-- root/root      1532 2022-02-02 16:17 ./usr/LICENSE

Note that it's caught by lintian:

W: python3-xmlrunner: file-in-unusual-dir [usr/LICENSE]
I: python3-xmlrunner: extra-license-file [usr/LICENSE]
I: python3-xmlrunner: package-contains-documentation-outside-usr-share-doc
[usr/LICENSE]

Hi,

I have created a patch to remove usr/LICENSE. Additionally replaced
setup.py tests with pytest to fix autopkgtests. I have attached the
debdiff containing these changes for your review.

Cheers!
Yogeswaran.

Hi,

I have created a patch to remove usr/LICENSE. Additionally replaced
setup.py tests with pytest to fix autopkgtests. I have attached the
debdiff containing these changes for your review.

Cheers!
Yogeswaran.

Why is replacing setup.py test with pytest fixing the tests?

You can use execute_after_dh_auto_install

There is no very strong reason for upstream to install the LICENSE in the
upstream package too. Instead of removing it in d/rules, can you patch the code
itself and make a PR upstream?

You disabled 2 tests that are passing at build time. That means there's
something wrong with the way autopkgtests are run or something else. Can you try
to fix the autopkgtests w/o skipping anything?

Best,
Nilesh

Hi,

It won't fix any failed tests. In the latest update I have migrated the
tests to autopkgtest testsuite and created a patch. I have attached the
updated debdiff.

As you recommended, I have created a patch to fix the issue, and
forwarded the patch to the upstream.

After migrating the tests to the autopkgtest testsuite, one of the tests
failed. I have created a patch for that failed test, and forwarded the
patch to the upstream.

I have forked the git in Salsa to fix these issues,
https://salsa.debian.org/yogu/python-xmlrunner

Once you review the changes, I will do a MR.

Thank you!
Yogeswaran.

The order of patches should be opposite. (0001 and then 0002 and 0003 :))

Otherwise LGTM. You can upload it yourself.

| $ dcut ssh-upload dm --uid kd8mbd@gmail.com --allow python-xmlrunner
| Uploading commands file to ssh.upload.debian.org (incoming: /srv/upload.debian.org/UploadQueue/)
| Picking DM Yogeswaran Umasankar (Debian Packaging Key) <kd8mbd@gmail.com> with fingerprint 5F7DDE9CAFE9CD9D083BEE3F47DAC12E5D3610E6
| SCP is deprecated. Please consider upgrading to SFTP.
| Uploading nilesh-1717961837.dak-commands to ssh-upload
| $ echo $?
| 0

Best,
Nilesh

Missed to comment on this. It should ideally be cleaned up post testing, no?
Not a big issue either way.

Best,
Nilesh

Hi,

Yes it should be ideally cleaned post testing, thank you.

I have reordered the patches in ascending order. Did MR in Salsa.

Thank you for providing upload permission. I did 7-day deferred upload
just in case if the package maintainer wants to revise something. I
understand thats not the usual case in team uploads, but for NMU.

Cheers!
Yogeswaran.