#1068560 "Recommends: thin-provisioning-tools" is insufficient or unnecessary

Package:
lvm2
Source:
lvm2
Description:
Linux Logical Volume Manager
Submitter:
Vincent Lefevre
Date:
2024-04-09 12:03:03 UTC
Severity:
normal
#1068560#5
Date:
2024-04-07 09:39:12 UTC
From:
To:
Due to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857142
lvm2 currently has "Recommends: thin-provisioning-tools".
But in new Debian installations, lvm2 is installed without
this package. If thin-provisioning-tools is really expected
to be installed by default, something else needs to be done.
Otherwise this Recommends is just unnecessary.

#1068560#10
Date:
2024-04-08 07:35:35 UTC
From:
To:
It is necessary to implement the cache and thin parts.

Bastian

#1068560#15
Date:
2024-04-08 08:16:55 UTC
From:
To:
Control: reopen -1
I repeat: thin-provisioning-tools is *not* installed by default,
contrary to lvm2. The "Recommends:" does *nothing* for core packages
like lvm2.

For instance, on a machine recently installed (which was the status
just after the installation):

disset:~> dpkg -s lvm2
Package: lvm2
Status: install ok installed
[...]

disset:~> dpkg -s thin-provisioning-tools
dpkg-query: package 'thin-provisioning-tools' is not installed and no information is available

#1068560#22
Date:
2024-04-08 08:47:36 UTC
From:
To:
Hi

Please stop ping-pong.

lvm2 is not a core package.  It is installed like everything else.

Bastian

#1068560#39
Date:
2024-04-09 11:54:05 UTC
From:
To:
Summary of bug(s) so far: lvm2 installed by d-i without its Recommends
Question: Can we solve this once and for all or do we need/want a
 workaround and/or downgrade for lvm2 only to make user happy
[only pun intended]

Merging both into #931283 that seems to be about the same thing.

He likely meant that you have installed it, "like everything else"
because that is what users usually do and you weren't particular clear
that you haven't – and what you used that did for you… lvm2 isn't
"a core package", so there are certainly ways of installing Debian
(even with d-i, which isn't the only way either) without lvm2.

d-i seems to install packages without recommends:
https://salsa.debian.org/installer-team/base-installer/-/blob/master/library.sh?ref_type=heads#L152
That is later dropped for "everything else", but I suppose lvm2 is
installed before that – but I don't know much about d-i or lvm2.


Anyway, it probably isn't a good idea to have d-i install all recommends
while it sets up the machine – better things to do and all that –, but
perhaps it can as one of the last actions (final_apt_preferences ?) run
something like:
| apt-get install --fix-policy
(after the config is removed, or add --install-recommends).

Likely involves demoting some 'Recommends' in the base set to 'Suggests'
through, but they behave like that already if installed by d-i, so that
is probably for the best for consistency alone.

In any case, I will leave d-i folks have fun with this now,
but feel free to ask apt-team if there is something we can help with.


Best regards

David Kalnischkies