Hi

The update for cockpit in DSA 5655-1 had problems with the
test-sshbridge test, causing FTBFS:

From the tail of the test failure:

# cockpit-protocol-DEBUG: test-ssh: output queue empty

(cockpit-ssh:3731): cockpit-ssh-WARNING **: 20:51:17.702: (src/ssh/cockpitsshrelay.c:1423):cockpit_ssh_connect: runtime check failed: (ssh_options_set (data->session, SSH_OPTIONS_HOST, host) == 0)

(cockpit-ssh:3731): cockpit-ssh-WARNING **: 20:51:17.702: (src/ssh/cockpitsshrelay.c:1424):cockpit_ssh_connect: runtime check failed: (ssh_options_parse_config (data->session, NULL) == 0)
# cockpit-protocol-DEBUG: test-ssh: reading input 1
# cockpit-protocol-DEBUG: test-ssh: received a 82 byte payload
# cockpit-protocol-DEBUG: test-ssh: want more data
**
cockpit-ssh:ERROR:src/ssh/test-sshbridge.c:560:wait_until_transport_init: assertion failed (json_object_get_string_member (init, "command") == "init"): ("authorize" == "init")
Bail out! cockpit-ssh:ERROR:src/ssh/test-sshbridge.c:560:wait_until_transport_init: assertion failed (json_object_get_string_member (init, "command") == "init"): ("authorize" == "init")
cockpit-ssh-Message: 20:51:17.704: cockpit-ssh some_host: -1 couldn't connect: Hostname required 'some_host' '22'
cockpit-ssh-Message: 20:51:17.704: couldn't write control message: Broken pipe
cockpit-ssh-Message: 20:51:17.704: couldn't write authorize message: Inappropriate ioctl for device
FAIL test-sshbridge (exit status: 134)

Regards,
Salvatore

found 1069059 239-1
found 1069059 287-1
tags 1069059 + bullseye bookworm
thanks

El 15/4/24 a las 19:28, Salvatore Bonaccorso escribió:
before the DSA. (Reminder for myself: report all the bugs I found
last week while rebuilding bullseye and bookworm).

Thanks.

Hello Salvatore and Santiago,

Salvatore Bonaccorso [2024-04-15 19:28 +0200]:
http://snapshot.debian.org/package/libssh/0.10.5-3/ but fails with current 0.10.6-0+deb12u1.

The reason is annoyingly mundane, and already got fixed upstream half a year ago:
https://github.com/cockpit-project/cockpit/commit/518d36c3492020525

I prepared a package update with that fix cherry-picked. See attached debdiff.
It builds fine in a clean bookworm container now.
But I don't know how exactly to target and upload this: to bookworm-security or
-updates? It's a follow-up for a previous security update to make that actually
work, but not a security update in itself.

Santiago Vila [2024-04-15 20:28 +0200]:

Right, that makes sense. There are no C code changes between 287 and 287.1.

Thanks, and sorry for the trouble,

Martin

Hi Martin,

Technically speaking, as the issue is present already before the DSA
release, you are right and the proposed update way would have been the
way to go. *But* we have a released security-update wich de-facto does
not reach the users right now, so I propose to release the regression
fix trough a security and make it a DSA regression announce.

Can you please upload to security-master?

Regards,
Salvatore

We believe that the bug you reported is fixed in the latest version of
cockpit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1069059@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Martin Pitt <mpitt@debian.org> (supplier of updated cockpit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 16 Apr 2024 09:20:17 +0200
Source: cockpit
Architecture: source
Version: 287.1-0+deb12u2
Distribution: bookworm-security
Urgency: medium
Maintainer: Utopia Maintenance Team <pkg-utopia-maintainers@lists.alioth.debian.org>
Changed-By: Martin Pitt <mpitt@debian.org>
Closes: 1069059
Changes:
 cockpit (287.1-0+deb12u2) bookworm-security; urgency=medium
 .
   * Add 0001-ssh-Use-valid-host-name-in-test-sshbridge.patch:
     Use valid host name in test-sshbridge. Fixes FTBFS due to unit test
     failure when building against libssh 0.10.6. (Closes: #1069059)
Checksums-Sha1:
 e8da99efc2b80e9921e144ee195c934a5f922f77 3048 cockpit_287.1-0+deb12u2.dsc
 b88b13b296f16e65fa7b7039646bf3850e4c8207 19840 cockpit_287.1-0+deb12u2.debian.tar.xz
 3351c41b8a64a7316db25042ad03773846c5108b 10118 cockpit_287.1-0+deb12u2_source.buildinfo
Checksums-Sha256:
 e26120e378db8411980af6cdba7175baeeb3c08e5be249ec9e8f5f92fdc2e3b7 3048 cockpit_287.1-0+deb12u2.dsc
 4d8efe41c4892971707e4f17de0d3ab834ef9fb7d14a81a259638d299f9dcdb4 19840 cockpit_287.1-0+deb12u2.debian.tar.xz
 42c547f16542f62d7ccf2b8ad9881a1f30323f3e4a5293caa1ccd91c91bb2dd1 10118 cockpit_287.1-0+deb12u2_source.buildinfo
Files:
 e2c4e09664c61f1413e751a3a5c9f34c 3048 admin optional cockpit_287.1-0+deb12u2.dsc
 ddcaea3eb9d9ac147a336b17a643ec83 19840 admin optional cockpit_287.1-0+deb12u2.debian.tar.xz
 d4ccc2483498007e8067d1b374e4a749 10118 admin optional cockpit_287.1-0+deb12u2_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEbEuHi35jHxYFV8PN7nvd5LhrVxMFAmYeJwIACgkQ7nvd5Lhr
VxMxbw/+L2rX2Uf/AMWXdHYsB2H9TNIWgG3zPrSnXLJcMcwD5ncGlZ1RfsNhzlds
naAhbifzYcoV3lMU4hmKagzQxtVv7xnQJZZd4d2MRQMKAa8dxtfhnjM/kJhXLFOH
+Wa+eFuyUZIowZFg83qYSKMJXA549TIQOkCCSj5Ddbd6ds4xvjVbJNy8bpzh521n
8Vlr/vfKl/i0tNAeS1Md6cwAEXIa/mdCsj4+SHuzQO1LqftPMa8ZY5IiqoYNCOgP
4/6yg3tgxBsNoCR9vAxTc0qmEPVCz5CEnN/0wATDBabtSxEpNzt6ena6dJpH3bDm
Ua5q+fzmpJDy8WCerfauqZiwvR0RduQ49HuLsClcewaX6X8j0SlNz+yRw7KjFGhq
6KQmZggBpNKogYnNiDcNmfHvffscCEmYBHXSo+bxwmeJ1ei0761HRjSkyWvpjg6d
WvcKSk9XC/DdEOs4daaZ/fuY6LX7/JUGbGQ+LUeYuDz8YMHT+yarIoeGFuAVQDrz
mSVJsTsTO9Trmwh7nBuQaAPhlW2uhOrZP1I4Qr0KqXaPV3/0tWmbUESfZMb9cioN
45ioCm+nMIlOGl738FbI0O1z2cvwX/eC+rmIM/VuzMSPjRT9eRksmLI70vwOpGbc
lRPFpzyjgeVamqwQ1HPAnX+z8xCUEXS0FwX4k5rmmIMnYOLguJc=
=EcEW
-----END PGP SIGNATURE-----