#1069939 networkd-dispatcher: please remove dependency on python3-mock

#1069939#5
Date:
2024-04-27 10:58:09 UTC
From:
To:
Dear Maintainer,

python3-mock is not usefull in a Python3-only world.

Here's a patch to remove it.

I see you are also active in the upstream repository;
so it should be trivial.

Greetings


diff --git a/debian/control b/debian/control
index 777e335..05ed46b 100644
--- a/debian/control
+++ b/debian/control
@@ -12,7 +12,6 @@ Build-Depends: asciidoc,
                iw | wireless-tools,
                python3-dbus,
                python3-gi,
-               python3-mock,
                python3-pytest,
                python3:any,
                xsltproc
diff --git a/tests/test_networkd-dispatcher.py b/tests/test_networkd-dispatcher.py
index 7b270d2..4c1cd7a 100644
--- a/tests/test_networkd-dispatcher.py
+++ b/tests/test_networkd-dispatcher.py
@@ -3,13 +3,13 @@ from collections import namedtuple
 import dbus
 import errno
 import logging
-import mock
+from unittest import mock
 import os
 import socket
 import subprocess
 import sys
 import pytest
-from mock import patch
+from unittest.mock import patch
 myPath = os.path.dirname(os.path.abspath(__file__))
 sys.path.insert(0, myPath + '/../')
 import networkd_dispatcher
diff --git a/tox.ini b/tox.ini
index 02cc761..b4fd7a3 100644
--- a/tox.ini
+++ b/tox.ini
@@ -14,7 +14,6 @@ deps =
     pytest
     PyGObject
     pytest-cov
-    mock
 commands =
     python3 -V
     python3 -m pytest --cov=networkd_dispatcher --cov-report term-missing -q tests

#1069939#12
Date:
2026-09-10 10:54:33 UTC
From:
To:
Dear maintainer,

I've prepared an NMU for networkd-dispatcher (versioned as 2.2.4-1.2) and
uploaded it to DELAYED/15. Please feel free to tell me if I
should cancel it.

Regards.

diffstat for networkd-dispatcher-2.2.4 networkd-dispatcher-2.2.4

 changelog                 |    7 +++++++
 control                   |    1 -
 patches/remove_mock.patch |   18 ++++++++++++++++++
 patches/series            |    1 +
 4 files changed, 26 insertions(+), 1 deletion(-)

diff -Nru networkd-dispatcher-2.2.4/debian/changelog networkd-dispatcher-2.2.4/debian/changelog
--- networkd-dispatcher-2.2.4/debian/changelog	2024-07-11 14:52:59.000000000 +0200
+++ networkd-dispatcher-2.2.4/debian/changelog	2026-09-10 12:47:09.000000000 +0200
@@ -1,3 +1,10 @@
+networkd-dispatcher (2.2.4-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Patch-out usage of python3-mock (Closes: #1069939)
+
+ -- Alexandre Detiste <tchet@debian.org>  Thu, 10 Sep 2026 12:47:09 +0200
+
 networkd-dispatcher (2.2.4-1.1) unstable; urgency=medium

   * Non-maintainer upload.
diff -Nru networkd-dispatcher-2.2.4/debian/control networkd-dispatcher-2.2.4/debian/control
--- networkd-dispatcher-2.2.4/debian/control	2023-04-24 17:32:27.000000000 +0200
+++ networkd-dispatcher-2.2.4/debian/control	2026-09-10 12:47:09.000000000 +0200
@@ -12,7 +12,6 @@
                iw | wireless-tools,
                python3-dbus,
                python3-gi,
-               python3-mock,
                python3-pytest,
                python3:any,
                xsltproc
diff -Nru networkd-dispatcher-2.2.4/debian/patches/remove_mock.patch networkd-dispatcher-2.2.4/debian/patches/remove_mock.patch
--- networkd-dispatcher-2.2.4/debian/patches/remove_mock.patch	1970-01-01 01:00:00.000000000 +0100
+++ networkd-dispatcher-2.2.4/debian/patches/remove_mock.patch	2026-09-10 12:46:32.000000000 +0200
@@ -0,0 +1,18 @@
+--- a/tests/test_networkd-dispatcher.py
++++ b/tests/test_networkd-dispatcher.py
+@@ -3,13 +3,13 @@
+ import dbus
+ import errno
+ import logging
+-import mock
++from unittest import mock
+ import os
+ import socket
+ import subprocess
+ import sys
+ import pytest
+-from mock import patch
++from unittest.mock import patch
+ myPath = os.path.dirname(os.path.abspath(__file__))
+ sys.path.insert(0, myPath + '/../')
+ import networkd_dispatcher
diff -Nru networkd-dispatcher-2.2.4/debian/patches/series networkd-dispatcher-2.2.4/debian/patches/series
--- networkd-dispatcher-2.2.4/debian/patches/series	2023-04-24 17:32:27.000000000 +0200
+++ networkd-dispatcher-2.2.4/debian/patches/series	2026-09-10 12:45:55.000000000 +0200
@@ -1,2 +1,3 @@
 0001-Patch-etc-conf.d-p.conf-to-etc-default-p.patch
 0002-networkd-dispatcher.conf-Run-startup-triggers-by-def.patch
+remove_mock.patch

#1069939#21
Date:
2026-09-25 11:49:21 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
networkd-dispatcher, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1069939@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alexandre Detiste <tchet@debian.org> (supplier of updated networkd-dispatcher package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 10 Sep 2026 12:47:09 +0200
Source: networkd-dispatcher
Architecture: source
Version: 2.2.4-1.2
Distribution: unstable
Urgency: medium
Maintainer: Julian Andres Klode <jak@debian.org>
Changed-By: Alexandre Detiste <tchet@debian.org>
Closes: 1069939
Changes:
 networkd-dispatcher (2.2.4-1.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Patch-out usage of python3-mock (Closes: #1069939)
Checksums-Sha1:
 c67486c924693dbfcdc1e27f8aa1908eee276c9d 2140 networkd-dispatcher_2.2.4-1.2.dsc
 9a639ef3d767ab537338f850694aace2bc4243d3 5284 networkd-dispatcher_2.2.4-1.2.debian.tar.xz
 2b1ade12bdcedd6fbeea8ebf4dd53f7bc1571ef6 7253 networkd-dispatcher_2.2.4-1.2_source.buildinfo
Checksums-Sha256:
 c72790bf41b244614655c7fa3817a334ea435a99493201a1af75a5fec4c0af38 2140 networkd-dispatcher_2.2.4-1.2.dsc
 4bcb2330ace9681c246385812ae4f3a3ba7e260fc0e6e478163768e6d0c06a30 5284 networkd-dispatcher_2.2.4-1.2.debian.tar.xz
 84cb63fbdbf7a7004a923464fe4d049ee1d4a6f693ef739c73c6a549f85ec8c1 7253 networkd-dispatcher_2.2.4-1.2_source.buildinfo
Files:
 1fce5b43df00210c1ebb6a16aa98bae3 2140 utils optional networkd-dispatcher_2.2.4-1.2.dsc
 b1afca2ab5c54aa1a0cd2292f2c9b5ac 5284 utils optional networkd-dispatcher_2.2.4-1.2.debian.tar.xz
 71f13c90551bd91f5e0d6aad6418a00c 7253 utils optional networkd-dispatcher_2.2.4-1.2_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmqijEURHHRjaGV0QGRl
Ymlhbi5vcmcACgkQMfMURUShdBoMeQ/8C/hXErXro4TP+OtfRuwj/e20b/e9iwfB
HE/AX0fTkOVxMpnwbIU7lCnQt7S9vj5l3fERKKcdVya4IIWDl7VKBZTCQweIfWpz
TDwCEKen4ElVWBKcVkcmq02GEJwWnu9HaAsKWM4bO8QsNTc7xv7HSmxufbLeypp7
M2wfjZRkOA1pCDil5YdBJ4ttsbpivAi49/M+zG8+uCMnufyP7Sy+9kh1cwUabMpN
W0P6tdRG6GXytwG4OVi+f2NMCk6sAdolBcvlQEBaGfbuARAszOyELdtXPozHLklK
BgjXpDwZI9IsAuRGj8OGTjrKt7zGuZeertDQ9nkp0v8ALuYsBa3yMVcmqTY7wtce
SiZ4Cuvc6tczfRZDDaDH8vnqy+qzh1S6E0TA3PJIGxrIg1pMs2LvJEMkKsR3OLKk
tKLuYu9eLwH1zaDWmGJQdeviXhfSt0/c32aGCgsNoXXoz1NVXV12eBVZVdtJ8MHi
JHVNcN9ujQyAlPRjPCGQafRO1oEQ3hQOMm0WLod2VTqIWsZ7GnmQ+M3kkGeKYtJD
APO14Qu/9O/eTNfyGPzu4SLvP5g5Py8th64f9qRdW/pGhpDS52G0owrz87b8HJWc
sQM5+bzfqoQg6S+M0vTo+rmoJa33ZShYj/u9OQ9FxKlMSVVAgzrf2Z5rb9eHlFK3
gWPTBbrb5Zw=
=dCJz
-----END PGP SIGNATURE-----