#1070410 golang-github-pion-webrtc.v3 accesses the internet during build

#1070410#5
Date:
2024-05-05 05:53:04 UTC
From:
To:
Hi,

golang-github-pion-webrtc.v3 attempts network access during build.
This is forbidden by Policy 4.9:

  For packages in the main archive, required targets must not attempt
  network access, except, via the loopback interface, to services on the
  build host that have been started by the build.

This can be tested with the sbuild unshare backend:

=== NAME  TestDataChannelParamters_Go
    util.go:41: Unexpected routines on test end:
        goroutine 34 [select]:
        github.com/pion/interceptor/pkg/nack.(*GeneratorInterceptor).loop(0xc0000240a0, {0x9f4b80, 0xc00003ec30})
                /<<PKGBUILDDIR>>/_build/src/github.com/pion/interceptor/pkg/nack/generator_interceptor.go:139 +0x12d
        created by github.com/pion/interceptor/pkg/nack.(*GeneratorInterceptor).BindRTCPWriter in goroutine 16
                /<<PKGBUILDDIR>>/_build/src/github.com/pion/interceptor/pkg/nack/generator_interceptor.go:74 +0x115

        goroutine 35 [select]:
        github.com/pion/interceptor/pkg/report.(*ReceiverInterceptor).loop(0xc0001303c0, {0x9f4b80, 0xc00003ec30})
                /<<PKGBUILDDIR>>/_build/src/github.com/pion/interceptor/pkg/report/receiver_interceptor.go:97 +0x19c
        created by github.com/pion/interceptor/pkg/report.(*ReceiverInterceptor).BindRTCPWriter in goroutine 16
                /<<PKGBUILDDIR>>/_build/src/github.com/pion/interceptor/pkg/report/receiver_interceptor.go:86 +0x115

        goroutine 36 [select]:
        github.com/pion/interceptor/pkg/report.(*SenderInterceptor).loop(0xc000130420, {0x9f4b80, 0xc00003ec30})
                /<<PKGBUILDDIR>>/_build/src/github.com/pion/interceptor/pkg/report/sender_interceptor.go:98 +0x19c
        created by github.com/pion/interceptor/pkg/report.(*SenderInterceptor).BindRTCPWriter in goroutine 16
                /<<PKGBUILDDIR>>/_build/src/github.com/pion/interceptor/pkg/report/sender_interceptor.go:87 +0x115

[...]

Cheers Jochen

#1070410#12
Date:
2024-05-11 11:36:26 UTC
From:
To:
Quoting Jochen Sprickerhof <jspricke@debian.org>:

Are you sure about this? I don't think so.

I built this in an offline environment w/o any internet access and it builds just
OK. Furthermore I compared the logs with the one in buildd and I did not see
anything unusual.

I tried building this in an offline setting, didn't use unshare backend. Does
the latter do anything differently?

I don't see any of these failures either. Please comment?

Best,
Nilesh

#1070410#17
Date:
2024-05-11 12:18:40 UTC
From:
To:
Hi.

Have you tried tcpdump while the tests are running?

I see a DNS query for stun.l.google.com, which is also
somewhere in the code. I believe DNS queries count
as "internet access" and are not allowed.

Thanks.

#1070410#22
Date:
2024-05-11 12:49:38 UTC
From:
To:
That is only for peer connection tests. A bunch of other tests should not fail
imho.

Uhm, fine. For now I will disable the testsuite and upload, don't have more time
to investigate. Thanks for helping me out.
Best,
Nilesh

#1070410#25
Date:
2024-05-11 12:58:20 UTC
From:
To:
Hello,

Bug #1070410 in golang-github-pion-webrtc.v3 reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/go-team/packages/golang-github-pion-webrtc/-/commit/7c58b0d3b53314afeba4e10debc1248fad054483

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1070410

#1070410#32
Date:
2024-05-11 13:04:26 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
golang-github-pion-webrtc.v3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1070410@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nilesh Patra <nilesh@debian.org> (supplier of updated golang-github-pion-webrtc.v3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sat, 11 May 2024 18:20:37 +0530
Source: golang-github-pion-webrtc.v3
Architecture: source
Version: 3.1.56-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed-By: Nilesh Patra <nilesh@debian.org>
Closes: 1070410
Changes:
 golang-github-pion-webrtc.v3 (3.1.56-3) unstable; urgency=medium
 .
   * Disable tests (Closes: #1070410)
   * Bump Standards-Version to 4.7.0 (no changes needed)
Checksums-Sha1:
 9485c84bfe857e8ba897a619bafcc4d35c1d712f 2208 golang-github-pion-webrtc.v3_3.1.56-3.dsc
 c721b93dfefec79d07c6a5a32f2524da3f4f0606 3944 golang-github-pion-webrtc.v3_3.1.56-3.debian.tar.xz
 cec4135febc2c5986afdc415605beda1033831e7 6631 golang-github-pion-webrtc.v3_3.1.56-3_amd64.buildinfo
Checksums-Sha256:
 23334ce6009a68fd29c6b4ac5cbff8b9f2c9f6d1ac7b95604ec1d35864f77c4f 2208 golang-github-pion-webrtc.v3_3.1.56-3.dsc
 71141501e33ebf2a68a6aa6d41d0e7be65a820fbc1cb64515ffac7fd32d54560 3944 golang-github-pion-webrtc.v3_3.1.56-3.debian.tar.xz
 86a073220e656bc54843fbf4569db07e0df2fd6542f5436f04def27db0b7c927 6631 golang-github-pion-webrtc.v3_3.1.56-3_amd64.buildinfo
Files:
 7c27c600848e813bc30102ff5cb07bb5 2208 golang optional golang-github-pion-webrtc.v3_3.1.56-3.dsc
 83224c62d05f250841c126967dcc4908 3944 golang optional golang-github-pion-webrtc.v3_3.1.56-3.debian.tar.xz
 39e2207f5a3ad9b8d7910c22b2da104b 6631 golang optional golang-github-pion-webrtc.v3_3.1.56-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQSglbZu4JAkvuai8HIqJ5BL1yQ+2gUCZj9rIQAKCRAqJ5BL1yQ+
2mVwAP4s94Q6d/AiULBeTOfJZyZyGRtKQSTwv32VhMRu0R9YIAEApjBMAzNkqRUu
jzr/qEMcVivKlbPAD6Fe5LI//TAZyw8=
=HiY+
-----END PGP SIGNATURE-----