#1072630 r-cran-dplyr: autopkgtest regression in testing

#1072630#5
Date:
2024-06-05 11:37:19 UTC
From:
To:
Hi Maintainer

Sometime around 2024-02-16, r-cran-dplyr's autopkgtest regressed in
testing [1].  I've copied what I hope is the relevant part of the log
below.

Regards
Graham


[1] https://ci.debian.net/packages/r/r-cran-dplyr/testing/amd64/


157s ══ Failed tests
════════════════════════════════════════════════════════════════
157s ── Failure ('test-rows.R:161:3'): rows_update() works
──────────────────────────
157s `expect_identical(...)` produced warnings.
157s ── Failure ('test-rows.R:258:3'): rows_patch() works
───────────────────────────
157s `expect_identical(...)` produced warnings.
157s
157s [ FAIL 2 | WARN 5031 | SKIP 329 | PASS 2860 ]
159s Error: Test failures
159s Execution halted

#1072630#10
Date:
2024-10-31 16:33:26 UTC
From:
To:
I have opened an issue upstream: https://github.com/tidyverse/dplyr/issues/7099
#1072630#17
Date:
2024-11-06 00:31:36 UTC
From:
To:
Hello,

we have a package, r-cran-dplyr, that runs the upstream test suite as
part of its autopkgtests.  Unfortunately it fails when it tries to set
the en_US locale to test support of non-UTF locales; maybe it is not
available in the default environment of debci?  Do people know a way to
make en_US available in that context?

https://ci.debian.net/packages/r/r-cran-dplyr/unstable/amd64/53464906/

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1072630

More details follow.

On line 325 of the package's `tests/testthat/test-arrange.R` there is:

    skip_if_not(has_collate_locale("en_US"), message = "Can't use 'en_US' locale")

This leads to the emission of the warning "Can't use 'en_US' locale",
which causes autopkgtest to fail.

I am aware of two possible solutions that I would like to avoid:

 1) Patch the test suite so that it does not run that test.
 2) Allow autopkgtest to ignore warnings.

Both of them equate to put dust in the corner and run only the tests
that are the least likely to fail, which puts into question why we would
run upstream tests at all.

So if you know a good way to enable debci to provide the needed locale
to debci, please let me know.

Have a nice day,

Charles

#1072630#22
Date:
2024-11-06 01:00:48 UTC
From:
To:
Hi,

I believe that the thread starting with
https://lists.debian.org/msgid-search/YqGFE7eF7wUX9LM7@torres.zugschlus.de
was for tests running during packaging, but the same tricks can be used
for autopkgtests too.

I've done the following in a similar situation:

    Test-Command: mkdir -p tests/.locale &&
     localedef -c -i en_US -f UTF-8 tests/.locale/en_US.utf8 &&
     env LOCPATH="$(pwd)/tests/.locale" test_command
    Depends: locales, […]

Or just ‘Depends: locales-all’ but that'll lead to slightly longer
running tests.

Cheers,

#1072630#27
Date:
2024-12-07 08:38:57 UTC
From:
To:
Hi all,

sorry for the dplyr-related mass removal from Testing.

r-cran-dplyr is marked for autoremoval on December 12 and I did not
expect nor pay attention that its dependencies would be reomved 5 days
before…

I have uploaded r-cran-dplyr_1.1.4-3_source.changes that disables the
test suite.

Have a nice week-end,

Charles

Le Sun, Nov 24, 2024 at 08:44:04AM +0900, Charles Plessy a écrit :