#1075525 softether-vpn: ftbfs with GCC-14

#1075525#5
Date:
2024-07-03 12:44:34 UTC
From:
To:
[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/softether-vpn_5.01.9674+git20200806+8181039+dfsg3-1_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:710:90: note: expected ‘CK_OBJECT_HANDLE_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c: In function ‘EnumSecObject’:
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1216:53: error: passing argument 2 of ‘sec->Api->C_FindObjects’ from incompatible pointer type [-Wincompatible-pointer-types]
 1216 |         if (sec->Api->C_FindObjects(sec->SessionId, objects, sizeof(objects) / sizeof(objects[0]), &num_objects) != CKR_OK)
      |                                                     ^~~~~~~
      |                                                     |
      |                                                     UINT * {aka unsigned int *}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1216:53: note: expected ‘CK_OBJECT_HANDLE_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1216:100: error: passing argument 4 of ‘sec->Api->C_FindObjects’ from incompatible pointer type [-Wincompatible-pointer-types]
 1216 |         if (sec->Api->C_FindObjects(sec->SessionId, objects, sizeof(objects) / sizeof(objects[0]), &num_objects) != CKR_OK)
      |                                                                                                    ^~~~~~~~~~~~
      |                                                                                                    |
      |                                                                                                    UINT * {aka unsigned int *}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1216:100: note: expected ‘CK_ULONG_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c: In function ‘WriteSecData’:
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1337:83: error: passing argument 4 of ‘sec->Api->C_CreateObject’ from incompatible pointer type [-Wincompatible-pointer-types]
 1337 |         if (sec->Api->C_CreateObject(sec->SessionId, a, sizeof(a) / sizeof(a[0]), &object) != CKR_OK)
      |                                                                                   ^~~~~~~
      |                                                                                   |
      |                                                                                   UINT * {aka unsigned int *}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1337:83: note: expected ‘CK_OBJECT_HANDLE_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c: In function ‘OpenSecSession’:
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1621:66: error: passing argument 5 of ‘sec->Api->C_OpenSession’ from incompatible pointer type [-Wincompatible-pointer-types]
 1621 |                 CKF_RW_SESSION | CKF_SERIAL_SESSION, NULL, NULL, &session)) != CKR_OK)
      |                                                                  ^~~~~~~~
      |                                                                  |
      |                                                                  UINT * {aka unsigned int *}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1621:66: note: expected ‘CK_SESSION_HANDLE_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1626:57: error: passing argument 5 of ‘sec->Api->C_OpenSession’ from incompatible pointer type [-Wincompatible-pointer-types]
 1626 |                         CKF_SERIAL_SESSION, NULL, NULL, &session)) != CKR_OK)
      |                                                         ^~~~~~~~
      |                                                         |
      |                                                         UINT * {aka unsigned int *}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1626:57: note: expected ‘CK_SESSION_HANDLE_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c: In function ‘OpenSec’:
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1714:56: error: passing argument 3 of ‘sec->Api->C_GetSlotList’ from incompatible pointer type [-Wincompatible-pointer-types]
 1714 |         if ((err = sec->Api->C_GetSlotList(true, NULL, &sec->NumSlot)) != CKR_OK || sec->NumSlot == 0)
      |                                                        ^~~~~~~~~~~~~
      |                                                        |
      |                                                        UINT * {aka unsigned int *}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1714:56: note: expected ‘CK_ULONG_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1724:46: error: passing argument 2 of ‘sec->Api->C_GetSlotList’ from incompatible pointer type [-Wincompatible-pointer-types]
 1724 |         if (sec->Api->C_GetSlotList(TRUE, sec->SlotIdList, &sec->NumSlot) != CKR_OK)
      |                                           ~~~^~~~~~~~~~~~
      |                                              |
      |                                              UINT * {aka unsigned int *}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1724:46: note: expected ‘CK_SLOT_ID_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1724:60: error: passing argument 3 of ‘sec->Api->C_GetSlotList’ from incompatible pointer type [-Wincompatible-pointer-types]
 1724 |         if (sec->Api->C_GetSlotList(TRUE, sec->SlotIdList, &sec->NumSlot) != CKR_OK)
      |                                                            ^~~~~~~~~~~~~
      |                                                            |
      |                                                            UINT * {aka unsigned int *}
/<<PKGBUILDDIR>>/src/Mayaqua/Secure.c:1724:60: note: expected ‘CK_ULONG_PTR’ {aka ‘long unsigned int *’} but argument is of type ‘UINT *’ {aka ‘unsigned int *’}
make[3]: *** [src/Mayaqua/CMakeFiles/mayaqua.dir/build.make:275: src/Mayaqua/CMakeFiles/mayaqua.dir/Secure.c.o] Error 1
make[3]: *** Waiting for unfinished jobs....
[ 80%] Linking C static library ../../libcedar.a
cd /<<PKGBUILDDIR>>/src/Cedar && /usr/bin/cmake -P CMakeFiles/cedar.dir/cmake_clean_target.cmake
cd /<<PKGBUILDDIR>>/src/Cedar && /usr/bin/cmake -E cmake_link_script CMakeFiles/cedar.dir/link.txt --verbose=1
/usr/bin/ar qc ../../libcedar.a CMakeFiles/cedar.dir/Account.c.o CMakeFiles/cedar.dir/Admin.c.o CMakeFiles/cedar.dir/AzureClient.c.o CMakeFiles/cedar.dir/AzureServer.c.o CMakeFiles/cedar.dir/Bridge.c.o CMakeFiles/cedar.dir/BridgeUnix.c.o CMakeFiles/cedar.dir/BridgeWin32.c.o CMakeFiles/cedar.dir/CM.c.o CMakeFiles/cedar.dir/Cedar.c.o CMakeFiles/cedar.dir/CedarPch.c.o CMakeFiles/cedar.dir/Client.c.o CMakeFiles/cedar.dir/Command.c.o CMakeFiles/cedar.dir/Connection.c.o CMakeFiles/cedar.dir/Console.c.o CMakeFiles/cedar.dir/DDNS.c.o CMakeFiles/cedar.dir/Database.c.o CMakeFiles/cedar.dir/EM.c.o CMakeFiles/cedar.dir/EtherLog.c.o CMakeFiles/cedar.dir/Hub.c.o CMakeFiles/cedar.dir/IPC.c.o CMakeFiles/cedar.dir/Layer3.c.o CMakeFiles/cedar.dir/Link.c.o CMakeFiles/cedar.dir/Listener.c.o CMakeFiles/cedar.dir/Logging.c.o CMakeFiles/cedar.dir/NM.c.o CMakeFiles/cedar.dir/Nat.c.o CMakeFiles/cedar.dir/NativeStack.c.o CMakeFiles/cedar.dir/NullLan.c.o CMakeFiles/cedar.dir/Proto.c.o CMakeFiles/cedar.dir/Proto_EtherIP.c.o CMakeFiles/cedar.dir/Proto_IKE.c.o CMakeFiles/cedar.dir/Proto_IPsec.c.o CMakeFiles/cedar.dir/Proto_IkePacket.c.o CMakeFiles/cedar.dir/Proto_L2TP.c.o CMakeFiles/cedar.dir/Proto_OpenVPN.c.o CMakeFiles/cedar.dir/Proto_PPP.c.o CMakeFiles/cedar.dir/Proto_SSTP.c.o CMakeFiles/cedar.dir/Proto_Win7.c.o CMakeFiles/cedar.dir/Protocol.c.o CMakeFiles/cedar.dir/Radius.c.o CMakeFiles/cedar.dir/Remote.c.o CMakeFiles/cedar.dir/SM.c.o CMakeFiles/cedar.dir/SW.c.o CMakeFiles/cedar.dir/Sam.c.o CMakeFiles/cedar.dir/SeLowUser.c.o CMakeFiles/cedar.dir/SecureInfo.c.o CMakeFiles/cedar.dir/SecureNAT.c.o CMakeFiles/cedar.dir/Server.c.o CMakeFiles/cedar.dir/Session.c.o CMakeFiles/cedar.dir/UT.c.o CMakeFiles/cedar.dir/UdpAccel.c.o CMakeFiles/cedar.dir/VG.c.o CMakeFiles/cedar.dir/VLan.c.o CMakeFiles/cedar.dir/VLanUnix.c.o CMakeFiles/cedar.dir/VLanWin32.c.o CMakeFiles/cedar.dir/Virtual.c.o CMakeFiles/cedar.dir/WaterMark.c.o CMakeFiles/cedar.dir/WebUI.c.o CMakeFiles/cedar.dir/WinUi.c.o CMakeFiles/cedar.dir/Wpc.c.o
/usr/bin/ranlib ../../libcedar.a
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
[ 80%] Built target cedar
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [CMakeFiles/Makefile2:296: src/Mayaqua/CMakeFiles/mayaqua.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:159: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:8: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

#1075525#16
Date:
2025-12-22 09:52:30 UTC
From:
To:
Hi Andrew,

Do you intend to do something about this bug in softether, or should
we instead remove it? It already missed trixie.

Thanks,
Chris

#1075525#21
Date:
2025-12-22 09:57:31 UTC
From:
To:
Hi,

Honestly, I stopped caring about softether quite some time ago. I asked for help in #1030780, but nobody really picked it up. So, if nobody else cares about it, maybe it’s the time to let it go.

Or maybe I should make the last call in the bug, and if nobody actually starts doing anything about in a month, we proceed with the removal.

#1075525#26
Date:
2026-07-05 15:34:25 UTC
From:
To:
On Mon, 22 Dec 2025 10:57:31 +0100 "Andrej Shadura" <andrew@shadura.me> wrote:
Any updates here?

I was considering whether I should work for a patch for #1122779, but if
the package is going to be removed anyway, then I would not waste time
on that.

Regards,
Michael