My original patch to add Appstream metainfo XML announcing the hardware
handled by this package had a mistake, caused by my unfortunate
cut-n-paste. This patch solve the problem. The problem was the
incorrect component type. The desktop type is reserved for those with
.desktop files. Without this patch, the appstream database do not
include the information provided.
The appstream metadata file can be checked using this command after
package build:
appstreamcli validate-tree --no-net --explain debian/w1retap
diff --git a/debian/patches/add-appstream-metainfo.patch b/debian/patches/add-appstream-metainfo.patch
index 2ee2c37..efddbad 100644
--- a/debian/patches/add-appstream-metainfo.patch
+++ b/debian/patches/add-appstream-metainfo.patch
@@ -5,11 +5,13 @@ Author: Petter Reinholdtsen
Forwarded: no
Bug-Debian: http://bugs.debian.org/1076450
Last-Update: 2024-07-16
---- /dev/null
-+++ w1retap/uk.co.zen.zen35309.wx.w1retap.metainfo.xml
+Index: w1retap-salsa/uk.co.zen.zen35309.wx.w1retap.metainfo.xml
+===================================================================
+--- /dev/null 1970-01-01 00:00:00.000000000 +0000
++++ w1retap-salsa/uk.co.zen.zen35309.wx.w1retap.metainfo.xml 2024-08-17 10:22:52.029923756 +0200
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
-+<component type="desktop">
++<component>
+ <id>uk.co.zen.zen35309.wx.w1retap</id>
+ <metadata_license>MIT</metadata_license>
+ <name>w1retap</name>
@@ -27,9 +29,11 @@ Last-Update: 2024-07-16
+ <modalias>usb:v04FAp2490d*</modalias>
+ </provides>
+</component>
---- w1retap.orig/meson.build
-+++ w1retap/meson.build
-@@ -90,6 +90,7 @@ executable(
+Index: w1retap-salsa/meson.build
+===================================================================
+--- w1retap-salsa.orig/meson.build 2024-08-17 10:22:35.089768939 +0200
++++ w1retap-salsa/meson.build 2024-08-17 10:23:04.000000000 +0200
+@@ -81,6 +81,7 @@
)
install_data([ 'README.md'], install_dir : get_option('datadir') / 'doc' / 'w1retap' )
Please let me know if there anything I can do to help get this fix into Debian.
Apologies I've let this slip, I'll have a look next week. Kind Regards Tom
[Thomas Stewart 2024-12-01] Very good. I hope you did not find any problems.
Anything I can do to help get this fix into unstable?
We believe that the bug you reported is fixed in the latest version of w1retap, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1078858@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Thomas Stewart <thomas@stewarts.org.uk> (supplier of updated w1retap package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) Format: 1.8 Date: Fri, 17 Jan 2025 02:35:29 +0000 Source: w1retap Architecture: source Version: 1.5.5-2 Distribution: unstable Urgency: medium Maintainer: Thomas Stewart <thomas@stewarts.org.uk> Changed-By: Thomas Stewart <thomas@stewarts.org.uk> Closes: 1078858 Changes: w1retap (1.5.5-2) unstable; urgency=medium . * Update add-appstream-metainfo.patch (Closes: #1078858) * Run wrap-and-sort . * Upload sponsored by Petter Reinholdtsen. Checksums-Sha1: fc9514bdfc20421946f22de26b5f6f15c0812134 2441 w1retap_1.5.5-2.dsc 008e0b9a1eb50e287bf7d8bea5cf667212dd63dd 14544 w1retap_1.5.5-2.debian.tar.xz 2fa49458b5ce419696e0ba346593afd3401895c1 8895 w1retap_1.5.5-2_source.buildinfo Checksums-Sha256: 5b90abbb5efbbdd2700649fd2bb74195a5dfde2e1fac7788a0781dd840c2c684 2441 w1retap_1.5.5-2.dsc 06042b5a9da7b8c72a2a378f6d453225f6e69b8bb07bda8957201bc2002f65ab 14544 w1retap_1.5.5-2.debian.tar.xz 80898bbc82895a004ba5b706ef92735f4b632cfd8dee43272e5b1393e47f6619 8895 w1retap_1.5.5-2_source.buildinfo Files: 759d551aaac30c3186f3a043738e3c90 2441 electronics optional w1retap_1.5.5-2.dsc 0d056a2314001425175bcb2d4a820bac 14544 electronics optional w1retap_1.5.5-2.debian.tar.xz 564a292943feca90e15634d3190b9acd 8895 electronics optional w1retap_1.5.5-2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEERqLf4owIeylOb9kkgSgKoIe6+w4FAmeKAoAACgkQgSgKoIe6 +w4Ohg//aM+ORawism5eqsMnNbiu874ZsbUm0U1UgIjxAyqykD2blKauvt5PH0hy gHwLhY3WuVmvniD+VrXk8EkxBf9SFtz8QQR4ypf1kZ6gODxF6EiJOQEpYn3Ah6xs AUSQ1fgPb/Da2kDeba4WhjOk1ysdDE5s2jv0eNshB/ROWM7QOSPEqmst9K7zZynG wsPfiUU0M7XGWegNfEJ1ufAhINlfCFDFGG16zELTiJV4rACKIUOBO/2zRBMvMfhq 0LWxAB6+YnYAnAtDxGq8J4X/l5uQ6oGkeNrCzYfDuJDjdG7+DmAbZjW8naoVAHJj p4YQqd5EvGbWf9LIeYzfv1e3w6XGyHUCzyd3gtnbx5OY2IvkLy4EFALoZo+Qpbt7 vbNpmgUSrSo7/rii6KDuQJl1cb2m9hAMAgr4gSfH8rVuCmmSUJQ4dNb7l4RFxazZ bmhvtrimguTSWFFxGS8b8u3jn2aZ0CszbhCrq+Y4aOcO66UgDsjxvr+fWD362Vt8 3p1UJ6sIb51Y3R+vV3jCASSyH5ikK0mA9vXSbKwzAweW7HJXtVTWtXOj4/MFqdIX p0pM0ZZaLcjRReEqNGPHX/KZm3wRsctnFgs5Y9t2vEh4/Cueg5inZlnFQTPLBrko EvP6zmigulAaxGfnrZwQYGFRX0PjAv1FyZa26pY9gsl1ZrtOK9U= =hPiS -----END PGP SIGNATURE-----
Hi Petter, Thanks for the reminder to get this done, and thanks for the upload! Kind Regards Tom
[Thomas Stewart] Happy to assist, and happy to report that isenkram-lookup now include w1retap using AppStream. Note the updates I did to the changelog. These should be checked into git. Tried to mention it via IRC, but there was no-one else in the other end when I replied.
Great, noted and done. :) Kind Regards Tom