Fabre

#1080242 RFS: electrum-nmc/4.0.6-2 [ITP] -- Easy to use Namecoin client #1080242

Package:: sponsorship-requests

Source:: sponsorship-requests

Submitter:

Date:: 2025-01-18 02:57:02 UTC

Severity:: normal

Tags:

#1080242#5

Date:: 2024-08-31 22:25:52 UTC

From:

To:

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "electrum-nmc":

  * Package name     : electrum-nmc
    Version          : 4.0.6-2
    Upstream contact : Jeremy Rand <jeremy@namecoin.org>
  * URL              : https://www.namecoin.org/docs/electrum-nmc/
  * License          : GPL-3+, DejaVu, Expat, BSD-3-clause, OFL-1.1,
BSD-2-clause
  * Vcs              : https://github.com/nvoyak/electrum-nmc-debian.git
    Section          : utils

The source builds the following binary packages:

   python3-electrum-nmc - Easy to use Namecoin client - Python module
   electrum-nmc - Easy to use Namecoin client

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/electrum-nmc/

Alternatively, you can download the package with 'dget' using this
command:

   dget -x
https://mentors.debian.net/debian/pool/main/e/electrum-nmc/electrum-nmc_4.0.6-2.dsc

Changes for the initial release:

  electrum-nmc (4.0.6-2) unstable; urgency=medium
  .
    * Correction in watch file
    * Correction in copyright file
    * Added forwarding status to Fix-libsecp256k1-path.patch

Regards,

#1080242#12

Date:: 2024-09-01 07:52:42 UTC

From:

To:

Nicholas,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issue

I: electrum-nmc source: uses-deprecated-python-stdlib chunk (deprecated in
Python 3.11, removed in Python 3.13)
[electrum_nmc/electrum/blockchain.py:586]
N:
N:
N:   In Python $deprecated, $library has been formally marked as deprecated.
N:   Code that imports $library will no longer work from Python $removed.
N:
N:   Please prepare for this deprecation and migrate away from this Python
N:   library.
N:
N:   See-Also: https://peps.python.org/pep-0594/#deprecated-modules
N:
N:   Visibility: info
N:   Show-Always: no
N:   Check: languages/python/stdlib-deprecation
N:
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:71]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:75]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:76]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:77]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:78]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:79]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:80]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:83]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:84]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib distutils (deprecated
in Python 3.10, removed in Python 3.12)
[electrum_nmc/electrum/gui/qt/update_checker.py:7]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/bitbox02.png]
N:
N:   This package installs a pixmap or a bitmap within /usr/lib. According to
N:   the Filesystem Hierarchy Standard, architecture-independent files should
N:   be placed within /usr/share instead.
N:
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: images
N:
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/bitbox02_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/bitcoin.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/camera_dark.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/camera_white.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock1.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock2.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock3.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock4.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock5.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/coldcard.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/coldcard_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/confirmed.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/copy.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/digitalbitbox.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/digitalbitbox_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_dark_icon.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_launcher.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_light_icon.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_nmc.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_presplash.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrumb.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/expired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/eye1.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/file.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/info.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/keepkey.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/keepkey_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/key.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/ledger.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/ledger_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/lightning.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/lock.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/microphone.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/namecoin-logo.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/network.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/offline_tx.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/preferences.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/qrcode.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/qrcode_white.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/revealer.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/revealer_c.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/safe-t.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/safe-t_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/seal.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/seed.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/speaker.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_connected.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_connected_fork.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_connected_proxy.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_connected_proxy_fork.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_disconnected.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_lagging.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_lagging_fork.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_waiting.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_addresses.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_coins.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_console.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_contacts.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_history.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_receive.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_send.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tor_logo.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/trezor.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/trezor_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/trustedcoin-status.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/trustedcoin-wizard.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/unconfirmed.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/unlock.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/unpaid.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/update.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/warning.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/zoom.png]


3. Licenses [4]: Issue, false positives possible

philwyett@ks-tarkin:~/Development/builder/debian/mentoring/electrum-nmc-
4.0.6$ lrc
: Versions: recon 1.16  check 3.3.9-1

Parsing Source Tree  ....
Reading copyright    ....
Running licensecheck ....

d/copyright     | licensecheck

Expat           | GPL-3            Electrum_NMC.egg-info/PKG-INFO
Expat           | GPL-3            PKG-INFO
Expat           | OFL-1.1
electrum_nmc/electrum/gui/kivy/data/fonts/tron/License.txt

4. Watch file [uscan --force-download]: Issue

philwyett@ks-tarkin:~/Development/builder/debian/mentoring/electrum-nmc-
4.0.6$ uscan --force-download
Newest version of electrum-nmc on remote site is 4.0.6.4.0.6, local version
is 4.0.6
 => Newer package available from:
        =>
https://www.namecoin.org/files/electrum-nmc/electrum-nmc-4.0.6/Electrum-NMC-sourceonly-4.0.6.tar.gz
gpgv: Signature made Fri Dec 22 05:51:24 2023 GMT
gpgv:                using EDDSA key A0BE08C865661A9316E0A7FF762ED28DA5C007DA
gpgv: Good signature from "Jeremy Rand (Namecoin Electrum-NMC Binary Signing
Key) <jeremy@namecoin.org>"
Successfully renamed ../Electrum-NMC-sourceonly-4.0.6.tar.gz to ../electrum-
nmc_4.0.6.4.0.6.orig.tar.gz.

Would it not be easier to pull from the GitHub tags of the package?

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Not performed at this time

8. Upgrade [Over previous installs if any]: N/A

Additional...

A. Debian version for a new release/package into needs to be '-1'. So version
needs to be '4.0.6.-1'.

B. Changelog entry for an new package to Debian should be as below (your
package).

electrum-nmc (4.0.6-1) unstable; urgency=low
 .
   * Initial Release. (Closes: #1077302)

Summary...

I believe electrum-nmc is not yet ready for sponsorship at this time. Could
the contributor rectify one of more of the rasied issues. Once updated to
your satisfaction and a new upload done, please remove the 'moreinfo' tag on
the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

#1080242#15

Date:: 2024-09-01 07:52:42 UTC

From:

To:

Nicholas,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issue

I: electrum-nmc source: uses-deprecated-python-stdlib chunk (deprecated in
Python 3.11, removed in Python 3.13)
[electrum_nmc/electrum/blockchain.py:586]
N:
N:
N:   In Python $deprecated, $library has been formally marked as deprecated.
N:   Code that imports $library will no longer work from Python $removed.
N:
N:   Please prepare for this deprecation and migrate away from this Python
N:   library.
N:
N:   See-Also: https://peps.python.org/pep-0594/#deprecated-modules
N:
N:   Visibility: info
N:   Show-Always: no
N:   Check: languages/python/stdlib-deprecation
N:
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:71]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:75]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:76]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:77]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:78]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:79]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:80]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:83]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib crypt (deprecated in
Python 3.11, removed in Python 3.13) [electrum_nmc/electrum/crypto.py:84]
N:
I: electrum-nmc source: uses-deprecated-python-stdlib distutils (deprecated
in Python 3.10, removed in Python 3.12)
[electrum_nmc/electrum/gui/qt/update_checker.py:7]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/bitbox02.png]
N:
N:   This package installs a pixmap or a bitmap within /usr/lib. According to
N:   the Filesystem Hierarchy Standard, architecture-independent files should
N:   be placed within /usr/share instead.
N:
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: images
N:
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/bitbox02_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/bitcoin.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/camera_dark.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/camera_white.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock1.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock2.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock3.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock4.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/clock5.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/coldcard.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/coldcard_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/confirmed.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/copy.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/digitalbitbox.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/digitalbitbox_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_dark_icon.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_launcher.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_light_icon.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_nmc.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrum_presplash.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/electrumb.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/expired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/eye1.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/file.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/info.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/keepkey.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/keepkey_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/key.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/ledger.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/ledger_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/lightning.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/lock.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/microphone.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/namecoin-logo.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/network.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/offline_tx.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/preferences.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/qrcode.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/qrcode_white.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/revealer.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/revealer_c.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/safe-t.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/safe-t_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/seal.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/seed.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/speaker.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_connected.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_connected_fork.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_connected_proxy.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_connected_proxy_fork.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_disconnected.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_lagging.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_lagging_fork.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/status_waiting.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_addresses.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_coins.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_console.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_contacts.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_history.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_receive.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tab_send.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/tor_logo.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/trezor.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/trezor_unpaired.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/trustedcoin-status.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/trustedcoin-wizard.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/unconfirmed.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/unlock.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/unpaid.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/update.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/warning.png]
N:
P: python3-electrum-nmc: image-file-in-usr-lib [usr/lib/python3/dist-
packages/electrum_nmc/electrum/gui/icons/zoom.png]


3. Licenses [4]: Issue, false positives possible

philwyett@ks-tarkin:~/Development/builder/debian/mentoring/electrum-nmc-
4.0.6$ lrc
: Versions: recon 1.16  check 3.3.9-1

Parsing Source Tree  ....
Reading copyright    ....
Running licensecheck ....

d/copyright     | licensecheck

Expat           | GPL-3            Electrum_NMC.egg-info/PKG-INFO
Expat           | GPL-3            PKG-INFO
Expat           | OFL-1.1
electrum_nmc/electrum/gui/kivy/data/fonts/tron/License.txt

4. Watch file [uscan --force-download]: Issue

philwyett@ks-tarkin:~/Development/builder/debian/mentoring/electrum-nmc-
4.0.6$ uscan --force-download
Newest version of electrum-nmc on remote site is 4.0.6.4.0.6, local version
is 4.0.6
 => Newer package available from:
        =>
https://www.namecoin.org/files/electrum-nmc/electrum-nmc-4.0.6/Electrum-NMC-sourceonly-4.0.6.tar.gz
gpgv: Signature made Fri Dec 22 05:51:24 2023 GMT
gpgv:                using EDDSA key A0BE08C865661A9316E0A7FF762ED28DA5C007DA
gpgv: Good signature from "Jeremy Rand (Namecoin Electrum-NMC Binary Signing
Key) <jeremy@namecoin.org>"
Successfully renamed ../Electrum-NMC-sourceonly-4.0.6.tar.gz to ../electrum-
nmc_4.0.6.4.0.6.orig.tar.gz.

Would it not be easier to pull from the GitHub tags of the package?

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Not performed at this time

8. Upgrade [Over previous installs if any]: N/A

Additional...

A. Debian version for a new release/package into needs to be '-1'. So version
needs to be '4.0.6.-1'.

B. Changelog entry for an new package to Debian should be as below (your
package).

electrum-nmc (4.0.6-1) unstable; urgency=low
 .
   * Initial Release. (Closes: #1077302)

Summary...

I believe electrum-nmc is not yet ready for sponsorship at this time. Could
the contributor rectify one of more of the rasied issues. Once updated to
your satisfaction and a new upload done, please remove the 'moreinfo' tag on
the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

#1080242#20

Date:: 2024-09-11 13:28:09 UTC

From:

To:

In a previous review it was mentioned that the
"uses-deprecated-python-stdlib" lintian output was "Information only,
future for upstream." To clarify, is this still the case, or has it been
long enough for it to become an issue?

Is this uscan confusion (4.0.6.4.0.6) a problem? If so I suppose I could
indeed pull from GitHub.

Ermm, sorry about that. Fixed.

#1080242#25

Date:: 2024-09-16 18:16:36 UTC

From:

To:

Nicholas,

An updated review.

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Additional...

A. Please change version to '-1' as this is a new release/package and must be
this before entering Debian.

e.g.

electrum-nmc (4.0.6-1) unstable; urgency=low

Summary...

I believe electrum-nmc is ready for review/possible sponsorship. Could a
Debian Developer (DD) with available free time, please review this package
and upload if you feel it is ready and appropriate for the distribution.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

#1080242#30

Date:: 2024-09-16 18:16:36 UTC

From:

To:

Nicholas,

An updated review.

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Additional...

A. Please change version to '-1' as this is a new release/package and must be
this before entering Debian.

e.g.

electrum-nmc (4.0.6-1) unstable; urgency=low

Summary...

I believe electrum-nmc is ready for review/possible sponsorship. Could a
Debian Developer (DD) with available free time, please review this package
and upload if you feel it is ready and appropriate for the distribution.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

#1080242 RFS: electrum-nmc/4.0.6-2 [ITP] -- Easy to use Namecoin client #1080242

Just Reply to ...

Reply to submitter ...

Send control command (Silently)

Set Architecture Tags (Silently)