#1081091 prads: FTBFS: mac.c:335:6: error: type of ‘eth_hdr’ defaults to ‘int’ [-Wimplicit-int]

Package:
src:prads
Source:
src:prads
Submitter:
Santiago Vila
Date:
2025-08-11 15:24:46 UTC
Severity:
normal
Tags:
#1081091#5
Date:
2024-09-07 23:53:46 UTC
From:
To:
Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:
--------------------------------------------------------------------------------
[...]
  debian/rules build
dh build
    dh_update_autotools_config
    dh_autoreconf
    dh_auto_configure
    debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_build -- CONFDIR=/etc/prads RELEASE=-debian
	make -j2 "INSTALL=install --strip-program=true" CONFDIR=/etc/prads RELEASE=-debian
make[2]: Entering directory '/<<PKGBUILDDIR>>'
You need libpcre-dev and libpcap-dev to compile this program.
make CONFDIR=/etc/prads -C src/
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o bstrlib.o bstrlib.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o sig_tcp.o sig_tcp.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o config.o config.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o sys_func.o sys_func.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o assets.o assets.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o prads.o prads.c
prads.c: In function ‘prads_initialize’:
prads.c:1261:13: warning: ‘pcap_lookupdev’ is deprecated: use 'pcap_findalldevs' and use the first device [-Wdeprecated-declarations]
  1261 |             conf->dev = pcap_lookupdev(conf->errbuf);
       |             ^~~~
In file included from /usr/include/pcap.h:43,
                  from common.h:11,
                  from prads.c:31:
/usr/include/pcap/pcap.h:444:18: note: declared here
   444 | PCAP_API char   *pcap_lookupdev(char *);
       |                  ^~~~~~~~~~~~~~
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o dhcp.o dhcp.c
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o dump_dns.o dump_dns.c
dump_dns.c: In function ‘dump_dns’:
dump_dns.c:142:5: warning: ‘__p_rcode’ is deprecated [-Wdeprecated-declarations]
   142 |     fprintf(trace, "%s,%s,%u", _res_opcodes[opcode], p_rcode(rcode), id);
       |     ^~~~~~~
In file included from dump_dns.c:55:
/usr/include/resolv.h:260:17: note: declared here
   260 | const char *    p_rcode (int) __THROW __RESOLV_DEPRECATED;
       |                 ^~~~~~~
dump_dns.c: In function ‘dump_dns_rr’:
dump_dns.c:209:13: warning: ‘__p_class’ is deprecated [-Wdeprecated-declarations]
   209 |             ns_rr_name(*rr), p_class(class), p_type(type));
       |             ^~~~~~~~~~
/usr/include/resolv.h:257:17: note: declared here
   257 | const char *    p_class (int) __THROW __RESOLV_DEPRECATED;
       |                 ^~~~~~~
dump_dns.c:209:13: warning: ‘__p_type’ is deprecated [-Wdeprecated-declarations]
   209 |             ns_rr_name(*rr), p_class(class), p_type(type));
       |             ^~~~~~~~~~
/usr/include/resolv.h:259:17: note: declared here
   259 | const char *    p_type (int) __THROW __RESOLV_DEPRECATED;
       |                 ^~~~~~
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -DCONFDIR='"/etc/prads/"' -D__USE_GNU -Wdate-time -D_FORTIFY_SOURCE=2  -c -o mac.o mac.c
mac.c: In function ‘arp_check’:
mac.c:335:6: error: type of ‘eth_hdr’ defaults to ‘int’ [-Wimplicit-int]
   335 | void arp_check(eth_hdr, tstamp)
       |      ^~~~~~~~~
mac.c:335:6: error: type of ‘tstamp’ defaults to ‘int’ [-Wimplicit-int]
make[3]: *** [<builtin>: mac.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:15: build] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j2 "INSTALL=install --strip-program=true" CONFDIR=/etc/prads RELEASE=-debian returned exit code 2
make[1]: *** [debian/rules:11: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:8: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202409/

About the archive rebuild: The build was made on virtual machines
of type m6a.large and r6a.large from AWS, using sbuild and a
reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Thanks.