#1085344 compton: calls dbus_get_local_machine_id() which has bad error-handling

Package:
src:compton
Source:
src:compton
Submitter:
Simon McVittie
Date:
2026-01-10 11:07:02 UTC
Severity:
normal
Tags:
#1085344#5
Date:
2024-10-18 13:44:03 UTC
From:
To:
compton calls dbus_get_local_machine_id(), which has no good mechanism
for reporting an error, and therefore will spam warnings to standard error
(and possibly crash) if the D-Bus machine ID has not been set up correctly.
This function should be considered deprecated.

If it is necessary to call this function, please prefer to use
dbus_try_get_local_machine_id(), which takes a DBusError parameter and
therefore can be used to report errors in whatever way is considered to
be most appropriate by the caller. This has been available in upstream
stable releases since dbus 1.12.0 (2017).

It looks as though compton only calls dbus_get_local_machine_id()
because it's implementing the o.fd.DBus.Peer interface. I suspect
that this might not be necessary at all, because libdbus will usually
implement the o.fd.DBus.Peer interface for you anyway, without needing
application-specific code to be written for it. So maybe the code that
implements o.fd.DBus.Peer.GetMachineId and ….Peer.Ping can just be deleted?

Thanks,
    smcv

#1085344#10
Date:
2026-01-10 10:10:54 UTC
From:
To:
Es gibt eine Familienspende in Höhe von 1.850.000,00 USD von Cheng Charlie
Saephan. Bitte antworten Sie für weitere Informationen. Denken Sie daran,
Ihrer Familie und den Bedürftigen in Ihrer Umgebung Gutes zu tun.

Dies ist bereits der zweite Versuch, Sie zu erreichen. Bitte antworten Sie
für weitere Details.