#1087028 licenserecon: EPL as false positive because of phrase "Eclipse Reference Manua" in comment #1087028
- Package:
- licenserecon
- Source:
- licenserecon
- Description:
- Reconcile licenses from debian/copyright against licensecheck
- Submitter:
- Markus Blatt
- Date:
- 2025-01-01 13:09:02 UTC
- Severity:
- normal
- Tags:
Dear Maintainer, I have a source file with this comment in it: /*! * \ingroup BlackOilSimulator * * \brief This class calculates the threshold pressure for grid faces according to the * Eclipse Reference Manual. * * If the difference of the pressure potential between two cells is below the threshold * pressure, the pressure potential difference is assumed to be zero, if it is larger * than the threshold pressure, it is reduced by the threshold pressure. */ If I run lcr on the source package containing it then it thinks that this file is licensed under EPL because of the word Eclipse appearing in the comment. Kind regards, Markus
<snip> Hi Markus, I assume you are referring to opm/simulators/flow/FlowThresholdPressure.hpp in package opm-simulators ? The comment does say; "This class calculates the threshold pressure for grid faces according to the Eclipse Reference Manual" and as the Manual is licensed under EPL, this does not seem unreasonable to me to show the file license as "EPL and/or GPL-2+". That is what licensecheck reports. (You could report the bug there) Note, you can override this by adding a debian/lrc.config file to the package. [Attached] I suggest adding a comment to it (prefix with #). Regards, Peter
Thanks for reporting this. It seems that the word Eclipse, case sensitive, the first word on a line and followed by white-space is sufficient for licensecheck to detect license as including EPL. It should surely need the whole phrase "Eclipse Public License"? Regards, Peter
We believe that the bug you reported is fixed in the latest version of licenserecon, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1087028@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Peter Blackman <peter@pblackman.plus.com> (supplier of updated licenserecon package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) Format: 1.8 Date: Wed, 01 Jan 2025 11:03:17 +0000 Source: licenserecon Architecture: source Version: 3.3 Distribution: unstable Urgency: medium Maintainer: Peter Blackman <peter@pblackman.plus.com> Changed-By: Peter Blackman <peter@pblackman.plus.com> Closes: 1087028 Changes: licenserecon (3.3) unstable; urgency=medium . * Rename GPL2 module * Fix misdetection of RSA license as NTP * Fix misdetection of EPL license, Closes: #1087028 * Add test files for above fixes and simplify d/copyright * Allow 'or' in d/copyright to match licensecheck's 'and/or' Checksums-Sha1: 51826c68ceff26af8e7f8a7243afc8279c136764 1770 licenserecon_3.3.dsc 5e63249b61826329915eb00cabf3b52bc923a8ec 27636 licenserecon_3.3.tar.xz fc9f7861fc45a757f04c90df32eaf36042c04671 7342 licenserecon_3.3_source.buildinfo Checksums-Sha256: 3eb4b7333b2657f5e5ea2eae738a8f588492c2959c6bb7ff043f8a60bc4a65e0 1770 licenserecon_3.3.dsc 9873dd10a76bb5fa07df8bb5cca2364c278eedd634e89f795f61f21aaf29fc0d 27636 licenserecon_3.3.tar.xz 640c63842bf417c90b713662fddd4a228028ade96665bd5878644c527f5ad5e0 7342 licenserecon_3.3_source.buildinfo Files: 91b0883ea332265596afcb4a739aae5f 1770 utils optional licenserecon_3.3.dsc 7328eaf30b40f8cc4a00148ac1f35409 27636 utils optional licenserecon_3.3.tar.xz 17e616b482b38699a51d55310ef2db3f 7342 utils optional licenserecon_3.3_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJNBAEBCgA3FiEE33HzyvBUkEl4+kj4tty6Zj6hsVAFAmd1OawZHHBldGVyQHBi bGFja21hbi5wbHVzLmNvbQAKCRC23LpmPqGxUEmKEACJZCL6X4xrdOKwePZ5WW5m sNYouRmM5BJ+U07P8vZTR+x/iGuu5b7S2dB2HJbv2wLax6Fvni9aIQ2VP2YQyxNe Nclm9oDR9bLv89PzCmmt7M7b/5Bg9iZpbuq1ZvjCfF/KWvm5gtT7hP0NnxqmDNRc ia9hSjmCJauSpJyxnRJ7cPN2Du05nZo+28DBzi/9detdvQu4jcaJvdFgRlaC3v2f b02vlUluar0J4emv11nq67Bl+1iszk/vBns6JmMqYyS4VdAcR4VJN8cJVLW1RdzS ehH2xOSOOyklx9qGEiG9UFesm19svINc6hiILgeEaDcVhACUq0UF6jjgGy8UDYC9 djxitN4gH8bz0Islm8TqmWK5jCVjzAswbnuJXAf7j2eU1fjPNSY2RnC6jiHmtd3V Vvuy6krpv5ndZ4kI7LirbuYuxW39NVpNtvoauaPommgLV5eLbfdHo0hk5JtKtxxq gxJl+UdLW6cUohoObNdgh2FrZEjV3FaHKgYLZedkGS2idoVyRbXakfP/LOUKJ2lu 2ChwFQ2azOJPqoaSOjpZHm9ZbJCbGFPkbhwsOp1wKIScC0J6DTfPcQ8cu5kGyzY+ nNXNRsIUrWGgqabDxCIb64HivOqNMXsUGX+FuvhSP8pltFOFAvT3tayUzHGkJ2ty Es+H/zbaY6iUp+Tg+AOSpQ== =DjvY -----END PGP SIGNATURE-----