#1087469 gnome-system-tools fails to build in Ubuntu due to enabled -Wincompatible-pointer-types

#1087469#5
Date:
2024-11-14 01:34:03 UTC
From:
To:
Dear Maintainer,

When building package in Ubuntu it fails to build due to the enabled
-Wincompatible-pointer-types:
shares-tool.c: In function ‘install_packages’:
shares-tool.c:157:72: error: passing argument 2 of ‘gst_packages_install’ from
incompatible pointer type [-Wincompatible-pointer-types]
  157 |         retval = gst_packages_install (GTK_WINDOW (tool->main_dialog),
packages);
      |
^~~~~~~~
      |
|
      |
gchar ** {aka char **}
In file included from ../../src/common/gst.h:3,
                 from users-table.h:27,
                 from shares-tool.c:23:
../../src/common/gst-package.h:31:64: note: expected ‘const char **’ but
argument is of type ‘gchar **’ {aka ‘char **’}
   31 | gboolean gst_packages_install (GtkWindow *window, const char
**packages);
      |                                                   ~~~~~~~~~~~~~^~~~~~~~
make[5]: *** [Makefile:571: shares-tool.o] Error 1
make[5]: Leaving directory '/<<PKGBUILDDIR>>/src/shares'
make[4]: *** [Makefile:621: all-recursive] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/src/shares'
make[3]: *** [Makefile:408: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:538: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:447: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [/usr/share/cdbs/1/class/makefile.mk:77: debian/stamp-makefile-build]
Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

Would it be possible to consider adding the attached patch to resolve the
issue?

Thank you for considering the patch.