Dear Maintainer,
Proposing an update (https://salsa.debian.org/games-
team/minigalaxy/-/merge_requests/3)
to the new release 1.3.1, I'm hesitant about some changes in its dependencies.
For unrar | unrar-free, I think it could be removed.
$ rgrep "unrar" *
debian/changelog: * Add unrar-free as alternative to unrar (Closes: #1021558)
debian/copyright:Comment: depends on unrar, which is non-free
debian/control: unrar | unrar-free,
and I also checked the content of minigalaxy/installer.py.
Regarding the following, I think it might be better to suggest winetricks
instead of wine32
(and its long alternative list) which also pulls wine in the end.
$ rgrep "winetricks" *
data/po/el.po:msgstr "Αποτυχία εύρεσης winetricks.Δεν είναι δυνατή η χρήση
του."
data/ui/properties.ui: <object class="GtkButton"
id="button_properties_winetricks">
data/ui/properties.ui: <signal name="clicked"
handler="on_button_properties_winetricks_clicked" swapped="no"/>
minigalaxy/launcher.py:def winetricks_game(game):
minigalaxy/launcher.py: subprocess.Popen(['winetricks'])
minigalaxy/ui/properties.py:from minigalaxy.launcher import config_game,
regedit_game, winetricks_game
minigalaxy/ui/properties.py: button_properties_winetricks =
Gtk.Template.Child()
minigalaxy/ui/properties.py:
@Gtk.Template.Callback("on_button_properties_winetricks_clicked")
minigalaxy/ui/properties.py: def on_menu_button_winetricks(self, widget):
minigalaxy/ui/properties.py: if not shutil.which("winetricks"):
minigalaxy/ui/properties.py: winetricks_game(self.game)
minigalaxy/ui/properties.py:
self.button_properties_winetricks.set_sensitive(False)
minigalaxy/ui/properties.py:
self.button_properties_winetricks.hide()
Any opinion?
Thanks,
Patrice