#1095159 Please add support for win2k25

Package:
libguestfs0
Source:
libguestfs0
Description:
guest disk image management system - shared library
Submitter:
Thomas Goirand
Date:
2025-10-06 08:50:02 UTC
Severity:
normal
Tags:
#1095159#5
Date:
2025-02-04 15:39:42 UTC
From:
To:
Hi,

Thanks for the continous maintenance of libguestfs in Debian.
This is a very nice and valuable tool.

Currently, in lib/inspect-osinfo.c, the logic is like this:

        if (strstr (product_variant, "Server")) {
          if (strstr (product_name, "2022"))
            return safe_strdup (g, "win2k22");
          else if (strstr (product_name, "2019"))
            return safe_strdup (g, "win2k19");
          else
            return safe_strdup (g, "win2k16");
        } else
          return safe_strdup (g, "win10");

Clearly, there's no "win2k25". The attached patch is the one from
upstream with this sha256: 0f489f8eec0c02e9ed1d606a2032edccf81ef025
It adds the missing support.

As we use this to bill windows VMs in our public cloud, we would
love to have this fixed in Debian Stable (Bookworm) and old Stable
(Bullseye). If you cannot do it, or have no time for it, please
allow me to deal with such an update with the release team.

As for Unstable/Trixie, probably best would be to get the latest
from upstream, or to use the attached patch.

Cheers,

Thomas Goirand (zigo)
#1095159#10
Date:
2025-10-06 08:49:23 UTC
From:
To: