#1096305 ampliconnoise: ftbfs with GCC-15

#1096305#5
Date:
2025-02-17 17:03:04 UTC
From:
To:
[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/ampliconnoise_1.29-15_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
  210 |       fgets(szLine, MAX_LINE_LENGTH, ifp);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
SplitClusterClust.c: In function ‘readMapFile’:
SplitClusterClust.c:282:7: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  282 |       fgets(szLine, BIG_LINE_LENGTH, ifp);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
SplitClusterClust.c: In function ‘main’:
SplitClusterClust.c:52:29: warning: ‘%s’ directive writing up to 1023 bytes into a region of size between 0 and 1023 [-Wformat-overflow=]
   52 |       sprintf(szDatFile,"%s/%s%s",szDir,szDir,DAT_SUFFIX);
      |                             ^~          ~~~~~
In file included from /usr/include/stdio.h:970,
                 from SplitClusterClust.c:1:
In function ‘sprintf’,
    inlined from ‘main’ at SplitClusterClust.c:52:7:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 6 and 2052 bytes into a destination of size 1024
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
SplitClusterClust.c: In function ‘main’:
SplitClusterClust.c:88:29: warning: ‘%s’ directive writing up to 1023 bytes into a region of size between 0 and 1023 [-Wformat-overflow=]
   88 |       sprintf(szDatFile,"%s/%s%s",szDir,szDir,DAT_SUFFIX);
      |                             ^~          ~~~~~
In function ‘sprintf’,
    inlined from ‘main’ at SplitClusterClust.c:88:7:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 6 and 2052 bytes into a destination of size 1024
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
linking...
gcc -Wl,-z,relro -Wl,-z,now -o SplitClusterClust SplitClusterClust.o -lm
make[2]: Leaving directory '/build/reproducible-path/ampliconnoise-1.29/SplitClusterClust'
(cd Perseus && CFLAGS="-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ampliconnoise-1.29=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection" LDFLAGS="-Wl,-z,relro -Wl,-z,now" make)
make[2]: Entering directory '/build/reproducible-path/ampliconnoise-1.29/Perseus'
cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ampliconnoise-1.29=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -c Perseus.c
Perseus.c: In function ‘main’:
Perseus.c:56:3: error: too many arguments to function ‘initLookUp’; expected 0, have 1
   56 |   initLookUp(&tParams);
      |   ^~~~~~~~~~ ~~~~~~~~
In file included from Perseus.c:17:
Perseus.h:151:6: note: declared here
  151 | void initLookUp();
      |      ^~~~~~~~~~
Perseus.c: At top level:
Perseus.c:1232:6: error: conflicting types for ‘initLookUp’; have ‘void(t_Params *)’ {aka ‘void(struct s_Params *)’}
 1232 | void initLookUp(t_Params *ptParams)
      |      ^~~~~~~~~~
Perseus.h:151:6: note: previous declaration of ‘initLookUp’ with type ‘void(void)’
  151 | void initLookUp();
      |      ^~~~~~~~~~
Perseus.c: In function ‘initLookUp’:
Perseus.c:1249:7: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1249 |       fgets(szLine, MAX_LINE_LENGTH, ifp);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Perseus.c: In function ‘calcLoonIndex’:
Perseus.c:1640:3: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1640 |   system(szCommand);
      |   ^~~~~~~~~~~~~~~~~
make[2]: *** [makefile:13: Perseus.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/ampliconnoise-1.29/Perseus'
make[1]: *** [makefile:13: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/ampliconnoise-1.29'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:18: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

#1096305#14
Date:
2025-09-19 22:08:30 UTC
From:
To:
Dear maintainer,

I've prepared an NMU for ampliconnoise (versioned as 1.29-15.1) and
uploaded it to DELAYED/14. Please feel free to tell me if I should
cancel it.

cu
Adrian

#1096305#23
Date:
2025-09-21 15:55:50 UTC
From:
To:
I put this in a private fork in salsa and it does not build:

make[2]: Leaving directory '/build/package/package/SplitClusterClust'
(cd Perseus && make clean)
make[2]: Entering directory '/build/package/package/Perseus'
rm -rf *.o Perseus
make[2]: Leaving directory '/build/package/package/Perseus'
(cd PerseusD && make clean)
make[2]: Entering directory '/build/package/package/PerseusD'
rm -rf *.o PerseusD
make[2]: Leaving directory '/build/package/package/PerseusD'
(cd bin && rm -rf *)
/bin/sh: 1: cd: can't cd to bin
make[1]: *** [makefile:29: clean] Error 2
make[1]: Leaving directory '/build/package/package'
dh_auto_clean: error: make -j2 clean returned exit code 2
make: *** [debian/rules:18: clean] Error 25
dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2

It could be a glitch in salsa, because they switched to sbuild
recently, but I'm not happy that a NMU does not build in salsa
(even if it's a bug in salsa).

Thanks.

#1096305#28
Date:
2025-09-21 16:29:30 UTC
From:
To:
how that might fail when trying to build from git.

And it seems you have encountered the latter before in this package:
https://salsa.debian.org/med-team/ampliconnoise/-/commit/926e4681e5f7f7a83a18a85eaa0689f0a0d6141d

cu
Adrian

#1096305#31
Date:
2025-09-21 17:03:06 UTC
From:
To:
Hello,

Bug #1096305 in ampliconnoise reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/med-team/ampliconnoise/-/commit/b3a7efddfaa2aa72851aa02de71538fec78028bd

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1096305

#1096305#36
Date:
2025-09-21 17:11:11 UTC
From:
To:
Well spotted... I've now added a simple "mkdir -p bin" in
debian/rules, which seems a cleaner fix.

Uploaded as 1.29-16.

Thanks a lot.

#1096305#41
Date:
2025-09-21 17:19:50 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
ampliconnoise, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1096305@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Santiago Vila <sanvila@debian.org> (supplier of updated ampliconnoise package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 21 Sep 2025 18:55:00 +0200
Source: ampliconnoise
Architecture: source
Version: 1.29-16
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
Changed-By: Santiago Vila <sanvila@debian.org>
Closes: 1096305
Changes:
 ampliconnoise (1.29-16) unstable; urgency=medium
 .
   * Team upload.
   [ Adrian Bunk ]
   * Fix FTBFS with GCC 15. Closes: #1096305.
   [ Santiago Vila ]
   * Create bin directory before dh_auto_clean to make Salsa CI happy.
   * Update standards-version.
Checksums-Sha1:
 c8814c2255134c5edcc6ecd329d2867398b98e25 1801 ampliconnoise_1.29-16.dsc
 770865508dfb4b069fff0c5226bd47bc59da003f 12840 ampliconnoise_1.29-16.debian.tar.xz
 d9f61695500ca6d37ec941c20bf128485b1f8a9e 7524 ampliconnoise_1.29-16_source.buildinfo
Checksums-Sha256:
 5ad0c7015374a1b5630455e74c5fc0bc8df272b7dea7fb681616599fb680b8a5 1801 ampliconnoise_1.29-16.dsc
 b6236b2fd535c04ab51c2140b5b24616670276ea56e6186e3541d717e5873f06 12840 ampliconnoise_1.29-16.debian.tar.xz
 1dad2297786b402323772f3bee4f779b09c6ada4704ed9785f37a783220714a8 7524 ampliconnoise_1.29-16_source.buildinfo
Files:
 eca170cbd7a2ba7f75c0cc6c00b05244 1801 science optional ampliconnoise_1.29-16.dsc
 83efd9cd3848db814d9783ac51126d7f 12840 science optional ampliconnoise_1.29-16.debian.tar.xz
 ba956bd528846625c8ea6be314b1c56d 7524 science optional ampliconnoise_1.29-16_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEE1Uw7+v+wQt44LaXXQc5/C58bizIFAmjQL4QACgkQQc5/C58b
izI6NQf9HOw19pZehqTDO0jC2CevfPSxd7pRXCRhLrnd91juthoUmrjN7CaeUg05
IHMxFlzR1cM6cceantz1gZfhXo/tGIUw981C+1u/sH+xNSEwk7+sRQ/DwFdkKlG6
8gIpc1+NHTOxL43oHEjd3weHXO6O0g0rhkksyHbTEqtZK5tK6xr9ocGYhQp2ojEV
gZAwwxp8l73fF250eRvh78A/7pI80TDGLg4ytLAr5lbbt9CHRAa/Mjwbk5BTsh8W
rwA9+iEXCfQXPeVZM0ftdDtPOWNyLwwbTPIZeYrQSAZ+bDU+UEfWAJLxW7haEqGi
nImbdTIsndHjO+63jwmlSD8AmTphvw==
=Iv55
-----END PGP SIGNATURE-----