#1096393 briquolo: ftbfs with GCC-15

Package:
src:briquolo
Source:
src:briquolo
Submitter:
Matthias Klose
Date:
2025-10-05 11:35:02 UTC
Severity:
normal
Tags:
#1096393#5
Date:
2025-02-17 17:05:51 UTC
From:
To:
[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/briquolo_0.5.7-11_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
MOGL_Fenetre.h:53:12: note: there is 1 candidate
   53 |     struct CompareResolution
      |            ^~~~~~~~~~~~~~~~~
MOGL_Fenetre.h:55:14: note: candidate 1: ‘bool MOGL_Fenetre::CompareResolution::operator()(const MOGL_Fenetre::MOGL_Resolution&, const MOGL_Fenetre::MOGL_Resolution&)’ (near match)
   55 |         bool operator() (const MOGL_Resolution & x, const MOGL_Resolution & y)
      |              ^~~~~~~~
MOGL_Fenetre.h:55:14: note: passing ‘const MOGL_Fenetre::CompareResolution*’ as ‘this’ argument discards qualifiers
make[4]: *** [Makefile:482: MOGL_Fenetre.o] Error 1
make[4]: *** Waiting for unfinished jobs....
MOGL_FenetreKit.cpp: In member function ‘void MOGL_FenetreKit::Clavier(SDL_keysym*)’:
MOGL_FenetreKit.cpp:86:36: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings]
   86 |       _Fenetre.ScreenshotPrefixBMP("mogl");
      |                                    ^~~~~~
In file included from MOGL_GenerateurParticule.cpp:22:
MOGL_GenerateurParticule.h:55:20: warning: unnecessary parentheses in declaration of ‘_TabParticule’ [-Wparentheses]
   55 |     MOGL_Particule (*(* _TabParticule));
      |                    ^~~~~~~~~~~~~~~~~~~~
MOGL_GenerateurParticule.h:55:20: note: remove parentheses
   55 |     MOGL_Particule (*(* _TabParticule));
      |                    ^~~~~~~~~~~~~~~~~~~~
      |                    -                  -
MOGL_GenerateurParticule.h:55:22: warning: unnecessary parentheses in declaration of ‘_TabParticule’ [-Wparentheses]
   55 |     MOGL_Particule (*(* _TabParticule));
      |                      ^~~~~~~~~~~~~~~~~
MOGL_GenerateurParticule.h:55:22: note: remove parentheses
   55 |     MOGL_Particule (*(* _TabParticule));
      |                      ^~~~~~~~~~~~~~~~~
      |                      -               -
In file included from MOGL_GenPartFeu.h:25,
                 from MOGL_GenPartFeu.cpp:22:
MOGL_GenerateurParticule.h:55:20: warning: unnecessary parentheses in declaration of ‘_TabParticule’ [-Wparentheses]
   55 |     MOGL_Particule (*(* _TabParticule));
      |                    ^~~~~~~~~~~~~~~~~~~~
MOGL_GenerateurParticule.h:55:20: note: remove parentheses
   55 |     MOGL_Particule (*(* _TabParticule));
      |                    ^~~~~~~~~~~~~~~~~~~~
      |                    -                  -
MOGL_GenerateurParticule.h:55:22: warning: unnecessary parentheses in declaration of ‘_TabParticule’ [-Wparentheses]
   55 |     MOGL_Particule (*(* _TabParticule));
      |                      ^~~~~~~~~~~~~~~~~
MOGL_GenerateurParticule.h:55:22: note: remove parentheses
   55 |     MOGL_Particule (*(* _TabParticule));
      |                      ^~~~~~~~~~~~~~~~~
      |                      -               -
In file included from MOGL_GenPartFume.h:27,
                 from MOGL_GenPartFume.cpp:22:
MOGL_GenerateurParticule.h:55:20: warning: unnecessary parentheses in declaration of ‘_TabParticule’ [-Wparentheses]
   55 |     MOGL_Particule (*(* _TabParticule));
      |                    ^~~~~~~~~~~~~~~~~~~~
MOGL_GenerateurParticule.h:55:20: note: remove parentheses
   55 |     MOGL_Particule (*(* _TabParticule));
      |                    ^~~~~~~~~~~~~~~~~~~~
      |                    -                  -
MOGL_GenerateurParticule.h:55:22: warning: unnecessary parentheses in declaration of ‘_TabParticule’ [-Wparentheses]
   55 |     MOGL_Particule (*(* _TabParticule));
      |                      ^~~~~~~~~~~~~~~~~
MOGL_GenerateurParticule.h:55:22: note: remove parentheses
   55 |     MOGL_Particule (*(* _TabParticule));
      |                      ^~~~~~~~~~~~~~~~~
      |                      -               -
make[4]: Leaving directory '/build/reproducible-path/briquolo-0.5.7/src/MOGL'
make[3]: *** [Makefile:509: all-recursive] Error 1
make[3]: Leaving directory '/build/reproducible-path/briquolo-0.5.7/src'
make[2]: *** [Makefile:291: all-recursive] Error 1
make[2]: Leaving directory '/build/reproducible-path/briquolo-0.5.7'
make[1]: *** [Makefile:227: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/briquolo-0.5.7'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:7: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

#1096393#14
Date:
2025-10-04 21:54:04 UTC
From:
To:
tags 1096393 + patch
user debian-release@lists.debian.org
usertag 1096393 + bsp-2025-10-brazil
thanks

Hi!

The build fails because of the lack of the const keyword in the
MOGL_Fenetre::CompareResolution function call operator. Please find the
patch in the Merge Request I created [1].

I tested locally and this is enough to make it successfully build from
source once again.

Upstream hasn't released a new version since 2010. Thus, I didn't
forward the fix to them.

[1] https://salsa.debian.org/games-team/briquolo/-/merge_requests/1

#1096393#19
Date:
2025-10-05 02:33:31 UTC
From:
To:
Hello,

Bug #1096393 in briquolo reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/games-team/briquolo/-/commit/d6ba8f4184d6c2c662be559d1527b615eef8ee33
------------------------------------------------------------------------
Fix FTBFS with GCC 15

The MOGL_Fenetre::CompareResolution custom comparator is not declared as
const, which makes the compiler not find the required function call
operator. Fix that so it can build with GCC 15.

Closes: #1096393
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1096393

#1096393#26
Date:
2025-10-05 11:34:04 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
briquolo, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1096393@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Henrique F. Simoes <henriquesimoes@riseup.net> (supplier of updated briquolo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 05 Oct 2025 13:03:23 +0200
Source: briquolo
Architecture: source
Version: 0.5.7-12
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Henrique F. Simoes <henriquesimoes@riseup.net>
Closes: 1096393
Changes:
 briquolo (0.5.7-12) unstable; urgency=medium
 .
   * Team Upload
   * Fix FTBFS with GCC 15 (Closes: #1096393)
Checksums-Sha1:
 6ec67cdf2edf010b586600f7ea5983bc6bc3ff65 2030 briquolo_0.5.7-12.dsc
 bf40d99957c1c3c662fb30deee177cf432152a73 9332 briquolo_0.5.7-12.debian.tar.xz
 eaf87ba54f776628e51cb96893bef9a089dfdb49 11905 briquolo_0.5.7-12_source.buildinfo
Checksums-Sha256:
 e7fe4cf0b18553da056b460b11fe2e2d21785920aab1c054447cebd8a44885e2 2030 briquolo_0.5.7-12.dsc
 892c445fe19990fe91c9c226db3ccce5094d398922bcc32a041f423cd4945fc9 9332 briquolo_0.5.7-12.debian.tar.xz
 a274f59be0ae8e1c1271fc100592dfcbc056c022bff001783bb7c607bd8c763a 11905 briquolo_0.5.7-12_source.buildinfo
Files:
 bd2b5498c052eb6b99440a8a05f9d9d9 2030 games optional briquolo_0.5.7-12.dsc
 9ce37dae349806bbb24d69a42d50e447 9332 games optional briquolo_0.5.7-12.debian.tar.xz
 395fbf5f7505115b5493bb4dae691369 11905 games optional briquolo_0.5.7-12_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmjiUR8ACgkQMfMURUSh
dBq6dhAAt6OA7DzrWWJooayCMjly9VHylO/7dehQmW1iAnRqK/OxLcKdC8NOI1p9
3ZOhEsQMOdpoms35/2YHOH6PxqGr6aBkeZQOuHO8URuH3Y6mG3OUGPqSyOrUmKYL
azcg3t+W1Vge1x5RCo5oLioTBNpgax+oNBo9Gt6bwYUXU0J1XY6E7HbAL1lhifsU
dtz0aXjKIDhAgJ7tr9HF9RQVPvnkW2aa1QikhHQgWiaGXUSWTVOy+dQlfVCZJLC3
+R3DmEuah32wcqBPVQVC6Di7pGp84TVylAH2gQL952RaB3VQ9YnRVwKbAF2YrKW0
JqdHUz6TTUVm3aPJl+1JpnTPAHHdMSseiX4Kad3RprED8P0bfcn8a4PRim/VkVZX
qor4sUX+bLCGR5RtmTuVQWfaOyP1NwiqnS/xcSI/hrP5+NXZIUbTQ7VcvboLb8ht
VuoHVnp0WgS1MSsf3bKaXyjDpLJRO3qtwCb6yVpXffZMR4AXTEForzmW3rwU/9w+
ClAQY5MyxAFxU+YwUbsO6vELa0en7mRfKGGuD/VMhLapd4EZ8+W/xkXqQK56V658
N+SGAs0dLqo9Qm4OZgVQ//mbpZxR805pqgcEribbLMWkaEHDIpiF/lvOtP7+b4rL
x+3WVrXq4JSxlzw81BmS5Ao2MOhZu3vuxDzrKE+TZXXaBxDih5w=
=kBCy
-----END PGP SIGNATURE-----