#1097243 libpam-ssh: ftbfs with GCC-15

#1097243#5
Date:
2025-02-17 17:32:57 UTC
From:
To:
[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/libpam-ssh_2.3+ds-8_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
 3510 |                     EC_KEY_get0_public_key(prv->ecdsa)) != 0 ||
      |                     ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/ec.h:1081:39: note: declared here
 1081 | OSSL_DEPRECATEDIN_3_0 const EC_POINT *EC_KEY_get0_public_key(const EC_KEY *key);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
In file included from pam_get_pass.c:39:
pam_option.h:50:21: error: 'bool' cannot be used here
   50 |                 int bool;
      |                     ^~~~
pam_option.h:50:21: note: 'bool' is a keyword with '-std=c23' onwards
pam_option.h:50:25: warning: declaration does not declare anything
   50 |                 int bool;
      |                         ^
In file included from pam_std_option.c:37:
pam_option.h:50:21: error: 'bool' cannot be used here
   50 |                 int bool;
      |                     ^~~~
pam_option.h:50:21: note: 'bool' is a keyword with '-std=c23' onwards
pam_option.h:50:25: warning: declaration does not declare anything
   50 |                 int bool;
      |                         ^
pam_std_option.c: In function 'pam_std_option':
pam_std_option.c:84:33: error: expected identifier before 'bool'
   84 |                 options->opt[i].bool = 0;
      |                                 ^~~~
make[2]: *** [Makefile:673: pam_get_pass.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
pam_std_option.c:98:49: error: expected identifier before 'bool'
   98 |                                 options->opt[i].bool = 1;
      |                                                 ^~~~
pam_std_option.c:104:49: error: expected identifier before 'bool'
  104 |                                 options->opt[i].bool = 1;
      |                                                 ^~~~
pam_std_option.c: In function 'pam_test_option':
pam_std_option.c:122:37: error: expected identifier before 'bool'
  122 |         return options->opt[option].bool;
      |                                     ^~~~
pam_std_option.c:123:1: warning: control reaches end of non-void function [-Wreturn-type]
  123 | }
      | ^
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/usr/include/security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wno-attributes -Wno-unused-result -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/libpam-ssh-2.3+ds=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c openpam_borrow_cred.c  -fPIC -DPIC -o .libs/openpam_borrow_cred.o
make[2]: *** [Makefile:673: pam_std_option.lo] Error 1
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/usr/include/security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wno-attributes -Wno-unused-result -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/libpam-ssh-2.3+ds=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c openpam_restore_cred.c  -fPIC -DPIC -o .libs/openpam_restore_cred.o
In file included from pam_ssh.c:105:
pam_option.h:50:21: error: 'bool' cannot be used here
   50 |                 int bool;
      |                     ^~~~
pam_option.h:50:21: note: 'bool' is a keyword with '-std=c23' onwards
pam_option.h:50:25: warning: declaration does not declare anything
   50 |                 int bool;
      |                         ^
make[2]: *** [Makefile:974: pam_ssh_la-pam_ssh.lo] Error 1
In function 'cert_parse',
    inlined from 'sshkey_from_blob_internal' at sshkey.c:2043:12:
sshkey.c:1806:47: warning: pointer 'oprincipals' may be used after 'realloc' [-Wuse-after-free]
 1806 |                         key->cert->principals = oprincipals;
      |                         ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
sshkey.c:1801:41: note: call to 'realloc' here
 1801 |                 key->cert->principals = realloc(key->cert->principals,
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1802 |                     (key->cert->nprincipals + 1) *
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1803 |                     sizeof(*key->cert->principals));
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: Leaving directory '/build/reproducible-path/libpam-ssh-2.3+ds'
make[1]: *** [Makefile:501: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/libpam-ssh-2.3+ds'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:11: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2