[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/popa3d_1.0.3-1.1_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying debian-defaults-for-params-h.patch

Check disk space
----------------

Sufficient free space for build

User Environment
----------------

APT_CONFIG=/var/lib/sbuild/apt.conf
HOME=/sbuild-nonexistent
LANG=C.UTF-8
LC_ALL=C.UTF-8
LOGNAME=user42
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
SHELL=/bin/sh
USER=user42

dpkg-buildpackage
-----------------

Command: dpkg-buildpackage --sanitize-env -us -uc -b
dpkg-buildpackage: info: source package popa3d
dpkg-buildpackage: info: source version 1.0.3-1.1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Adrian Bunk <bunk@debian.org>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 debian/rules clean
dh clean
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_auto_clean
dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1 clean
make[1]: Entering directory '/build/reproducible-path/popa3d-1.0.3'
rm -f popa3d version.o startup.o standalone.o virtual.o auth_passwd.o auth_shadow.o auth_pam.o pop_root.o pop_auth.o pop_trans.o protocol.o database.o mailbox.o misc.o md5/md5.o
make[1]: Leaving directory '/build/reproducible-path/popa3d-1.0.3'
   dh_clean
dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
 debian/rules binary
dh binary
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_update_autotools_config
   dh_auto_configure
dh_auto_configure: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   debian/rules override_dh_auto_build
make[1]: Entering directory '/build/reproducible-path/popa3d-1.0.3'
dh_auto_build -- LDFLAGS="-Wl,-z,relro" LIBS="-lpam" PREFIX=/usr MANDIR=/usr/share/man CFLAGS="-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/popa3d-1.0.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection"
dh_auto_build: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1 LDFLAGS=-Wl,-z,relro LIBS=-lpam PREFIX=/usr MANDIR=/usr/share/man "CFLAGS=-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/popa3d-1.0.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection"
make[2]: Entering directory '/build/reproducible-path/popa3d-1.0.3'
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/popa3d-1.0.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c version.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/popa3d-1.0.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c startup.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/popa3d-1.0.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c standalone.c
standalone.c: In function ‘do_standalone’:
standalone.c:111:13: error: expected identifier or ‘(’ before ‘true’
  111 |         int true = 1;
      |             ^~~~
standalone.c:126:21: error: lvalue required as unary ‘&’ operand
  126 |             (void *)&true, sizeof(true)))
      |                     ^
make[2]: *** [Makefile:66: standalone.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/popa3d-1.0.3'
dh_auto_build: error: make -j1 LDFLAGS=-Wl,-z,relro LIBS=-lpam PREFIX=/usr MANDIR=/usr/share/man "CFLAGS=-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/popa3d-1.0.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection" returned exit code 2
make[1]: *** [debian/rules:7: override_dh_auto_build] Error 255
make[1]: Leaving directory '/build/reproducible-path/popa3d-1.0.3'
make: *** [debian/rules:14: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Hi Andreas,

I see you have created a patch [1] for this issue as part of the
salvaging effort for popa3d.

Seeing that the upstream is responsive to engagement on their source
repo [2], I thought it would be worth sending them this patch. However, I
notice that it is licensed differently [3] from the upstream project.

Would you consider relicensing your patch with 'other' to make this
easier, please? (And/or perhaps raise the PR directly yourself?)

I wonder if it might be a good idea, to prevent this happening again,
changing debian/* to something more appropriate and then carving out an
exception for the one patch by the previous maintainer?

[1] https://salsa.debian.org/salvage-team/popa3d/-/commit/d6ba78f6e40106337c429c845c426ce69dea5977

[2] https://github.com/openwall/popa3d

[3] https://salsa.debian.org/salvage-team/popa3d/-/blob/master/debian/copyright?ref_type=heads#L7-L13

Thanks,

Andrew

Sorry, I meant to suggest changing debian/patches/*

We believe that the bug you reported is fixed in the latest version of
popa3d, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1097636@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Emmanuel Arias <eamanu@debian.org> (supplier of updated popa3d package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 24 Aug 2025 22:41:58 +0100
Source: popa3d
Architecture: source
Version: 1.0.3-2
Distribution: unstable
Urgency: medium
Maintainer: Package Salvaging Team <team+salvage@tracker.debian.org>
Changed-By: Emmanuel Arias <eamanu@debian.org>
Closes: 1039320 1040606 1097636
Changes:
 popa3d (1.0.3-2) unstable; urgency=medium
 .
   [ Emmanuel Arias ]
   * Packaging update
   * Standards-Version: 4.7.2 (routine-update)
   * debhelper-compat 13 (routine-update)
   * Remove trailing whitespace in debian/copyright (routine-update)
   * Remove trailing whitespace in debian/rules (routine-update)
   * watch file standard 4 (routine-update)
   * d/control: Update VCS-* links.
   * Ship systemd unit instead of sysv-init script (Closes: #1039320).
     - Add popa3d.service and popa3d.socket files.
     - Modify postinst script.
   * d/control: Add myself as Uploaders.
   * d/control: Set Krzysztof Krzyżaniak as Uploaders. Set Salvaging
     Team as Maintainer.
 .
   [ Andreas Tille ]
   * Use something else than the reserved word true as variable name
     Closes: #1097636
   * Use default-mta in Recommends
   * Lintian-overrides for national-encoding
   * Secure URI in watch file
 .
   [ Andrew Bower ]
   * d/patches:
     - add IPv6 support (Closes: #1040606)
     - add foreground server option
     - mark Debian-specific options patch as not needing forwarding
   * d/rules:
     - Various fixes and redundant content removed
     - Pass through missing hardening options
   * d/copyright:
     - Multiple corrections, updates and normalisations
     - License future patches as per upstream by default
   * d/upstream/metadata: add this, detailing new github repo
   * d/control:
     - add myself to Uploaders
     - update description to help users judge suitability
   * Add a modern standard init-d-script(5)
   * Fix systemd units and drop shadow service control
     - standalone mode continues to be the installation default
     - switch to socket activation (or inetd) using standard tools
     - stop using debconf and /etc/default/popa3d henceforth
     - advise existing inetd users on one-off next steps
     - add Documentation keys
     - Thanks: Alexander Sulfrian, Emmanuel Arias
   * Rewrite README.Debian to be relevant
   * Add all hardening build flags, fixing hardening-no-bindnow
   * d/control: Add myself to Uploaders
   * Use sysusers.d to create system user
   * Use StateDirectory instead of maintscript
Checksums-Sha1:
 25fecc46dbecf74bd5e6d97aa1f8100202ceffc6 2046 popa3d_1.0.3-2.dsc
 0ac49b5c2f524131a2ec942d17651ca12ead7e1f 18912 popa3d_1.0.3-2.debian.tar.xz
 640094649d7baf45c7aed7436c9302971d3536d7 5934 popa3d_1.0.3-2_amd64.buildinfo
Checksums-Sha256:
 02b1b78cb7f018439d40c722f666b89517b7bb6f42c7acd9b8cd1d236ed8da1f 2046 popa3d_1.0.3-2.dsc
 f1928b17ad8514269f4be517fdcb694a62cef13a9ba879fc369711e0b860bbec 18912 popa3d_1.0.3-2.debian.tar.xz
 55f9091a6b5a9d0addf3584cf2ad1729bb81d3bf74ed24025b09c013cbf5a561 5934 popa3d_1.0.3-2_amd64.buildinfo
Files:
 2f33cf48186903130163fc32e968481f 2046 mail optional popa3d_1.0.3-2.dsc
 6971e2a8e0dbe832514beb4fdb4196f6 18912 mail optional popa3d_1.0.3-2.debian.tar.xz
 178360bd6f53a0c7a7b76ff5e1a3b45d 5934 mail optional popa3d_1.0.3-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEEE3lnVbvHK7ir4q61+p3sXeEcY/EFAmirkpASHGVhbWFudUBk
ZWJpYW4ub3JnAAoJEPqd7F3hHGPxBwUP/RDxObNofQabHCitLbUg9DOIqSTSFHe8
EcYszRrYLgu4QDV3fMcEEqo1ghlJJPjO7onH68regUEhF9eHE+imfTgk9txRH1YC
e+u1uPLRh7NA0DHYDb9jZPrdCiDrB97tMi7pnyIlNSilnWxa8u6qjosXq3Sk/irE
ylU0zsU8vTtlXidGkPHz+uehqqYRhZ0wg280LC+rl5PITqCjxTauq48s5KLdcyHx
brXoo1OwA0a7RsJQy5KjRlIYl0d8Jpea0a6k463HLjgR5sE7lvlUoL8XRpi79+7o
keP9xDIbnJhI5/D4BhA76tfP1yPw+5kWdF47YFHsQHaP6JZhR5ZvmhucK+YHs35I
F+zVYxihRpgiNZL+yo3ogim5p6wwgYe3jFwrbKyY2YtAr4Vxyz0M4IRPNtu03tg2
PDpOzI5bFqEgDv2+2LNoTV/ii0bxw5/4hcABR0dGi5iUcPKMZYR4HMNvABuxPu26
PJ6SLzauQDeLJpLKcee9SGOuCObiwMXJSFPCHUSHTAzy0kxfBqbJdQQYPNDEWmDS
woYDw8/4Q1jDvWLrEfxt/Jhb3ytFc1pzfcR5G+h/wHxyuhr8BpCPk0GDzypSzf5R
MyG2EXC9CQkU2FSqzbfwMA5pKnEeROkJmog28VeZDwDKk7Mdpur0KiRw1uqLyiz+
8zSoFLMpgiAq
=BVY0
-----END PGP SIGNATURE-----

Hi Andrew,

Am Wed, Aug 20, 2025 at 02:56:05AM +0100 schrieb Andrew Bower:

Please be so kind to take this work from me.  My patch can be considered
public domain or any other license you want.

I'm swamped with other issues.  If you create a MR with what you have in
mind please file it and ping me about this.  I'm happe if you become
involved and care for this.  This is explicitly encouraged that others
take over such tasks.

Thanks a lot
   Andreas.