#1097874 shairport-sync: ftbfs with GCC-15

#1097874#5
Date:
2025-02-17 17:53:13 UTC
From:
To:
[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/shairport-sync_3.3.8-1_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
/usr/include/openssl/pem.h:452:1: note: declared here
  452 | DECLARE_PEM_rw_cb_attr(OSSL_DEPRECATEDIN_3_0, RSAPrivateKey, RSA)
      | ^~~~~~~~~~~~~~~~~~~~~~
common.c:658:3: warning: ‘RSA_size’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
  658 |   uint8_t *out = malloc(RSA_size(rsa));
      |   ^~~~~~~
In file included from /usr/include/openssl/x509.h:36,
                 from /usr/include/openssl/pem.h:23:
/usr/include/openssl/rsa.h:215:27: note: declared here
  215 | OSSL_DEPRECATEDIN_3_0 int RSA_size(const RSA *rsa);
      |                           ^~~~~~~~
common.c:661:5: warning: ‘RSA_private_encrypt’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
  661 |     *outlen = RSA_private_encrypt(inlen, input, out, rsa, RSA_PKCS1_PADDING);
      |     ^
/usr/include/openssl/rsa.h:296:5: note: declared here
  296 | int RSA_private_encrypt(int flen, const unsigned char *from, unsigned char *to,
      |     ^~~~~~~~~~~~~~~~~~~
common.c:664:5: warning: ‘RSA_private_decrypt’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
  664 |     *outlen = RSA_private_decrypt(inlen, input, out, rsa, RSA_PKCS1_OAEP_PADDING);
      |     ^
/usr/include/openssl/rsa.h:302:5: note: declared here
  302 | int RSA_private_decrypt(int flen, const unsigned char *from, unsigned char *to,
      |     ^~~~~~~~~~~~~~~~~~~
common.c:669:3: warning: ‘RSA_free’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
  669 |   RSA_free(rsa);
      |   ^~~~~~~~
/usr/include/openssl/rsa.h:304:28: note: declared here
  304 | OSSL_DEPRECATEDIN_3_0 void RSA_free(RSA *r);
      |                            ^~~~~~~~
gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -fno-common -Wno-multichar -Wall -Wextra -Wno-clobbered -Wno-psabi -pthread -DSYSCONFDIR=\"/etc\" -DPIDDIR=\"/run/shairport-sync\" -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libmount -I/usr/include/blkid -pthread   -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/shairport-sync-3.3.8=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o loudness.o loudness.c
gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -fno-common -Wno-multichar -Wall -Wextra -Wno-clobbered -Wno-psabi -pthread -DSYSCONFDIR=\"/etc\" -DPIDDIR=\"/run/shairport-sync\" -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libmount -I/usr/include/blkid -pthread   -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/shairport-sync-3.3.8=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o activity_monitor.o activity_monitor.c
shairport.c: In function ‘exit_function’:
shairport.c:1368:7: error: too many arguments to function ‘activity_monitor_stop’; expected 0, have 1
 1368 |       activity_monitor_stop(0);
      |       ^~~~~~~~~~~~~~~~~~~~~ ~
In file included from shairport.c:63:
activity_monitor.h:6:6: note: declared here
    6 | void activity_monitor_stop();
      |      ^~~~~~~~~~~~~~~~~~~~~
shairport.c: In function ‘main’:
shairport.c:1928:3: warning: ‘MD5_Init’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
 1928 |   MD5_Init(&ctx);
      |   ^~~~~~~~
In file included from shairport.c:56:
/usr/include/openssl/md5.h:49:27: note: declared here
   49 | OSSL_DEPRECATEDIN_3_0 int MD5_Init(MD5_CTX *c);
      |                           ^~~~~~~~
shairport.c:1929:3: warning: ‘MD5_Update’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
 1929 |   MD5_Update(&ctx, config.service_name, strlen(config.service_name));
      |   ^~~~~~~~~~
/usr/include/openssl/md5.h:50:27: note: declared here
   50 | OSSL_DEPRECATEDIN_3_0 int MD5_Update(MD5_CTX *c, const void *data, size_t len);
      |                           ^~~~~~~~~~
gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -fno-common -Wno-multichar -Wall -Wextra -Wno-clobbered -Wno-psabi -pthread -DSYSCONFDIR=\"/etc\" -DPIDDIR=\"/run/shairport-sync\" -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libmount -I/usr/include/blkid -pthread   -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/shairport-sync-3.3.8=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o mdns_avahi.o mdns_avahi.c
shairport.c:1930:3: warning: ‘MD5_Final’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
 1930 |   MD5_Final(ap_md5, &ctx);
      |   ^~~~~~~~~
/usr/include/openssl/md5.h:51:27: note: declared here
   51 | OSSL_DEPRECATEDIN_3_0 int MD5_Final(unsigned char *md, MD5_CTX *c);
      |                           ^~~~~~~~~
make[3]: *** [Makefile:821: shairport.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/build/reproducible-path/shairport-sync-3.3.8'
make[2]: *** [Makefile:882: all-recursive] Error 1
make[2]: Leaving directory '/build/reproducible-path/shairport-sync-3.3.8'
make[1]: *** [Makefile:606: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/shairport-sync-3.3.8'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:19: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2