#1097999 time: ftbfs with GCC-15

Package:
src:time
Source:
src:time
Submitter:
Matthias Klose
Date:
2025-09-04 22:11:16 UTC
Severity:
normal
Tags:
#1097999#5
Date:
2025-02-17 17:57:14 UTC
From:
To:
[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/time_1.9-0.2_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
src/time.c: In function 'getargs':
src/time.c:640:1: warning: old-style function definition [-Wold-style-definition]
  640 | getargs (argc, argv)
      | ^~~~~~~
src/time.c: In function 'run_command':
src/time.c:726:1: warning: old-style function definition [-Wold-style-definition]
  726 | run_command (cmd, resp)
      | ^~~~~~~~~~~
src/time.c:750:20: error: assignment to 'sighandler' {aka 'void (*)(void)'} from incompatible pointer type '__sighandler_t' {aka 'void (*)(int)'} [-Wincompatible-pointer-types]
  750 |   interrupt_signal = signal (SIGINT, SIG_IGN);
      |                    ^
src/time.c:79:22: note: 'sighandler' declared here
   79 | typedef RETSIGTYPE (*sighandler) ();
      |                      ^~~~~~~~~~
In file included from lib/signal.h:52,
                 from /usr/include/x86_64-linux-gnu/sys/wait.h:36,
                 from lib/sys/wait.h:28,
                 from src/time.c:27:
/usr/include/signal.h:72:16: note: '__sighandler_t' declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
src/time.c:751:15: error: assignment to 'sighandler' {aka 'void (*)(void)'} from incompatible pointer type '__sighandler_t' {aka 'void (*)(int)'} [-Wincompatible-pointer-types]
  751 |   quit_signal = signal (SIGQUIT, SIG_IGN);
      |               ^
src/time.c:79:22: note: 'sighandler' declared here
   79 | typedef RETSIGTYPE (*sighandler) ();
      |                      ^~~~~~~~~~
/usr/include/signal.h:72:16: note: '__sighandler_t' declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
src/time.c:757:19: error: passing argument 2 of 'signal' from incompatible pointer type [-Wincompatible-pointer-types]
  757 |   signal (SIGINT, interrupt_signal);
      |                   ^~~~~~~~~~~~~~~~
      |                   |
      |                   sighandler {aka void (*)(void)}
/usr/include/signal.h:88:57: note: expected '__sighandler_t' {aka 'void (*)(int)'} but argument is of type 'sighandler' {aka 'void (*)(void)'}
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
/usr/include/signal.h:72:16: note: '__sighandler_t' declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
src/time.c:79:22: note: 'sighandler' declared here
   79 | typedef RETSIGTYPE (*sighandler) ();
      |                      ^~~~~~~~~~
src/time.c:758:20: error: passing argument 2 of 'signal' from incompatible pointer type [-Wincompatible-pointer-types]
  758 |   signal (SIGQUIT, quit_signal);
      |                    ^~~~~~~~~~~
      |                    |
      |                    sighandler {aka void (*)(void)}
/usr/include/signal.h:88:57: note: expected '__sighandler_t' {aka 'void (*)(int)'} but argument is of type 'sighandler' {aka 'void (*)(void)'}
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
/usr/include/signal.h:72:16: note: '__sighandler_t' declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
src/time.c:79:22: note: 'sighandler' declared here
   79 | typedef RETSIGTYPE (*sighandler) ();
      |                      ^~~~~~~~~~
src/time.c: In function 'main':
src/time.c:762:1: warning: old-style function definition [-Wold-style-definition]
  762 | main (argc, argv)
      | ^~~~
make[2]: *** [Makefile:1910: src/time-time.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/build/reproducible-path/time-1.9'
make[1]: *** [Makefile:1374: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/time-1.9'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:3: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

#1097999#10
Date:
2025-08-06 06:24:31 UTC
From:
To:
Control: tag 1097999 patch

A patch fixing this has been proposed in
<https://lists.gnu.org/archive/html/bug-time/2025-01/msg00000.html>.
Here copied for reference:

| Signed-off-by: Ondřej Pohořelský <opohorel@redhat.com>
| ---
|  src/time.c | 2 +-
|  1 file changed, 1 insertion(+), 1 deletion(-)
|
| diff --git a/src/time.c b/src/time.c
| index 7b401bc..c8d7ab0 100644
| --- a/src/time.c
| +++ b/src/time.c
| @@ -803,7 +803,7 @@ run_command (cmd, resp)
|       RESUSE *resp;
|  {
|    pid_t pid; /* Pid of child.  */
| -  sighandler interrupt_signal, quit_signal;
| +  __sighandler_t interrupt_signal, quit_signal;
|    int saved_errno;
|
|    resuse_start (resp);
| --
| 2.48.1

HTH,
Flo