#1098065 viking: ftbfs with GCC-15

Package:
src:viking
Source:
src:viking
Submitter:
Matthias Klose
Date:
2025-09-28 02:29:05 UTC
Severity:
normal
Tags:
#1098065#5
Date:
2025-02-17 17:59:21 UTC
From:
To:
[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/viking_1.10-4_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
  980 |   GtkWidget *alpha_hbox = gtk_hbox_new ( FALSE, 0 );
      |   ^~~~~~~~~
/usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:63:13: note: declared here
   63 | GtkWidget * gtk_hbox_new      (gboolean homogeneous,
      |             ^~~~~~~~~~~~
vikgeoreflayer.c:982:3: warning: ‘gtk_hscale_new_with_range’ is deprecated: Use 'gtk_scale_new_with_range' instead [-Wdeprecated-declarations]
  982 |   GtkWidget *alpha_scale = gtk_hscale_new_with_range ( 0, 255, 1 );
      |   ^~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:265:
/usr/include/gtk-3.0/gtk/deprecated/gtkhscale.h:63:12: note: declared here
   63 | GtkWidget* gtk_hscale_new_with_range (gdouble        min,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~
vikgeoreflayer.c: In function ‘georef_layer_add_menu_items’:
vikgeoreflayer.c:1086:3: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
 1086 |   (void)vu_menu_add_item ( menu, _("_Zoom to Fit Map"), GTK_STOCK_ZOOM_FIT, G_CALLBACK(georef_layer_zoom_to_fit), pass_along );
      |   ^
vikgeoreflayer.c:1087:3: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
 1087 |   (void)vu_menu_add_item ( menu, _("_Goto Map Center"), GTK_STOCK_JUMP_TO, G_CALLBACK(georef_layer_goto_center), pass_along );
      |   ^
vikgeoreflayer.c:1088:3: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
 1088 |   (void)vu_menu_add_item ( menu, _("_Export to World File"), GTK_STOCK_HARDDISK, G_CALLBACK(georef_layer_export_params), pass_along );
      |   ^
In function ‘vik_viewport_rightmost_zone’,
    inlined from ‘vik_viewport_rightmost_zone’ at vikviewport.c:1396:7,
    inlined from ‘viewport_utm_zone_check.part.0’ at vikviewport.c:1119:27:
vikviewport.c:1402:17: warning: ‘coord.utm_zone’ may be used uninitialized [-Wmaybe-uninitialized]
 1402 |     return coord.utm_zone;
      |            ~~~~~^~~~~~~~~
vikviewport.c: In function ‘viewport_utm_zone_check.part.0’:
vikviewport.c:1399:14: note: ‘coord’ declared here
 1399 |     VikCoord coord;
      |              ^~~~~
In function ‘vik_viewport_leftmost_zone’,
    inlined from ‘vik_viewport_leftmost_zone’ at vikviewport.c:1385:7,
    inlined from ‘viewport_utm_zone_check.part.0’ at vikviewport.c:1119:63:
vikviewport.c:1391:17: warning: ‘coord.utm_zone’ may be used uninitialized [-Wmaybe-uninitialized]
 1391 |     return coord.utm_zone;
      |            ~~~~~^~~~~~~~~
vikviewport.c: In function ‘viewport_utm_zone_check.part.0’:
vikviewport.c:1388:14: note: ‘coord’ declared here
 1388 |     VikCoord coord;
      |              ^~~~~
In function ‘vik_viewport_leftmost_zone’,
    inlined from ‘vik_viewport_leftmost_zone’ at vikviewport.c:1385:7:
vikviewport.c:1391:17: warning: ‘coord.utm_zone’ may be used uninitialized [-Wmaybe-uninitialized]
 1391 |     return coord.utm_zone;
      |            ~~~~~^~~~~~~~~
vikviewport.c: In function ‘vik_viewport_leftmost_zone’:
vikviewport.c:1388:14: note: ‘coord’ declared here
 1388 |     VikCoord coord;
      |              ^~~~~
In function ‘vik_viewport_rightmost_zone’,
    inlined from ‘vik_viewport_rightmost_zone’ at vikviewport.c:1396:7:
vikviewport.c:1402:17: warning: ‘coord.utm_zone’ may be used uninitialized [-Wmaybe-uninitialized]
 1402 |     return coord.utm_zone;
      |            ~~~~~^~~~~~~~~
vikviewport.c: In function ‘vik_viewport_rightmost_zone’:
vikviewport.c:1399:14: note: ‘coord’ declared here
 1399 |     VikCoord coord;
      |              ^~~~~
make[4]: Leaving directory '/build/reproducible-path/viking-1.10/src'
make[3]: *** [Makefile:1142: all-recursive] Error 1
make[3]: Leaving directory '/build/reproducible-path/viking-1.10/src'
make[2]: *** [Makefile:805: all] Error 2
make[2]: Leaving directory '/build/reproducible-path/viking-1.10/src'
make[1]: *** [Makefile:517: all-recursive] Error 1
make[1]: Leaving directory '/build/reproducible-path/viking-1.10'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:5: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

#1098065#14
Date:
2025-09-28 02:26:32 UTC
From:
To:
Control: tags -1 upstream fixed-upstream

vikaggregatelayer.c: In function ‘vik_aggregate_layer_create’:
vikaggregatelayer.c:631:27: error: too many arguments to function ‘vik_aggregate_layer_new’; expected 0, have 1
  631 |   VikAggregateLayer *rv = vik_aggregate_layer_new (vp);
      |                           ^~~~~~~~~~~~~~~~~~~~~~~  ~~
In file included from viking.h:57:
vikaggregatelayer.h:48:20: note: declared here
   48 | VikAggregateLayer *vik_aggregate_layer_new ();
      |                    ^~~~~~~~~~~~~~~~~~~~~~~
vikaggregatelayer.c: In function ‘aggregate_layer_unmarshall’:
vikaggregatelayer.c:680:27: error: too many arguments to function ‘vik_aggregate_layer_new’; expected 0, have 1
  680 |   VikAggregateLayer *rv = vik_aggregate_layer_new(vvp);
      |                           ^~~~~~~~~~~~~~~~~~~~~~~ ~~~
vikaggregatelayer.h:48:20: note: declared here
   48 | VikAggregateLayer *vik_aggregate_layer_new ();
      |                    ^~~~~~~~~~~~~~~~~~~~~~~
vikaggregatelayer.c: At top level:
vikaggregatelayer.c:700:20: error: conflicting types for ‘vik_aggregate_layer_new’; have ‘VikAggregateLayer *(VikViewport *)’ {aka ‘struct _VikAggregateLayer *(struct _VikViewport *)’}
  700 | VikAggregateLayer *vik_aggregate_layer_new (VikViewport *vvp)
      |                    ^~~~~~~~~~~~~~~~~~~~~~~

this was fixed in January by

https://github.com/viking-gps/viking/commit/d447c19b6a2fe499fd60aa8969ea91c5cbfda159