#1099767 RFS: python-certbot-dns-luadns/2.9.0-1 [ITP] -- LuaDNS Authenticator plugin for Certbot #1099767
- Package:
- sponsorship-requests
- Source:
- sponsorship-requests
- Submitter:
- Date:
- 2025-08-09 18:55:05 UTC
- Severity:
- normal
- Tags:
Dear mentors, I am looking for a sponsor for my package "python-certbot-dns-luadns": * Package name : python-certbot-dns-luadns Version : 2.9.0-1 Upstream contact : Certbot Project <certbot-dev@eff.org> * URL : https://certbot.eff.org/ * License : Apache-2.0 * Vcs : https://salsa.debian.org/chancellor/certbot-dns-luadns Section : python The source builds the following binary packages: python3-certbot-dns-luadns - LuaDNS Authenticator plugin for Certbot python-certbot-dns-luadns-doc - Documentation for the LuaDNS Authenticator plugin for Certbot To access further information about this package, please visit the following URL: https://mentors.debian.net/package/python-certbot-dns-luadns/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/p/python-certbot-dns-luadns/python-certbot-dns-luadns_2.9.0-1.dsc Changes for the initial release: python-certbot-dns-luadns (2.9.0-1) unstable; urgency=medium . * Initial release. (Closes: #1099684) Regards, -- Chris Chancellor
Chris, Review of upload: 2025-03-07 20:56 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Test 6 (debian/watch): Information only Latest version is: 2.10.0. Summary ======= Chris, Would you consider updating to the latest upstream prior to full review?
Chris, Review of upload: 2025-03-07 20:56 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Test 6 (debian/watch): Information only Latest version is: 2.10.0. Summary ======= Chris, Would you consider updating to the latest upstream prior to full review?
Hello Phil, I appreciate you taking a look! I've updated to version 2.11.0 which is the highest that the sid release of certbot supports. Truth be told, there isn't a code difference between the two versions for this particular package (versioning mirrors the certbot release), but it's much cleaner this way, you're right. Please let me know if I need to take a look at anything else! Sincerely, Chris Chancellor Mar 9, 2025, 6:45 AM by philip.wyett@kathenas.org:
Hello Phil, I appreciate you taking a look! I've updated to version 2.11.0 which is the highest that the sid release of certbot supports. Truth be told, there isn't a code difference between the two versions for this particular package (versioning mirrors the certbot release), but it's much cleaner this way, you're right. Please let me know if I need to take a look at anything else! Sincerely, Chris Chancellor Mar 9, 2025, 6:45 AM by philip.wyett@kathenas.org:
Hello Phil, I appreciate you taking a look! I've updated to version 2.11.0 which is the highest that the sid release of certbot supports. Truth be told, there isn't a code difference between the two versions for this particular package (versioning mirrors the certbot release), but it's much cleaner this way, you're right. Please let me know if I need to take a look at anything else! Sincerely, Chris Chancellor Mar 9, 2025, 6:45 AM by philip.wyett@kathenas.org:
Control: tags -1 -moreinfo Control: tags -1 +confirmed Hi Chris, Many thanks for the update and the information you provided. I have performed my tests on the package and it looks in good shape. I will tag as 'confirmed' and hope a DD can look at the package, review it and posssibly upload for you.
Control: tags -1 -moreinfo Control: tags -1 +confirmed Hi Chris, Many thanks for the update and the information you provided. I have performed my tests on the package and it looks in good shape. I will tag as 'confirmed' and hope a DD can look at the package, review it and posssibly upload for you.
Control: tags -1 -moreinfo Control: tags -1 +confirmed Hi Chris, Many thanks for the update and the information you provided. I have performed my tests on the package and it looks in good shape. I will tag as 'confirmed' and hope a DD can look at the package, review it and posssibly upload for you.
Control: tags -1 moreinfo
hi Chris,
the package is in decent shape overall, but does need a few fixes
before I can upload:
* watch: the signature file appears unavailable via pypi.debian.net.
While checking the signature is a good idea, with verification
broken by the missing asc file 'uscan' errors out when trying to
download upstream releases: "failed: 404 NOT FOUND uscan die: FAIL
Checking OpenPGP signature (no signature file downloaded)".
You might want to point the watch file to whatever repository you
actually downloaded the tarball and signature from (github?).
* control:
+ the ancient version requirement for the build-dependency on
python3-sphinx is already met in oldstable, please remove.
+ the package should build-depend on python3-all rather than
python3, so that the testsuite can be run on build with all
supported Python versions.
+ the letsencrypt team is set as maintainer but the package isn't
actually in the team repo. This would cause the team to receive
bug reports and such for a package not under their control.
Probably best to switch the maintainer and uploader roles around
for now, even if you plan on eventually making this a team pkg.
+ binary package python3-certbot-dns-luadns would benefit from a
suggested dependency on the -doc package.
+ the versioning of the *-abi-2 build-dependencies seems to have
been overlooked when moving from 2.9.0 to 2.11.0?
* rules: you could use execute_after_dh_auto_build in place of the
override.
The build tries to pull in intersphinx inventory from the internet.
Instead of blocking that and letting sphinx continue without these
resources, the intersphinx_mapping in docs/conf.py could be patched
to point to local files (see [2] for numerous examples):
'https://acme-python.readthedocs.org/en/latest/objects.inv' -> /usr/share/doc/python-acme-doc/html/objects.inv (in python-acme-doc)
'https://docs.python.org/objects.inv' -> /usr/share/doc/python3/html/objects.inv (via python3-doc)
'https://eff-certbot.readthedocs.io/en/stable/objects.inv' -> /usr/share/doc/python3-certbot/html/objects.inv (in python-certbot-doc)
Obviously, this approach would also require adding the relevant
documentation packages as build-dependencies.
Consider enabling the CI on the salsa repo [1], it's a great time
saver and quality control tool.
[1]https://salsa.debian.org/salsa-ci-team/pipeline#activate-salsa-ci
[2]https://codesearch.debian.net/search?q=objects.inv+path%3Adebian%2Fpatches&literal=1
Please remove the moreinfo tag (and CC me) once you have an updated
package ready.