- Package:
- sponsorship-requests
- Source:
- sponsorship-requests
- Submitter:
- Kirill Rekhov
- Date:
- 2025-09-03 23:03:03 UTC
- Severity:
- normal
- Tags:
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "devilutionx": * Package name: devilutionx Version: 1.5.4+ds2-1 Upstream contact: https://github.com/diasurgical * URL: https://github.com/diasurgical/DevilutionX * License: GPL-3+, BSD-2-clause, GPL-2, BSD-1-Clause, LGPL-2.1+, SustainableUse, Expat, LGPL-2.1, Apache-1.0, LGPL, BSD-3-clause, CC-BY-SA-4.0, Zlib, BSL-1.0, MS-PL, LGPL-3+, Apache-2.0, GPL-2+ * Vcs: https://salsa.debian.org/krekhov/Devilutionx Section: games The source builds the following binary packages: devilutionx - diablo build for modern operating systems devilutionx-data - architecture-independent data files for DevilutionX To access further information about this package, please visit the following URL: https://mentors.debian.net/package/devilutionx/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/d/devilutionx/devilutionx_1.5.4+ds2-1.dsc Changes for the initial release: devilutionx (1.5.4+ds2-1) unstable; urgency=medium . * Initial release (Closes: #1088174) Regards,
Kirill, Review of upload: 2025-05-08 23:42 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Summary ======= Looks good here. Tagging as 'confirmed' and I hope a DD will find the time soon to review and possibly sponsor the package.
Kirill, Review of upload: 2025-05-08 23:42 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Summary ======= Looks good here. Tagging as 'confirmed' and I hope a DD will find the time soon to review and possibly sponsor the package.
I’m forwarding this request for sponsorship to the Games Team mailing list, as this new package is the kind of thing that is an obvious fit for our team. DevilutionX is a native engine for the original Diablo game, that is already supported by ./play.it. As it is not in Debian repositories yet, we currently build a local package from the upstream binaries, but we could stop doing that as soon as DevilutionX reaches the archive. In addition, having it in the archive would add Diablo to the list of games that game-data-packager could easily support. Warning: before it is actually uploaded, the section must be fixed. The SustainableUse license includes a non-commercial clause, so this package should enter non-free, not main: https://salsa.debian.org/krekhov/devilutionx/-/blob/debian/latest/LICENSE.md#limitations Maybe it needs some fixes to the debian/copyright file too, as it currently wrongly identifies this license as "free software" while it is actually not DFSG-compliant: https://salsa.debian.org/krekhov/devilutionx/-/blob/debian/latest/debian/copyright#L6218 I would gladly sponsor it myself, but I am not a DD yet ;) I plan to come back from DebConf25 with a brand new DD hat, so if this package is still pending then I would assume sponsorship for it. But I hope it is going to reach the Debian archive before that. The original sponsorship request follows:
Hi, Antoine. list, as Thank you! already This is good news! games Fact! package I hope everything works out, good luck to you! and I will try to become a DM this year =) regarding debian/copyright I accepted your comment, I will take it into account and correct it in the future.--- Regards, Kirill Rekhov GPG Fingerprint: 2640 769D FDA1 AAA0 F863 D1AE 5F2C 5905 519C E0A0 ср, 4 июн. 2025 г. в 19:42, Antoine Le Gonidec <debian@vv221.fr>:
Kirill, Review of upload: 2025-06-20 10:57 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Summary ======= Latest upload looks in good shape. Leaving tag as 'confirmed'.
Kirill, Review of upload: 2025-06-20 10:57 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Summary ======= Latest upload looks in good shape. Leaving tag as 'confirmed'.
Are you still looking for a sponsor for DevilutionX? I’m going to have some time starting tomorrow to review your package, and upload it if it’s in a good state. If you’re OK with us working together on the packaging of this engine, I would be happy to be your sponsor for this first upload, as well as any future upload for DevilutionX.
Hi, Antoine Sorry for the late reply, yes if you want you can view/upload this package. It is ready at the addresses: https://salsa.debian.org/krekhov/devilutionx https://mentors.debian.net/package/devilutionx https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1104851 -- Regards, Kirill Rekhov Currently Debian Maintainer GPG Fingerprint: 2640 769D FDA1 AAA0 F863 D1AE 5F2C 5905 519C E0A0 Debian Salsa: https://salsa.debian.org/krekhov Debian Person: https://nm.debian.org/person/krekhov Debian QA Page: https://qa.debian.org/developer.php?login=krekhov.dev@gmail.com GitHub: https://github.com/krekhovx сб, 26 июл. 2025 г. в 10:32, Antoine Le Gonidec <debian@vv221.fr>:
Le Sat, Aug 23, 2025 at 12:28:40PM +0300, Kirill Rekhov a écrit : Section: games should be replaced with: Section: non-free/games I think the short version of the SustainableUse license in debian/copyright should be updated in some way too. Right now we have to go to the upstream-provided LICENSE.md and notice these sentences to know this is actually not a DFSG-compatible license: You may use or modify the software only for your own internal business purposes or for non-commercial or personal use. You may distribute the software or provide it to others only if you do so free of charge for non-commercial purposes. That makes the opening of the following sentence in the SustainableUse license summary in debian/copyright wrong: This package is free software; (…) And to conclude with that license, debian/copyright should include a Disclaimer field explaining why this package is not part of Debian proper (here because of the restriction to commercial us): https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#disclaimer-field --- About lintian overrides, the following is not a false positive: old-fsf-address-in-copyright-file Said address is included in the summary of the GPL-2 license in debian/copyright, that should probably be fixed. You can probably used a slightly tweaked version of the text you included for GPL-2+. The following override is probably not warranted either, as it is not a false-positive: package-contains-documentation-outside-usr-share-doc You can fix that one by removing the following entry from debian/devilutionx-data.install: usr/share/diasurgical/devilutionx/README.txt and instead include it in a new file debian/devilutionx-data.docs--- In debian/copyright, you have many similar single-file entries like this example: Files: dist/asio-src/asio/include/asio/as_tuple.hpp Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com) License: BSL-1.0 Files: dist/asio-src/asio/include/asio/async_result.hpp Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com) License: BSL-1.0 Files: dist/asio-src/asio/include/asio/awaitable.hpp Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com) License: BSL-1.0 This can actually be merged into a single entry, like this: Files: dist/asio-src/asio/include/asio/as_tuple.hpp dist/asio-src/asio/include/asio/async_result.hpp dist/asio-src/asio/include/asio/awaitable.hpp Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com) License: BSL-1.0 Or, even better, if the license applies to all files in that directory (I did not check if this is the case for that example): Files: dist/asio-src/asio/include/asio/* Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com) License: BSL-1.0 More precise entries take priority on more global ones, so you can write something like this too: Files: dist/libzt-src/ext/ZeroTierOne/* Copyright: 2019 ZeroTier, Inc. License: Apache-2.0 Files: dist/libzt-src/ext/ZeroTierOne/ext/bin/tap-windows-ndis6/* Copyright: 2002-2014 OpenVPN Technologies, Inc. * License: GPL-2 Files: dist/libzt-src/ext/ZeroTierOne/ext/hiredis-0.14.1/* Copyright: 2010-2011 Pieter Noordhuis License: BSD-3-clause While it might look like a cosmetic change only, it actually makes the debian/copyright review much easier by strongly reducing its length.--- In debian/control, you set explicit dependencies for devilutionx on libsdl2-2.0-0 and libsdl2-image-2.0-0. This is not required, these are already automatically set from the Build-Depends list above.--- If you want this package to be team-maintained, you should replace the current Maintainer field with: Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org> Uploaders: Kirill Rekhov <krekhov.dev@gmail.com> Updating the Vcs-* fields would be required when the packaging repository is moved into the team namespace. Maybe it’s worth doing it for the initial upload already, and move that repository as soon as we have a bit of time for that? (I asked on IRC for your account to be added to our team) Vcs-Git: https://salsa.debian.org/games-team/devilutionx.git Vcs-Browser: https://salsa.debian.org/games-team/devilutionx--- And that’s all, please send me a ping when you’re done fixing what I reported, and I think this time it sould finally be ready for an initial upload! Take as much time as you need for that, my proposal to sponsor this upload is not time-limited in any way.
Hi, Antoine I’ve made the fixes you pointed out. Could you add me to the games-team so I can create https://salsa.debian.org/games-team/devilutionx and push the new changes? -- Regards, Kirill Rekhov Currently Debian Maintainer GPG Fingerprint: 2640 769D FDA1 AAA0 F863 D1AE 5F2C 5905 519C E0A0 Debian Salsa: https://salsa.debian.org/krekhov Debian Person: https://nm.debian.org/person/krekhov Debian QA Page: https://qa.debian.org/developer.php?login=krekhov.dev@gmail.com GitHub: https://github.com/krekhovx сб, 23 авг. 2025 г. в 16:11, Antoine Le Gonidec <vv221@debian.org>:
Le Thu, Aug 28, 2025 at 03:27:24PM +0300, Kirill Rekhov a écrit : For some reason I can’t do that myself. I already asked on IRC for someone to give you access, and I hope this extra request on the mailing list is going to catch the attention of someone with the required permissions.
Hi, Antoine Ready: https://salsa.debian.org/games-team/devilutionx https://mentors.debian.net/package/devilutionx unfortunately I don't have rights to enable CI/CD in this repository, but the edits are minor and I think CI/CD would be successful. maybe you have rights to enable CI/CD? I wrote in IRC chat - unsuccessfully -- Regards, Kirill Rekhov Currently Debian Maintainer GPG Fingerprint: 2640 769D FDA1 AAA0 F863 D1AE 5F2C 5905 519C E0A0 Debian Salsa: https://salsa.debian.org/krekhov Debian Person: https://nm.debian.org/person/krekhov Debian QA Page: https://qa.debian.org/developer.php?login=krekhov.dev@gmail.com GitHub: https://github.com/krekhovx пт, 29 авг. 2025 г. в 18:10, Antoine Le Gonidec <vv221@debian.org>:
CI/CD - Success: https://salsa.debian.org/games-team/devilutionx/-/pipelines -- Regards, Kirill Rekhov Currently Debian Maintainer GPG Fingerprint: 2640 769D FDA1 AAA0 F863 D1AE 5F2C 5905 519C E0A0 Debian Salsa: https://salsa.debian.org/krekhov Debian Person: https://nm.debian.org/person/krekhov Debian QA Page: https://qa.debian.org/developer.php?login=krekhov.dev@gmail.com GitHub: https://github.com/krekhovx вт, 2 сент. 2025 г. в 21:11, Kirill Rekhov <krekhov.dev@gmail.com>:
Le Thu, Aug 28, 2025 at 03:27:24PM +0300, Kirill Rekhov a écrit : That looks all good this time. I think debian/copyright could still have been condensed a bit more, but this should not be a blocker. It can still be improved later. I just sent devilutionx 1.5.4+ds-1 to the NEW queue, hoping it’s going to clear it without any problem.
Hi, Antoine I see a message from Debian FTP Masters: Source-only uploads to NEW are not allowed. binary:devilutionx is NEW. binary:devilutionx-data is NEW. source:devilutionx is NEW. Something went wrong -- Regards, Kirill Rekhov Currently Debian Maintainer GPG Fingerprint: 2640 769D FDA1 AAA0 F863 D1AE 5F2C 5905 519C E0A0 Debian Salsa: https://salsa.debian.org/krekhov Debian Person: https://nm.debian.org/person/krekhov Debian QA Page: https://qa.debian.org/developer.php?login=krekhov.dev@gmail.com GitHub: https://github.com/krekhovx ср, 3 сент. 2025 г. в 12:01, Antoine Le Gonidec <vv221@debian.org>:
Le Wed, Sep 03, 2025 at 08:39:29PM +0300, Kirill Rekhov a écrit : The mistake is on my part, there is nothing wrong with the pakaging you prepared. I’m going to fix that right now.