Dear maintainer(s),

With a recent upload of imagemagick the autopkgtest of xplanet fails in
testing when that autopkgtest is run with the binary packages of
imagemagick from unstable. It passes when run with only packages from
testing. In tabular form:

                        pass            fail
imagemagick            from testing    8:7.1.1.47+dfsg1-1
xplanet                from testing    1.3.1-3
all others             from testing    from testing

I copied some of the output at the bottom of this report.

Currently this regression is blocking the migration of imagemagick to
testing [1]. Due to the nature of this issue, I filed this bug report
against both packages. Can you please investigate the situation and
reassign the bug to the right package?

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[1] https://qa.debian.org/excuses.php?package=imagemagick

https://ci.debian.net/data/autopkgtest/testing/amd64/x/xplanet/60456855/log.gz

  82s test_compare_images
  83s ASSERT:Comparing default.jpg
  83s ASSERT:Comparing default.png
  84s ASSERT:Comparing moon_orbit.jpg
  84s ASSERT:Comparing moon_orbit.png
  85s ASSERT:Comparing overlay_clouds.jpg
  85s ASSERT:Comparing overlay_clouds.png
  85s shunit2:ERROR test_compare_images() returned non-zero return code.
  85s  85s Ran 1 test.
  85s  85s FAILED (failures=7)
  85s autopkgtest [03:08:02]: test compare-create-image

Hi,

* Paul Gevers <elbrus@debian.org> [2025-05-10 14:24]:

There are multiple problems:

1. imagemagick changed the output of compare in 7.1.1-44 (d85a7583f)
    from some number <= 1 with 1 meaning the images are the same two two
    numbers where the first is the distortion and the second one is the
    old percentage in parenthesis. This breaks the test code in
https://sources.debian.org/src/xplanet/1.3.1-3/debian/tests/compare-create-image/#L32
    I assume that the new format will be kept so xplanet should adopt the
    logic. Maybe something like:

    result_jpg="$( compare -metric ncc $AUTOPKGTEST_TMP/expected/$filename.jpeg $AUTOPKGTEST_TMP/$filename.jpeg $AUTOPKGTEST_TMP/diff.jpg 2>&1 | sed 's/.*(\(.*\))/\1/' )"

2. imagemagick in stable returns values below 0 for similar but
    different images. I did not check if this was different in older
    versions but I would expect so, given that the autopkgtest code
    checks the value for >0.99. This has been corrected by multiple
    patches in imagemagick git main.

3. imagemagick in unstable has a bug resulting in the same picture
    getting a percentage of 0 and different images a value of > 1. This
    has also been corrected in imagemagick git main (912b6a838).

4. The results of earth_markers.* in the compare-create-image
    autopkgtest improved (not sure due to what) so the files in
    debian/tests/expected/earth_markers.* need to be replaced.

I think we have to accept that the output of compare is not stable and
adopt xplanet. I see two options what to do:

a. Adopt the xplanet to cope with any output of compare. This could be
    either by just using the return value, hoping that the output on
    different architectures is stable nowadays (I did not test this) or
    by adding logic that only compares the number in case the return
    value is not 0 (perfect match) and then try to interpret the
    number(s).

b. Apply the imagemagick patches from git main and use the call from 1.
    above.

Cheers Jochen

Hi!

Thanks for checking and all the updates.

There would also be option c) dropping the compare tests.
I'm honestly not sure if the compare tests are worth the effort.

And xplanet would still have the file type tests.


Best regards,
  Alexander

Le vendredi 16 mai 2025, 13:31:55 heure d’été d’Europe centrale Jochen
Sprickerhof a écrit :

go b before hard freeze. Can I have git commit ?

Hi Bastien,

* Bastien Roucaries <rouca@debian.org> [2025-05-16 14:53]:

See all those patches for metrics here:

https://github.com/ImageMagick/ImageMagick/commits/main/MagickCore/compare.c

Not sure which ones to select (except 912b6a838).

Cheers Jochen

Hi ImageMagick Packaging Team, Bastien,

[Release Team member hat on]


As we're now in the Hard Freeze, it seem to me best to use the testing
version (8:7.1.1.43+dfsg1-1) of imagemagick for trixie and trixie-ignore
this bug, 1105051 and 1103190. Do you agree? Let's hope we don't need to
touch imagemagick in the last phase to the release. Please respond
quickly if you don't agree and be prepared for action.

Paul

Hi Paul,

Quoting Paul Gevers (2025-05-18 09:26:39)

as far as img2pdf bug #1103190 is concerned, it only applies what is in
unstable as far as I can see. Everything seems to be fine with the version in
testing with regards to img2pdf (just tested with sbuild -d testing).

Thanks!

cheers, josch

Le dimanche 18 mai 2025, 09:26:39 heure d’été d’Europe centrale Paul Gevers a
écrit :

Fine with me, I suppose we could use testing PU in case of security bug ?

rouca

Control: tags -1 trixie-ignore


Great, let's do that then.


Reverting in unstable to the version in testing with a +really version
is the better option in that case.

Paul

We believe that the bug you reported is fixed in the latest version of
xplanet, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1105051@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alexander Reichle-Schmehl <tolimar@debian.org> (supplier of updated xplanet package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 17 Aug 2025 12:53:39 +0200
Source: xplanet
Binary: xplanet xplanet-dbgsym xplanet-images
Architecture: source amd64 all
Version: 1.3.1-4
Distribution: unstable
Urgency: medium
Maintainer: Alexander Reichle-Schmehl <tolimar@debian.org>
Changed-By: Alexander Reichle-Schmehl <tolimar@debian.org>
Description:
 xplanet    - planetary body renderer
 xplanet-images - imagery for xplanet
Closes: 1105051
Changes:
 xplanet (1.3.1-4) unstable; urgency=medium
 .
   [ Debian Janitor ]
   * Trim trailing whitespace.
   * Use secure URI in Homepage field.
   * Remove constraints unnecessary since buster (oldstable):
     + xplanet-images: Drop conflict with removed package xplanet (<< 0.71) in
       Breaks.
 .
   [ Alexander Reichle-Schmehl ]
   * Update debian/testes/earth_markers* as updated font results in slightly
     different image
   * Update debian/tests/compare-create-image to work with newer versions of
     imagemagicks compare (Closes: #1105051)
     (Actually: Let's try to solution in -2 again)
Checksums-Sha1:
 8cd59e4e49553c3a3c25419b5244b41a0048e85a 2166 xplanet_1.3.1-4.dsc
 ea793ca3d748cd1c8e942aefa9d8f2824de03a6c 2893700 xplanet_1.3.1-4.debian.tar.xz
 124eecd3096096df513e068de8db79121e162bd7 2371672 xplanet-dbgsym_1.3.1-4_amd64.deb
 1ed956d05c8863e32d26216de156a3e4a32ddff6 415448 xplanet-images_1.3.1-4_all.deb
 d6eedf4724c43d61df1464f1107a0decc0d8d76b 10544 xplanet_1.3.1-4_amd64.buildinfo
 d26d6f340e8e9eb113b9d20484c7b92e047c10ac 508256 xplanet_1.3.1-4_amd64.deb
Checksums-Sha256:
 148a208ef2ad863bb6cde57aad6e1dd7b762334e18db2b1ccf5f761e151b5ca7 2166 xplanet_1.3.1-4.dsc
 05d6ad9aeeda6d1d1d71b2acfd00f9fcd30f8687b83cff2950b7b61881329739 2893700 xplanet_1.3.1-4.debian.tar.xz
 fbaa3beed49cce5b7c757ecdc0ce156833b706ada0142925bc429e0ac72ed8f8 2371672 xplanet-dbgsym_1.3.1-4_amd64.deb
 486f57931a90a21d8b0118d250d7a677e23fc64a46e70a17b92c0b8cb57de63f 415448 xplanet-images_1.3.1-4_all.deb
 c637b8c521f78fcff1aa48b7c1d11987bfe62602b6db117e86c6f30e829ac102 10544 xplanet_1.3.1-4_amd64.buildinfo
 a59bf077963ca2998d965e00597af06ae2f2395a5d29c420f52e24271ee839d8 508256 xplanet_1.3.1-4_amd64.deb
Files:
 f6e4b03adb4f993e1a907fe89a132085 2166 graphics optional xplanet_1.3.1-4.dsc
 5da9bc519221481025b61450570f62b5 2893700 graphics optional xplanet_1.3.1-4.debian.tar.xz
 c1b0054c2815fedc2012d9fded0cfece 2371672 debug optional xplanet-dbgsym_1.3.1-4_amd64.deb
 209781562d5908dd5090506e38ed1aff 415448 graphics optional xplanet-images_1.3.1-4_all.deb
 ea76ba22b7736d778f5f7a8a685ae989 10544 graphics optional xplanet_1.3.1-4_amd64.buildinfo
 81d36725c88cf7c9c1f676fe477bfaee 508256 graphics optional xplanet_1.3.1-4_amd64.deb
-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEE7gG3whJsKEfq38cgwktlomcsixIFAmihtt0THHRvbGltYXJA
ZGViaWFuLm9yZwAKCRDCS2WiZyyLErqkD/98SO1UfpDoR5+RFevSKKoem44ugwXV
XAYMJEl53eIPL6yek3NFytp1oGJlsnPyFX22UW1AfFOfuu2cufQ0RLJSHKwnmIuS
BulA1SOh8Fqagj0m6SAen5BcF9JDKvPi5kL8a0t7HxMbJtnYdFOWaplgnuh9ECae
MugmWQTsparB6wc9tB9ZF3xEFHhEHloVb+vGCR1erHqZDjlKmS6uJ54sn98LS/Pj
klMHgg3QxYcamqirbEW7eB/LSiMGPlSYqcYC3iPXrJVDFkmn/biaBnxIM6BqQGMN
o84F7EteuruSGh26wCyudLCzpE1p+U5qHQvahxZYfDicj8tpo3rpOEWA7biV8O/H
dOm+o7cvpj4TApbfxhevFXfOaNq4VwoAsc5EkT6PP2kmNfhJ284ugn6px30kwh/2
RpiALHhpmlddCGkFM+M2u+ouGK6mDzx/bGCLy4k4v7YCKJ+Anqjb8N59wBQXIRUJ
CgJZDcuwEQa5bWTqG//q88rOZrfchNO51uAp/DtG/enkYLWczvV6M8WU+nZb+UnS
fheSZsSDsdFw8Eb5zLDmurgjKVfQcKfrjWNTdSiY65NnI2/cXodh6+4fTQLay2L1
Uu6QmeGsSfWinvrlUwDcqIMpGxuqBKy5I4QGuUO3+w/Z/6iql2mdEXvMzWeq6ie8
xEs46lOs4VAH5g==
=Cc6w
-----END PGP SIGNATURE-----