#1105355 giza: FTBFS with make --shuffle=reverse: make[4]: *** [Makefile:1030: check_output_files] Error 1 shuffle=reverse

Package:
src:giza
Source:
src:giza
Submitter:
Lucas Nussbaum
Date:
2026-02-05 22:37:02 UTC
Severity:
normal
Tags:
#1105355#5
Date:
2025-05-13 18:58:46 UTC
From:
To:
Hi,

GNU Make now has a --shuffle option that simulates non-deterministic ordering
of target prerequisites. See
https://trofi.github.io/posts/238-new-make-shuffle-mode.html and also previous
work in Debian by Santiago Vila:
https://people.debian.org/~sanvila/make-shuffle/

This package fails to build with make --shuffle=reverse.
This is likely to be caused by a missing dependency in
debian/rules or an upstream Makefile.

More information about this mass bug filing is available at
https://wiki.debian.org/qa.debian.org/FTBFS/Shuffle

Relevant part (hopefully):
The full build log is available from:
http://qa-logs.debian.net/2025/05/05/shuffle/reverse/giza_1.5.0-2_unstable_reverse.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

#1105355#12
Date:
2026-02-05 12:12:52 UTC
From:
To:
Hello,

I reproduced the FTBFS with GNU make shuffle mode
(MAKEFLAGS=--shuffle=reverse).
The failure happened because the PNG verification step was executed
before the test programs ran.
The PNG files are created only when the tests are executed, but under
shuffle mode the check could run first due to missing ordering.

I fixed this by removing the custom check rule and moving the PNG
verification to check-local, with an explicit dependency on check-TESTS,
so the tests always run before the PNG check.
--- giza-1.5.0.orig/test/F90/Makefile.am +++ giza-1.5.0/test/F90/Makefile.am @@ -10,13 +10,10 @@ TESTS = $(ftests) check_PROGRAMS = $(ftests) AM_DEFAULT_SOURCE_EXT = .f90 -# Ensure that the tests are built as part of the 'check' target -check: $(ftests) check_output_files - test_output_files = giza-test.png giza-test-2D.png # Custom target to check for the existence of expected output files from the Fortran tests -check_output_files: $(ftests) +check-local: check-TESTS @echo "Checking for required png files..." @for i in $(test_output_files); do \ if [ ! -s $$i ]; then \ @@ -26,4 +23,6 @@ check_output_files: $(ftests) echo "$$i exists"; \ fi; \ done - @echo "All required png files exist." \ No newline at end of file + @echo "All required png files exist." + + With this change, the package builds successfully under shuffle mode on ppc64el I have attached a patch that fixes the issue described above. I would appreciate a review. Thanks, Trupti
#1105355#17
Date:
2026-02-05 13:12:57 UTC
From:
To:
Hi Trupti,

on a first look your patch look right. However, could you make a pull
request upstream, https://github.com/danieljprice/giza? That could make
sure that we use the same change as upstream will, and we get another
eye on it.

Cheers

Ole

Am 05.02.26 um 13:12 schrieb Trupti:

#1105355#24
Date:
2026-02-05 13:39:29 UTC
From:
To:
Hi Ole,

Thank you for your response.
I will open an upstream pull request and will update you once it is
done.

Thanks,
Trupti

#1105355#29
Date:
2026-02-05 22:34:57 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
giza, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1105355@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ole Streicher <olebole@debian.org> (supplier of updated giza package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 05 Feb 2026 22:50:44 +0100
Source: giza
Architecture: source
Version: 1.5.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Astro Team <debian-astro-maintainers@lists.alioth.debian.org>
Changed-By: Ole Streicher <olebole@debian.org>
Closes: 1105355
Changes:
 giza (1.5.0-3) unstable; urgency=medium
 .
   [ Phil Wyett ]
   * Convert 'd/watch' to version 5 format.
   * Remove no longer needed 'Rules-Requires-Root: no'. Now is default behavior.
 .
   [ Ole Streicher ]
   * Fix test ordering under make shuffle mode (Closes: #1105355)
   * Push Standards-Version to 4.7.3, no changes needed
Checksums-Sha1:
 71d8f375648d794f7852b08645ffbc3042c8918b 2096 giza_1.5.0-3.dsc
 c36c65f7cc6cae0c5663c0157d12bdcb488d3dbf 5984 giza_1.5.0-3.debian.tar.xz
Checksums-Sha256:
 a6b7f0c457c248c79ac1c06ec61bc1f0fa0d891affb21ed89e840dff8cea2b5f 2096 giza_1.5.0-3.dsc
 fc1f4ce8329e755d397e7081b11e712812859b5a9b4ba6f862f51f79ad2b8089 5984 giza_1.5.0-3.debian.tar.xz
Files:
 3d838c0fb2734ebc33bcac411aacc979 2096 science optional giza_1.5.0-3.dsc
 437e124fd8c8780c61960b2297f5ff58 5984 science optional giza_1.5.0-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEuvxshffLFD/utvsVcRWv0HcQ3PcFAmmFFe0ACgkQcRWv0HcQ
3PcDhA/9GJWbVXFtm3OGjUy5GwWPhNy/UyMVzOnWnfUpYDtHuPRXxXMqIY93chsJ
QjFyeW+NxpdiSkAG29pY7zLdeijXJQ5+cjte6KSTT4rlYfjA4TubxTb2HrfJLWVO
W+EqUaRrh+BCO2t6EXCnjGbVe8FA56qPPmIcMCDuILsyiyBKqlxyhmj+NZYpHRrj
n5TL2MkCWqrkKcRZw4OaNhEPGmU9Iwc5pLdn0HspgEmRTxOYTaZcqe8rHVdNXG1S
7QHM5GpVSNnOH/klUGm0tnsYhC4tE6fo0lplBjUTvuI8nxyCu+R30ZzWaIhS3nMl
xxhieVq1f2DUyvgpku2695PJFq9cdJ/rSixB5IVetNDVzcxvL3qlsvrqVPKI2IZB
BRUdnmUIH09z12JbpwQ9BcZRNctyRC0fkb7t99xtYPsOP/hRO7ZKHTBSL9CglA70
5Y1UeTn1IV9BF8tE8ieCMPAxqASliZeWDrXgi1JbU6xK8euQ3pB/Aw2LIqkizXfq
sLV7y2QWfs91Vq20uNOLJQGY/Jc8c3Hzq+oyOzQJikEfxSs7tscAx9K+u1nXxfkz
UEE17ZquHFmDw4VGEHZpYUKQBv83Jrj6tV9RFsxpg96vssF5xjYxoIKTiZIWTRHE
lzv409D23xq2KNHex8qlOyLMRBhXagD6+GkP/oGk2L8ICM9xKdU=
=0w68
-----END PGP SIGNATURE-----