Dear Maintainer,
*** Reporter, please consider answering these questions, where appropriate ***
* What led up to the situation?
I am in an internship at Synchrotron-Soleil , my directors are Frederic-
Emmanuel PICCA and Emmanuel FARHI. I implemented Rocm and Pocl autopkgtest for
architecture amd64 and arm64. And I would like to push it.
I implemented autopktests for rocm and pocl using Opencl on the package named
on local. The aim is to have an overview of code compatibility with various AMD
graphics cards, the codes on all the AMD boards available for CI rocm for GPU
and Pocl for CPU.
* What exactly did you do (or not do) that was effective (or ineffective)?
I implemented the autopkgtest dependencies for pynx in debian/tests/control
debian/tests/control:
# flaky test for now
Test-Command: rocm-test-launcher debian/tests/opencl
Depends:
@,
clinfo,
rocm-opencl-icd,
pkg-rocm-tools,
python3-all,
python3-pytest,
python3-pytest-mock,
python3-pytest-xvfb,
python-pycuda-doc,
xauth,
xvfb,
hipcc,
rocm-device-libs-17,
libclang-common-17-dev,
Architecture: i386 amd64 arm64
Features: test-name=opencl-rocm
Restrictions: allow-stderr,flaky, skip-not-installable, skippable
Test-Command: debian/tests/opencl
Depends:
@,
clinfo,
pocl-opencl-icd,
python3-all,
python3-pytest,
python3-pytest-mock,
python3-pytest-xvfb,
python-pycuda-doc,
xauth,
hipcc,
xvfb,
Features: test-name=opencl-pocl
Architecture: i386 amd64 arm64
Restrictions: allow-stderr,flaky, skip-not-installable, skippable
Test-Command: xvfb-run -s "-screen 0 1024x768x24 -ac +extension GLX +render
-noreset" sh debian/tests/gui
Depends:
debhelper,
mesa-utils,
pocl-opencl-icd,
pynx,
python3-all,
@,
xauth,
xvfb,
python-pycuda-doc,
Architecture: i386 amd64 arm64
Restrictions: allow-stderr, flaky, skip-not-installable, skippable
I also made pacthes because we have a couple of errors of code :
------------------------- pynx/ptycho/runner/tps25a.py
-------------------------
index 77076dd..394c9ae 100644
@@ -149,6 +149,8 @@ class PtychoRunnerTPS25A(PtychoRunner):
Returns: Nothing. Will raise an exception if necessary
"""
if self.params['scanfile'] is None:
- raise PtychoRunnerException('Missing argument: no scanfile given')
+ # raise PtychoRunnerException('Missing argument: no scanfile
given')
+ pass
if self.params['data'] is None:
- raise PtychoRunnerException('Missing argument: no data (hdf5
master) given')
+ # raise PtychoRunnerException('Missing argument: no data (hdf5
master) given')
+ pass
------------------------- debian/patches/series -------------------------
-1,2 +1,4 @@
+0001-pynx_tps25apty.py-delete-of-helptext_generic.patch
0002-relax-h5py-scipy-pyopencl-dependency-for-backportabl.patch
0002-fix-for-hermes.patch
+0004-pynx_tps25apty.py-Deleted-helptext_generic.patch
------------------------- pynx/ptycho/runner/runner.py
-------------------------
index abda6df..3b68cea 100644
@@ -103,6 +103,7 @@ default_params = {
'saveplot': False,
'saveprefix': 'ResultsScan{scan:04d}/Run{run:04d}',
'scan': None,
+ 'scanfile': None,
'stack_size': None,
'verbose': 50,
'xy': None,
pynx_tps25apty.py Deleted helptext_generic
Because we have no helptext_generic in pynx/ptycho/runner
Replace generic_params by default_params
---------------- pynx/ptycho/examples/LLK-Stats-AutoMask.ipynb ----------------
index 94cac66..a30a7eb 100644
@@ -62,7 +62,7 @@
"\n",
"# Import CXI runner\n",
"from pynx.ptycho.runner.cxi import PtychoRunnerScanCXI\n",
- "from pynx.ptycho.runner.runner import params_generic as params\n",
+ "from pynx.ptycho.runner.runner import default_params as params\n",
"\n",
"from IPython.core.display import display, HTML\n",
"display(HTML(\"<style>.container { width:80% !important; }</style>\"))"
----- pynx/ptycho/examples/ptycho_operators-cuda-opencl-compare-CXI.ipynb -----
index 6c5c55f..480321c 100644
@@ -47,7 +47,7 @@
"\n",
"# Import CXI runner\n",
"from pynx.ptycho.runner.cxi import PtychoRunnerScanCXI\n",
- "from pynx.ptycho.runner.runner import params_generic as params\n",
+ "from pynx.ptycho.runner.runner import default_params as params\n",
"\n",
"# Load explicitely both OpenCL and CUDA operators\n",
"import pynx.ptycho.cl_operator as clop\n",
------------------------- pynx/ptycho/runner/tps25a.py
-------------------------
index 0421d2f..77076dd 100644
@@ -15,7 +15,7 @@ import timeit
from ...utils import h5py
import numpy as np
-------------------- pynx/ptycho/scripts/pynx_tps25apty.py --------------------
index 484a738..86ccfa4 100644
@@ -8,10 +8,10 @@
import sys
-from pynx.ptycho.runner import helptext_generic, PtychoRunnerException
+from pynx.ptycho.runner import PtychoRunnerException
from pynx.ptycho.runner.tps25a import PtychoRunnerTPS25A,
PtychoRunnerScanTPS25A, helptext_beamline, params