Dear Maintainer,

vdr-plugin-xineliboutput FTCBFS due to multiple reasons. I am listing them with some of
the fixes done.

1. Hard-coding of pkg-config at various places, thereby not allowing arch triplet
prefixed pkg-config to be used during cross builds. added patch to makefile.

2. In d/rules:
    + CC, CXX were not passed to home-grown ./configure. I also added in a option to take pkgconfig here
    + this seems to really need a -fPIC, I checked build logs of all archs that have this so added it in
    + exported DPKG_EXPORT_BUILDTOOLS and added resepective headers

3. mpg2c executes during the build, which will inevitably give exec format error. however, the output
of this is arch indep. I checked this on atleast 3 arches using porter boxes to confirm. the output
was identical. so this can be compiled with build arch compiler.

I've attached a patch with these fixes. please review/merge.

thanks
nilesh

Hi Nilesh,

It's not clear from the patch context whether CC_FOR_BUILD is
initialized anywhere. If it isn't, please add

    CC_FOR_BUILD ?= $(CC)

to avoid regressing native builds.

It feels wrong to have to pass these to the Makefile after having passed
them to configure. The usual convention is that configure records the
values passed somewhere for make to pick up. Don't get me wrong, it's
not a regression of the patch at hand, but an upstream aspect.

You may also leverage debhelper for passing many of these by using

    dh_auto_build --buildsystem=makefile -- all ...

as there are provisions to add CC, CXX, PKG_CONFIG and others to the
make invocation unless a higher level buildsystem (e.g. autoconf) is in
use. By forcing the lower level buildsystem, the passing is activated.

Helmut

Thank you very much Helmut for your review.

I've attached a new patch per your suggestions.

Best,
Nilesh