#1111519 RFP: rocprofiler-register -- ROCm library for HSA/HIP/ROCTx call interception

#1111519#5
Date:
2025-08-18 22:34:38 UTC
From:
To:
* Package name    : rocprofiler-register
  Version         : 4.6.3
* URL             : https://github.com/ROCm/rocprofiler-register
* License         : Expat
  Programming Lang: C, C++
  Description     : ROCm library for HSA/HIP/ROCTx call interception

The rocprofiler-register library is a helper library that coordinates
the modification of the intercept API tables of the HSA/HIP/ROCTx
runtime libraries by the ROCprofiler library. The purpose of this
library is to provide a consistent and automated mechanism of enabling
performance analysis in the ROCm runtimes which does not rely on
environment variables or unique methods for each runtime library.

This library is an optional dependency of the rocr-runtime and is
a required component of the AMD ROCm performance profiling stack.

This package is part of the AMD ROCm stack and will be maintained
under the Debian ROCm Team.

#1111519#12
Date:
2026-10-12 07:57:32 UTC
From:
To:
This is an automated message from the Debian DFSG, Licensing & New
Packages Team.

The Debian NEW review of rocprofiler-register 7.2.4+ds-1~exp1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

An LLM assisted review came up with the following issues.  Due to the somewhat bleeding edge nature of ROCm I wouldn't be at all surprised to find these are not actually issues, but maybe they are...  I'm pretty sure that first issue is wrong in some ways though :-)


1. [packaging] libhsa-runtime-dev build-dep is unneeded and amd64-only, making arm64/ppc64el
 unbuildable

 - Files: `debian/control:4-10`, `debian/control:21`
 - Evidence: `Build-Depends: debhelper-compat (= 14), architecture-is-64-bit, cmake, libhsa-runtime-dev (>= 7~), libgoogle-glog-dev, libfmt-dev`; `Architecture: amd64 arm64 ppc64el`. apt-cache shows `libhsa-runtime-dev ...  Architecture: amd64` (both 7.2.4+dfsg-1~exp1 and 6.4.3+dfsg-5).
 - Problem: The library does not include any HSA header: source/ only declares `#pragma weak`/`extern` import symbols for hsa/hip/roctx (rocprofiler_register.cpp) and the HSA/HIP/ROCTx mock runtimes are built only from the tests tree, which is OFF by default (ROCPROFILER_REGISTER_BUILD_TESTS OFF, not enabled in rules). CMake links only fmt, glog, dl, stdc++fs, Threads. The dependency is therefore unused, and because libhsa-runtime-dev exists only for amd64 the Build-Depends are unsatisfiable on arm64 and ppc64el, so the two architectures declared in the `Architecture` field can never be built (a sponsor would reject the arch list / dep combination).
 - Fix: Drop `libhsa-runtime-dev (>= 7~)` from Build-Depends (it is not needed to compile or link), which also lets arm64/ppc64el satisfy the build-dependencies; reconsider whether ppc64el (not a ROCm target) belongs in `Architecture` at all.


2. [packaging] debian/watch: wrong GitHub template Project name and dead Filename-Mangle

 - Files: `debian/watch:4-19`
 - Evidence: `Project: rocm-system` (actual repo is `ROCm/rocm-systems`, masked only by the explicit `Source:` field); uscan verbose: `Parsing filenamemangle: s%.*/(?:[-_]?[Vv]?([0-9...]))%rocprofiler-register-$1.tar.gz%` then `Filename (filenamemangled) for downloaded file: rocm-7.2.4`.
 - Problem: The template's Owner/Project pair points at a non-existent repository and only works because `Source:` overrides it; the Filename-Mangle pattern cannot match the GitHub API/tarball URL once @ANY_VERSION@ expands to the version regex, so the intended `rocprofiler-register-<ver>.tar.gz` filename is never produced (uscan would save `rocm-7.2.4`). Purely cosmetic; the scan itself finds and compares rocm-7.2.4 correctly.
 - Fix: Use `Project: rocm-systems`, drop the now-redundant Source/Matching-Pattern overrides, and either fix the Filename-Mangle so it matches the version digits at the end of the mangled download URL or drop it.


Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/rocprofiler-register

#1111519#17
Date:
2026-10-12 08:10:16 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
rocprofiler-register, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1111519@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastien Roucariès <rouca@debian.org> (supplier of updated rocprofiler-register package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 04 Oct 2026 19:41:13 +0200
Source: rocprofiler-register
Binary: librocprofiler-register-0 librocprofiler-register-0-dbgsym librocprofiler-register-0-dev
Architecture: source amd64
Version: 7.2.4+ds-1~exp1
Distribution: experimental
Urgency: medium
Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Changed-By: Bastien Roucariès <rouca@debian.org>
Description:
 librocprofiler-register-0 - ROCm library for HSA/HIP/ROCTx call interception
 librocprofiler-register-0-dev - ROCm library for HSA/HIP/ROCTx call interception - development fi
Closes: 1111519
Changes:
 rocprofiler-register (7.2.4+ds-1~exp1) experimental; urgency=medium
 .
   * Initial release. (Closes: #1111519)
Checksums-Sha1:
 1363e4494ec52e3a3b5ab84441db79ccb7a58766 2343 rocprofiler-register_7.2.4+ds-1~exp1.dsc
 27422d54147caa9075286f8ea95e683de4ee04bd 49304 rocprofiler-register_7.2.4+ds.orig.tar.xz
 62dae257add4fe82a709c11857341206c202dd6f 4060 rocprofiler-register_7.2.4+ds-1~exp1.debian.tar.xz
 0e0be6fc22c0eae4fe0939334dc8373226a0aeab 1188020 librocprofiler-register-0-dbgsym_7.2.4+ds-1~exp1_amd64.deb
 ff64351057837f7c080febcd42f0f54c1835e6a1 7900 librocprofiler-register-0-dev_7.2.4+ds-1~exp1_amd64.deb
 a20374fcdabf5d11a9a32a7a4ccfde1de1d36808 85588 librocprofiler-register-0_7.2.4+ds-1~exp1_amd64.deb
 6e73a5941d2e1dd07adbf4551edf77e669da54a5 7929 rocprofiler-register_7.2.4+ds-1~exp1_amd64.buildinfo
Checksums-Sha256:
 8fc41645fcd6766cb6ec9fff4231e92843ee6ddd9034730b9770dff58c9fa27d 2343 rocprofiler-register_7.2.4+ds-1~exp1.dsc
 76fbe7445ed23d7fcb5c816fa78506468a1aa15d0bc243190b4bf95009060bff 49304 rocprofiler-register_7.2.4+ds.orig.tar.xz
 5c6be1978be9ce26dda62134d0ddf38609f11d7bc505b6bc3f4a23f4a2a828dd 4060 rocprofiler-register_7.2.4+ds-1~exp1.debian.tar.xz
 6e8602f2222a2fdd26037902979b1ee122ffcd12570bc8fe298e143124f01cfb 1188020 librocprofiler-register-0-dbgsym_7.2.4+ds-1~exp1_amd64.deb
 caa992a0f9afdbd49d879577586f1032f9e3643009a764546c600040c0bc294f 7900 librocprofiler-register-0-dev_7.2.4+ds-1~exp1_amd64.deb
 369de43cd422312459bf50a68f7d2aa71536693a3ffd25b615aad0081d6a23ca 85588 librocprofiler-register-0_7.2.4+ds-1~exp1_amd64.deb
 ec37728f93dc6a4f73c0871a9230c92b7f0ed75ac34822d2d442567a15c21ae2 7929 rocprofiler-register_7.2.4+ds-1~exp1_amd64.buildinfo
Files:
 8bd63682fb2031e62a89379ad1ae4632 2343 devel optional rocprofiler-register_7.2.4+ds-1~exp1.dsc
 5f3d4e46461276d1f7ef9432b1384146 49304 devel optional rocprofiler-register_7.2.4+ds.orig.tar.xz
 2c5ca9cc40b726b85f772f6ac93c3743 4060 devel optional rocprofiler-register_7.2.4+ds-1~exp1.debian.tar.xz
 d50374f93bc37f3d5e28e8d221df6240 1188020 debug optional librocprofiler-register-0-dbgsym_7.2.4+ds-1~exp1_amd64.deb
 77f623b5aeab777d6452c5bd507a655b 7900 devel optional librocprofiler-register-0-dev_7.2.4+ds-1~exp1_amd64.deb
 f1be73380682b6c335c4091de7102ab0 85588 devel optional librocprofiler-register-0_7.2.4+ds-1~exp1_amd64.deb
 14a91378ead455d7967353b221840973 7929 devel optional rocprofiler-register_7.2.4+ds-1~exp1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXQGHuUCiRbrXsPVqADoaLapBCF8FAmrL+qMACgkQADoaLapB
CF/rNg//c/I10zQD5vbRM5myX5m3nQmu/jAkqluX33Ukzefu2B/yIzlCTvOvnPXC
D0HbPs36RZ1c1a31+mzLu0eVyb3vTQvLgHMWDFK+fNbfRm8j914kTt7ie+UsNqOx
oDVX7U4oOzygLqf3epwcfF+TthhL7+YVXnUq78uORSjqB/9fU3V/A92BZ5tXKKaS
DxcI9k+AnMV/C6pQWL9YUgtfHe73ZUYMT0nKALUxvL7V4Lwz/Gb0QsRXx+jcCuM5
oYe5KtFa3j6goX/KxhEW/BQG4/eIFWUdQxjFYdAEJ6O6nh3g1TAGzHoBdUa+wBaU
+tl/I9BKxIjdfBwHEUfA5D+Ka8Rq1oB0ABgbs5L+GUfCUTooAG7RhtlrcB17nQ2G
fp9p7chGePL45th0AsnV7j83QJL1aUBiCuVwlfOjN+LVUbeAKdVaHYmOE8sFUWsI
08rRPDOcEjsqSPKmR6djBCr/ocpa+I03Q+8y7ZHg8ta5P2/o9t1wfsuUC7R4U/zj
MN1cTnuVjsMLwBIkiw+KIjqxysz25su21lYWsqJa0WlK2huE3/aFEEIHvTtmzWDB
mxG5voGBvB/RQmi60rgm+G3KiazXtoOYam+KhfD1ulVmKP+tA5rWRo7gphYdM207
bs2AOaHHisn9zy/oWSm/s29BY9P4NVTatOkEbPDWLcK4ZGfhJtY=
=mfZi
-----END PGP SIGNATURE-----