#1115653 stop setting rules-requires-root

Package:
src:openafs
Source:
src:openafs
Submitter:
Andreas Beckmann
Date:
2025-09-19 03:15:02 UTC
Severity:
normal
Tags:
#1115653#5
Date:
2025-03-11 01:38:20 UTC
From:
To:
Hi,

I have a few updates for the -source package that I'd like to see in
trixie. Especially I want all -source packages in trixie to have
autopkgtests that check buildability of modules with module-assistant.

Thanks for considering

Andreas

PS: the git repository is not up-to-date, otherwise you could have
gotten a merge request

#1115653#10
Date:
2025-03-11 04:59:46 UTC
From:
To:
I was just recently looking at britney and seeing there was a complaint
about autopkgtests, so I will consider it good fortune that I now have
somewhere to start.

Oops, I guess I got distracted between uploading and the upload being
processed, so my tagging (and push) workflow did not proceed.  Thanks for
the reminder (fixed now, but no need to submit a MR given the patch is
here).

Thanks,

Ben

#1115653#15
Date:
2025-09-17 03:51:09 UTC
From:
To:
to focus on some work for upstream that ended up dragging out for a very
long time and I am only just getting back to this now.

A question, though: do the module-assistant-autopkgtest tests use the
default Testsuite: of autopkgtest?  Right now I already have an entry as
autopkgtest-pkg-dkms and it's unclear to me whether the default type that
dpkg adds will be appended to an already-extant Testsuite: stanza, or I
need to add it manually.

Thanks,

Ben

#1115653#20
Date:
2025-09-17 04:04:17 UTC
From:
To:
(the test command does use a script of that name but it seems to be
provided by the module-assistant package, and Google is not showing
anything to suggest that there's a package named
"module-assistant-autopkgtest" specifically.

Similarly, "Depends: linux-doc" seems very surprising.  Why would we need
the kernel documentation to build and test a module?  Was that intended to
be a different package?

Thanks again,

Ben

#1115653#25
Date:
2025-09-17 07:44:45 UTC
From:
To:
dpkg takes care of that

module-assistant-autopkgtest is a virtual package provided by
module-assistant (since the module-assistant-autopkgtest was added).
So the autopkgtest depends on the virtual package rather than
module-assistant (>= some-version-I-am-too-lazy-to-lookup)

Since the linux-headers-* packages change their names with every new
version and on every architecture, we cannot easily add a dependency on
them for the autopkgtest. On the other hand linux-doc is one of the few
packages built from src:linux that does not have a version number
embedded in its name and that is available on all architectures under
this name. It is therefore used for triggering autopkgtests whenever
src:linux gets uploaded. The script then looks at the version of the
installed linux-doc to select the matching linux-headers-* packages it
needs to install for the test. There are usually linux-headers-*
packages in sid from older versions that have not yet been decrufted and
that should not be used for the test.
The dkms amd module-assistant autopkgtests are special in the sense that
they install their real dependencies while running (and therefore need
to be needs-root, breaks-testbed) and not via dependencies.


Andreas