#1118264 lomiri-content-hub: Package contents is different when using the nocheck build profile

#1118264#5
Date:
2025-10-17 14:46:11 UTC
From:
To:
Dear maintainer:

When this package is built with the nocheck build profile, the contents of
the package lomiri-content-hub-testability.deb is different, which is a
violation of policy:

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /etc/apparmor.d/lomiri-content-hub-testability
-rw-r--r--  root/root   /usr/share/applications/lomiri-content-hub-test-exporter.desktop
-rw-r--r--  root/root   /usr/share/applications/lomiri-content-hub-test-importer.desktop
-rw-r--r--  root/root   /usr/share/applications/lomiri-content-hub-test-sharer.desktop
-rw-r--r--  root/root   /usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test-exporter.png
-rw-r--r--  root/root   /usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test-importer.png
-rw-r--r--  root/root   /usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test-sharer.png
-rw-r--r--  root/root   /usr/share/lomiri-content-hub/peers/lomiri-content-hub-test-exporter
-rw-r--r--  root/root   /usr/share/lomiri-content-hub/peers/lomiri-content-hub-test-importer
-rw-r--r--  root/root   /usr/share/lomiri-content-hub/peers/lomiri-content-hub-test-sharer
-rw-r--r--  root/root   /usr/share/lomiri-content-hub/testability/data/Joker.vcf
-rw-r--r--  root/root   /usr/share/lomiri-content-hub/testability/data/Music Ringtone.ogg
-rw-r--r--  root/root   /usr/share/lomiri-content-hub/testability/data/Stark,_Tony.vcf
-rw-r--r--  root/root   /usr/share/lomiri-content-hub/testability/data/clock.png
-rw-r--r--  root/root   /usr/share/lomiri-content-hub/testability/data/webbrowser-app.png
-rw-r--r--  root/root   DEBIAN/conffiles
-rwxr-xr-x  root/root   /usr/bin/lomiri-content-hub-test-exporter
-rwxr-xr-x  root/root   /usr/bin/lomiri-content-hub-test-importer
-rwxr-xr-x  root/root   /usr/bin/lomiri-content-hub-test-sharer
-rwxr-xr-x  root/root   DEBIAN/postinst
-rwxr-xr-x  root/root   DEBIAN/postrm


Moreover, when building the package using DEB_BUILD_OPTIONS=nocheck
(*not* the nocheck build profile, only the variable), the package fails
to build:


Totally, 0 B can be reduced.
Now making symbolic links. creating
Making 0 links.
cd debian/tmp/usr/share/doc/lomiri-content-hub/qml/html/ && symlinks -rc .
dh_install
dh_install: warning: Cannot find (any matches for) "usr/bin/lomiri-content-hub-test*" (tried in ., debian/tmp)

dh_install: warning: lomiri-content-hub-testability missing files: usr/bin/lomiri-content-hub-test*
dh_install: warning: Cannot find (any matches for) "usr/share/lomiri-content-hub/peers/lomiri-content-hub-test*" (tried in ., debian/tmp)

dh_install: warning: lomiri-content-hub-testability missing files: usr/share/lomiri-content-hub/peers/lomiri-content-hub-test*
dh_install: warning: Cannot find (any matches for) "usr/share/applications/lomiri-content-hub-test*" (tried in ., debian/tmp)

dh_install: warning: lomiri-content-hub-testability missing files: usr/share/applications/lomiri-content-hub-test*
dh_install: warning: Cannot find (any matches for) "usr/share/lomiri-content-hub/testability/data" (tried in ., debian/tmp)

dh_install: warning: lomiri-content-hub-testability missing files: usr/share/lomiri-content-hub/testability/data
dh_install: warning: Cannot find (any matches for) "usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test*" (tried in ., debian/tmp)

dh_install: warning: lomiri-content-hub-testability missing files: usr/share/icons/hicolor/512x512/apps/lomiri-content-hub-test*
dh_install: error: missing files, aborting
make[1]: *** [debian/rules:63: override_dh_install] Error 255
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:28: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2


The attached patch tries to address both things (please double check).

Thanks.

#1118264#10
Date:
2025-10-23 19:06:01 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
lomiri-content-hub, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1118264@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Gabriel <sunweaver@debian.org> (supplier of updated lomiri-content-hub package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 23 Oct 2025 20:33:48 +0200
Source: lomiri-content-hub
Architecture: source
Version: 2.2.0~git20250807.642a369-1~exp2
Distribution: experimental
Urgency: medium
Maintainer: Debian UBports Team <team+ubports@tracker.debian.org>
Changed-By: Mike Gabriel <sunweaver@debian.org>
Closes: 1118264
Changes:
 lomiri-content-hub (2.2.0~git20250807.642a369-1~exp2) experimental; urgency=medium
 .
   * Revisit DEB_BUILD_PROFILES 'noinsttest' and 'nocheck' vs. DEB_BUILD_OPTIONS
     'nocheck': (Closes: #1118264)
     - DEB_BUILD_PROFILES='nocheck' -> don't build, don't run and don't build
       the lomiri-content-hub-testability bin:pkg.
     - DEB_BUILD_PROFILES='nocheck noinsttest'-> same as above.
     - DEB_BUILD_PROFILES='noinsttest' -> build and run tests, but omit building
       the lomiri-content-hub-testability bin:pkg.
     - DEB_BUILD_OPTIONS='nocheck' -> build tests, install them into the lomiri-
       content-hub-testability bin:pkg, but don't run unit tests at build-time.
   * The above is implemented by the following two changes:
     + debian/rules: Set 'noinsttest' as additional build profile if 'nocheck'
       is set in DEB_BUILD_PROFILES (instead of being set in DEB_BUILD_OPTIONS).
     + debian/control: Only build lomiri-content-hub-testability bin:pkg if
       neither 'noinsttest' nor 'nocheck' are defined in DEB_BUILD_PROFILES.
Checksums-Sha1:
 8ba44cd9f49b536a8107d934327c8669f9dc59b6 4226 lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2.dsc
 12c64e021c857fbb23ae13cf8ec37ad1dfbb04a2 11928 lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2.debian.tar.xz
 39f4f9afdcff54ebb56c055dc23c3d3906b9b637 25796 lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2_source.buildinfo
Checksums-Sha256:
 dd87b707f21bd877edded81abb95cb34e091f5dc1c0b6fc3e2d02b548e518209 4226 lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2.dsc
 5ee2e486672e2923f3b4bf7cade1634e968271b718ee57a0859a10938013fc57 11928 lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2.debian.tar.xz
 fd87599405ce7b91f3624715468bf16668fb17ecbe334026d0e0d166c8cbd23c 25796 lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2_source.buildinfo
Files:
 614ebfd9d4641268bdcc2b6e6d0788c8 4226 misc optional lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2.dsc
 3ee2dd85a24d5f74d0ebe3a2ebf168fb 11928 misc optional lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2.debian.tar.xz
 efaf8a89440082af7d564aa58202164f 25796 misc optional lomiri-content-hub_2.2.0~git20250807.642a369-1~exp2_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCgAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmj6d3kVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxCWYQAJFUKdgqTVmADaoiD0G2L4Db9w58
T23E3jU8Wsf9zkh6uDTISxJO6S0EzLgqzz6ztNv7y8mYdcRN1RWUEJC1RLcNcTnP
bPzy44zP5a7NvBfRHPjMos5QzI1D/PMTZYXbXKcfikxhp+MwUnVos65u8G28Ur2b
aCUg4EpVc34R0oeXhAiVuaASTXNJH2Lt22tWrQEvw9P3TPjYUUbM2NvAd9Z48iu2
ONhZAiQMu6hkTUkUq/cStIx6Yi1rXUzXEghPO1AdoS4f6xLIj7WuWJD221TNrrzf
iBQ5z2VRFUFpVajpKhMcgczExswp6y+/eBC/x50BRPrc+vRftlOqnwxtCatLtm2e
Z15AvfAnVttHjKn/I3DWQt2Xh6qhABI5WDiQmVqF/+UaPa35liZm/pGA0XSukM6U
r5csYBsa1cx9AahBiCGSDY4w1s5iQctZXLTK/xx2tXJD8EhLwXivOw1nhjt/8o2z
Z9m7PJHb0hAsEsJ+BQqChuTToUeJqNy+IROwHlYk0Y++9VI3dNmH9EERCGtookDh
aNJ/MpBE8x4ikhi9uoORe1sAb9TcKK3r+4sDT9+i7qNXkl+Hv8U0yfL15WBcs2/X
rBzVUMi0Q+91dqYT/n3+gJOBXzzEKXP1BumdeNE6nN/d81MrbUKbVQlC6OzhvoWM
lFAOJPbXFTUrD6A0
=Gvfh
-----END PGP SIGNATURE-----

#1118264#15
Date:
2025-10-24 10:47:20 UTC
From:
To:
Hello. Are you really sure that the above change is correct?

I believe the spirit of nocheck build profile, in plain English, was
that the "outcome" of building the packages should be the same, and
for that to happen, not only the contents of the packages should be
the same, but also the list of generated packages should also be the
same.

Unfortunately, I was unable to find the Debian Policy paragraph
explaining this. Do you have a reference for that?

I am aware that the wiki has some examples where nocheck is used in
Build-profiles in debian/control, but I'm not really sure that's right
if the spirit of nocheck build profile is just to save some time when
building the packages.

Thanks.

#1118264#20
Date:
2025-10-25 10:51:35 UTC
From:
To:
Hi Santiago,

no, I am not 100% sure this is correct.

Where does this statement come from? Do we have this written down
somewhere? I get the point of it, but lomiri-content-hub source code
would need adjustments for this to become possible with the effect of
saving CPU time at build time.

Nope. I'd be interested in that, too.

The point is that nocheck does two things in lomiri-content-hub (and
in general): it avoids building the unit tests and it avoids running
the unit tests. That's the CPU time-saving part it provides.

In lomiri-content-hub, part of the unit test building is producing
mock-executables that act as clients against the lomiri-content-hub
service during autopkgtests. These mock consumers are packaged as the
lomiri-content-hub-testability bin:pkg. The
lomiri-content-hub-testability bin:pkg is totally unneeded except for
this one purpose. So, for speeding things up at build time (i.e.
nocheck), the l-c-h-testability bin:pkg must either be empty (dummy
content) or skipped from building. None complies with your above
interpretation of what nocheck is supposed to do / to deliver.

To get things more straight one would have to patch upstream's code in
a way, that we could build testability executables but omit building
the unit tests themselves. But such a patch would be highly Debian
specific and I am a bit reluctant to dive into this effort.

So, ideally, we get some more opinions on this, otherwise I will
consider this bug as closed. (Sorry, for not being more bureaucratic
on this).

light+love,
Mike

#1118264#25
Date:
2025-10-25 11:07:03 UTC
From:
To:
* Mike Gabriel <sunweaver@debian.org> [251025 13:03]:

nocheck has N + N, so binary packages and their contents cannot
change.

Chris

#1118264#30
Date:
2025-10-25 11:43:54 UTC
From:
To:
My interpretation was really "speed things up as far as you can do so
without altering the set of generated packages or their contents".

Usually, avoding to run the tests (even if you build them), already
saves some time.

Most Makefiles allow to separate building tests from running tests,
and I would say that most authors would accept a patch for doing so if
the current makefiles do not allow it. I don't think it would be
so much Debian-specific.

Chris wrote:

That's a good reference indeed. If that's really what we want, then I
guess some examples having nocheck in Build-Profiles in d/control
should be modified, as doing so makes the set of generated packages to
be different.

If this was my package, I would simplify it as much as possible.
Probably would remove the "noinsttest" build profile, as it seems that
implementing it the way you originally had in mind and honoring
nocheck at the same would force you to make changes that you consider
not worthy enough.

Thanks.

#1118264#37
Date:
2026-04-16 18:40:10 UTC
From:
To:
Hello,

Bug #1118264 in lomiri-content-hub reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/ubports-team/lomiri-content-hub/-/commit/b06969365b7930d1c9b96a8d78891a109e9bfc1b
------------------------------------------------------------------------
debian/rules: Build tests even if nocheck build profile is used. The built test executables are neded to populate the lomiri-content-hub-testability package. (Closes: #1118264).
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1118264

#1118264#42
Date:
2026-04-16 18:40:10 UTC
From:
To:
Hello,

Bug #1118264 in lomiri-content-hub reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/ubports-team/lomiri-content-hub/-/commit/52accd0a4bee6e135496f63e767183e7d46b2b5f
------------------------------------------------------------------------
debian/{control,rules}: Drop noinsttest build profile. (Closes: #1118264).
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1118264

#1118264#47
Date:
2026-04-16 18:49:12 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
lomiri-content-hub, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1118264@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Gabriel <sunweaver@debian.org> (supplier of updated lomiri-content-hub package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 16 Apr 2026 19:38:39 +0200
Source: lomiri-content-hub
Architecture: source
Version: 2.2.3-1
Distribution: unstable
Urgency: medium
Maintainer: Debian UBports Team <team+ubports@tracker.debian.org>
Changed-By: Mike Gabriel <sunweaver@debian.org>
Closes: 1118264
Changes:
 lomiri-content-hub (2.2.3-1) unstable; urgency=medium
 .
   * Upload to unstable.
 .
   * New upstream release.
   * Revert "debian/{rules,watch}: Adjust to packaging upstream Git snapshots
     for now."
   * debian/{control,rules}:
     + Drop noinsttest build profile. (Closes: #1118264).
   * debian/control:
     + Uncomment B-D: qml6-module-lomiri-components.
     + Drop Priority: field from global header.
     + Bump Standards-Version: to 4.7.4.
   * debian/rules:
     + Build tests even if nocheck build profile is used. The built test
       executables are neded to populate the lomiri-content-hub-testability
       package.
   * debian/copyright:
     + Update auto-generated copyright.in file.
     + Update copyright attributions.
   * debian/patches:
     + Add README file explaining our patch naming scheme.
   * lintian:
     + Ignore complaints about get-orig-source target in d/rules. We use it.
   * debian/README.source:
     + Add file. Explain cooperation between Debian UBports packaging team and
       UBports upstream packaging.
Checksums-Sha1:
 f861c3351a2960f41e9b49ee0b60b90dd569fc81 4071 lomiri-content-hub_2.2.3-1.dsc
 f184ae8bbccbc58ff78783df0c38c42fd7d04acf 1150652 lomiri-content-hub_2.2.3.orig.tar.bz2
 1ecd8a5d916f8e89675484ffd5cb1a6e200f83d4 11956 lomiri-content-hub_2.2.3-1.debian.tar.xz
 81beebfa698aca1f8ac0c5f7f6d7500996b83572 26134 lomiri-content-hub_2.2.3-1_source.buildinfo
Checksums-Sha256:
 150bbf0a835ee5fa3841fdc7a6e754daad013120284b31f4eb948168250aee93 4071 lomiri-content-hub_2.2.3-1.dsc
 7f0a2fb50732b22805384e8ae5ba9ecdad8cc9ff6cdb48cf2a1ea90a2199b164 1150652 lomiri-content-hub_2.2.3.orig.tar.bz2
 0a50dc52db686f3e4ee6aa0f516bfe27a45cb7ddf933aae5a5d84daff4453b2b 11956 lomiri-content-hub_2.2.3-1.debian.tar.xz
 a4ef4d1031e05bb2436f956ec118a6a92db21c6d2353d2a7b5440362f60d852e 26134 lomiri-content-hub_2.2.3-1_source.buildinfo
Files:
 cc212c3d171f8c9c7f8d1a5d65766cf0 4071 misc optional lomiri-content-hub_2.2.3-1.dsc
 fbbddf2d44c9b476b46da704b7fb6f01 1150652 misc optional lomiri-content-hub_2.2.3.orig.tar.bz2
 ae3b5eb0d0cedc2dd5b3f531acc85fdb 11956 misc optional lomiri-content-hub_2.2.3-1.debian.tar.xz
 ac20a4d6721e34f274819a6555fb717f 26134 misc optional lomiri-content-hub_2.2.3-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCgAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmnhLOwVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxltEP/15Gq832/rqHxGkn8i81jT3ObVrQ
n+hHgUJfyMRa0ucxjk/75B+hRKov2OoI0ib14rzzF6oEd48HB+Tvei9i0uZM4Zmf
v6mPg8eTJl/g37f9V6hH2KtCEXMf5pjIxE+cyv6oBnOnVho2W9zjlsBnISs7Srmu
p+HhJ+nlA7E1dez+2ypushWZ+/9+lmOzRdwsy+WctEhhv3RIjMkJtbZ3eMZmBG2T
Hhfj45/1U8AOJMbzRwU12UP2B6DKC7y/q+AWSTuRzpvWUeGJB/BKBCGxr4pExniV
iyLtg/3SSSwXtK1OqEvaeP07u6rJwLYqL4tQf/Ea6+MRoHFV/s1I0fKWD35Uj1E/
VnWihQBLaOb4ywS5vSirhgDWwQkbhSp9NiROC9wlAcqB3K61BSdL/LqVUX0Kq3cz
yvN4qsBKCfNN/9NJ9u56h05miITYibHb6ExRWLerNL2fEhUkX0DyDXFnMEeSla+Y
smG3bY8wtFZavcMbfbU+vkORh+S7iMBG4TP8NN4VMcEFSknoWJFIsfN8qtJ98qOS
d97bpi5bn3deyyAxv3XCk/YD16m3qsg6IylvJVl+1gKzRRGLfXuOEj8FTqYzAvCX
Zm+QdNorDdXMhRHePm1Romvl4s5hcJrX/rTI4rv8s1KwYYiodHuPpgO8rGT3QIdk
6V/+gOLkuPup3O0o
=d7Wg
-----END PGP SIGNATURE-----