#1123485 dvd+rw-tools: Patch solving #713016 is applied twice

Package:
dvd+rw-tools
Source:
dvd+rw-tools
Description:
DVD+-RW/R tools
Submitter:
Mykhailo Mishchenko
Date:
2025-12-16 21:01:03 UTC
Severity:
normal
#1123485#5
Date:
2025-12-16 20:59:14 UTC
From:
To:
Dear Maintainer,

I was working on a patch for #1123113 and noticed a following warning
from `quilt push -a`:
```
Applying patch fix_burning_bd-r_discs.patch
patching file growisofs_mmc.cpp
Hunk #1 succeeded at 814 (offset 58 lines).
```

Further investigation revealed, that `fix_burning_bd-r_discs.patch` and
`10-blue-ray-bug713016.patch` are adding the same fix at the same line
of the same function `bd_r_format()` in `growisofs_mmc.cpp`.
Unfortunately, after applying one of these patches `quilt` successfully
finds another piece of code where the second patch can be applied. It
happened due to a merge commit `c9c1910` before the `debian/7.1-12` tag,
where git branches with two almost identical patches were merged.

The results of this are to be judged by someone who actually understands
this code (and I do not), but I can definitely tell that it is an accident.

I have also checked that the source code retrieved with `apt-get source
dvd+rw-tools` also contains application of these two patches at the same
time. I believe that it is a packaging issue separate from #713016 (even
though related to it) and I thus am filing it as a separate bug report.

Best regards,
Mykhailo Mishchenko