#1123552 fossil: autopkgtest regression

#1123552#5
Date:
2025-12-17 18:05:28 UTC
From:
To:
https://tracker.debian.org/pkg/fossil

Issues preventing migration:
∙ ∙ Autopkgtest for fossil/1:2.27-2: amd64: Regression ♻ (reference ♻), arm64: Regression ♻ (reference ♻), i386: Regression ♻ (reference ♻), ppc64el: Regression ♻ (reference ♻), riscv64: Regression ♻ (reference ♻), s390x: Regression ♻ (reference ♻)


https://ci.debian.net/packages/f/fossil/testing/amd64/67220988/

...
199s test settings-valid-local-anon-cookie-lifespan FAILED!
...
199s test settings-valid-local-regexp-limit FAILED!
...
199s test settings-valid-local-robot-exception FAILED!
...
199s test settings-valid-global-anon-cookie-lifespan FAILED!
...
199s test settings-valid-global-regexp-limit FAILED!
...
199s test settings-valid-global-robot-exception FAILED!
...
212s ***** End of wiki: 6 errors so far ******
212s ***** Final results: 6 errors out of 42573 tests
212s ***** Considered failures: settings-valid-local-anon-cookie-lifespan settings-valid-local-regexp-limit settings-valid-local-robot-exception settings-valid-global-anon-cookie-lifespan settings-valid-global-regexp-limit settings-valid-global-robot-exception
212s ***** Ignored results: 0 ignored errors out of 42573 tests
212s ***** Skipped tests: json merge5 set-manifest th1-docs th1-hooks th1-tcl unversioned
213s autopkgtest [15:21:25]: test command1: -----------------------]
213s command1             FAIL non-zero exit status 1

#1123552#12
Date:
2026-07-19 16:23:21 UTC
From:
To:
fixed -1 1:2.28-1
#1123552#17
Date:
2026-08-19 15:20:51 UTC
From:
To:
Hi,

I rechecked fossil 1:2.28-1 and its autopkgtest results. The
autopkgtests pass on all six tested architectures.

Bug #1123552 is currently the only issue blocking Fossil's migration
back to testing. In 2.28, upstream disabled the failing
test/settings.test module, so the regression no longer occurs in
1:2.28-1.

I would therefore like to mark this bug as fixed in 1:2.28-1.

Please let me know if I have missed anything, and whether the bug can
be closed.

#1123552#22
Date:
2026-08-20 02:31:07 UTC
From:
To:

#1123552#29
Date:
2026-10-21 13:33:06 UTC
From:
To:
Hi,

fossil 1:2.28-1 migrated to testing on 2026-08-21, so this bug is no
longer blocking anything. Here is a follow-up on the root cause, for
the record.

Upstream disabled test/settings.test in 2.28 (renamed it to
settings.test.off), which is why the failures went away. But
test/settings-repo.test still iterates over the same get_all_settings
list in test/tester.tcl, and that list has fallen behind the settings
fossil actually supports. The three settings that triggered this bug
(anon-cookie-lifespan, regexp-limit, robot-exception) are still missing
from it, and five more have accumulated since -- so instead of failing,
they are now silently untested.

The attached patch adds all eight settings missing as of 2.28. I tested
it locally against a 2.28 build: settings-repo.test passes both before
and after, and after the patch those eight settings are actually
exercised.

I wanted to send this upstream first, but my registration on the Fossil
forum was rejected by the anti-robot check, so I am attaching it here
for the record instead. It is a test-coverage improvement, not
something Debian needs to carry -- if anyone would like to forward it
upstream, please go ahead.

#1123552#34
Date:
2026-10-21 13:40:17 UTC
From:
To:
Thanks. I will forward this upstream.
#1123552#39
Date:
2026-10-21 13:55:12 UTC
From:
To: