On a Debian 13 system, when I run scp file and hit tab to
auto-complete it logs me out of SSH and/or closes the xterm.  This
always worked previously until recently..

rss@box1:~$ . /etc/profile
rss@box1:~$ ls test-re
test-re

$ scp t (tab) box1# (logged out of rss user)

Is this expected?

Within /etc/profile it appears to be one of the files in this directory:

#if [ -d /etc/profile.d ]; then
#  for i in $(run-parts --list --regex
'^[a-zA-Z0-9_][a-zA-Z0-9._-]*\.sh$' /etc/profile.d); do
#    if [ -r $i ]; then
#      . $i
#    fi
#  done
#  unset i
#fi

When I remove this one from /etc/profile.d then tab completion works again:
bash_completion.sh (part of bash_completion)