Dear maintainer(s),
bs1770gain fails to build from source with glibc 2.43, currently in
experimental. From the build log:
| gcc -DHAVE_CONFIG_H -I. -I.. -I../libpbutil -I../lib1770-2 -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -Wstrict-prototypes -Wextra -Wreturn-type -Wcast-qual -Wcast-align -Wpointer-arith -Wformat -Wall -Werror -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/bs1770gain-0.9.8=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -c -o ff_rm.o ff_rm.c
| ff_csv2avdict.c: In function ‘priv_name’:
| ff_csv2avdict.c:538:14: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
| 538 | char *p1=strstr(p,"\\");
| | ^~~~~~
| ff_csv2avdict.c:539:14: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
| 539 | char *p2=strstr(p,"/");
| | ^~~~~~
| cc1: all warnings being treated as errors
| make[3]: *** [Makefile:383: ff_csv2avdict.o] Error 1
| make[3]: *** Waiting for unfinished jobs....
| make[3]: Leaving directory '/build/reproducible-path/bs1770gain-0.9.8/libff'
| make[2]: *** [Makefile:396: all-recursive] Error 1
| make[2]: Leaving directory '/build/reproducible-path/bs1770gain-0.9.8'
| make[1]: *** [Makefile:337: all] Error 2
| make[1]: Leaving directory '/build/reproducible-path/bs1770gain-0.9.8'
| dh_auto_build: error: make -j128 returned exit code 2
| make: *** [debian/rules:7: binary] Error 25
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2
The full build log is available here [1].
The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].
I would like to thanks Emanuele Rocca for doing the arcbhive rebuild on
a fast arm64 server.
Regards
Aurelien
[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/bs1770gain_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19