Dear maintainer(s),
fcoe-utils fails to build from source with glibc 2.43, currently in
experimental. From the build log:
| gcc -DPACKAGE_NAME=\"fcoe-utils\" -DPACKAGE_TARNAME=\"fcoe-utils\" -DPACKAGE_VERSION=\"1.0.34\" -DPACKAGE_STRING=\"fcoe-utils\ 1.0.34\" -DPACKAGE_BUGREPORT=\"https://github.com/openSUSE/fcoe-utils\" -DPACKAGE_URL=\"\" -DPACKAGE=\"fcoe-utils\" -DVERSION=\"1.0.34\" -I. -I./include -I./include -DSYSCONFDIR="\"/etc\"" -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wformat=2 -Werror -Wextra -Wmissing-prototypes -Wstrict-prototypes -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/fcoe-utils-1.0.34=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -c -o lib/sysfs_hba.o lib/sysfs_hba.c
| lib/fcoe_utils.c: In function ‘get_ifname_from_symbolic_name’:
| lib/fcoe_utils.c:164:28: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
| 164 | char *last_space = strrchr(symbolic_name, ' ');
| | ^~~~~~~
| lib/sysfs_hba.c: In function ‘get_pci_dev_from_netdev’:
| lib/sysfs_hba.c:447:23: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
| 447 | subif = strchr(netdev, '.');
| | ^
| cc1: all warnings being treated as errors
| make[1]: *** [Makefile:620: lib/fcoe_utils.o] Error 1
| make[1]: *** Waiting for unfinished jobs....
| cc1: all warnings being treated as errors
| make[1]: *** [Makefile:620: lib/sysfs_hba.o] Error 1
| make[1]: Leaving directory '/build/reproducible-path/fcoe-utils-1.0.34'
| dh_auto_build: error: make -j128 returned exit code 2
| make: *** [debian/rules:13: binary] Error 25
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2
The full build log is available here [1].
The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].
I would like to thanks Emanuele Rocca for doing the archive rebuild on
a fast arm64 server.
Regards
Aurelien
[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/fcoe-utils_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19