Dear maintainer(s),
libradsec fails to build from source with glibc 2.43, currently in
experimental. From the build log:
| /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Werror -g -DHAVE_CONFIG_H -Werror -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/libradsec-0.0.5=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -pthread -c -o libradsec_la-err.lo `test -f 'err.c' || echo './'`err.c
...
| libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Werror -g -DHAVE_CONFIG_H -Werror -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/libradsec-0.0.5=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -pthread -c err.c -fPIC -DPIC -o .libs/libradsec_la-err.o
...
| err.c: In function '_err_vcreate':
| err.c:87:23: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
| 87 | char *sep = strrchr (file, '/');
| | ^~~~~~~
...
| make[3]: *** [Makefile:648: libradsec_la-err.lo] Error 1
| make[3]: *** Waiting for unfinished jobs....
...
| make[3]: Leaving directory '/build/reproducible-path/libradsec-0.0.5'
| make[2]: *** [Makefile:743: all-recursive] Error 1
| make[2]: Leaving directory '/build/reproducible-path/libradsec-0.0.5'
| make[1]: *** [Makefile:466: all] Error 2
| make[1]: Leaving directory '/build/reproducible-path/libradsec-0.0.5'
| dh_auto_build: error: make -j128 returned exit code 2
| make: *** [debian/rules:10: binary] Error 255
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2
The full build log is available here [1].
The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].
I would like to thanks Emanuele Rocca for doing the archive rebuild on
a fast arm64 server.
Regards
Aurelien
[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/libradsec_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19