Dear maintainer(s),
pesign fails to build from source with glibc 2.43, currently in
experimental. From the build log:
| gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/pesign-116=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -Wextra -Wsign-compare -Wno-unused-result -Wno-unused-function -Wno-missing-field-initializers -Werror -Wno-error=cpp -Wno-free-nonheap-object -std=gnu11 -fshort-wchar -fPIC -fno-strict-aliasing -D_GNU_SOURCE -DCONFIG_aarch64 -I../include '-DRUNDIR="/run/"' -Wmaybe-uninitialized -grecord-gcc-switches -I/usr/include/efivar -I/usr/include/nss -I/usr/include/nspr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o pesum.o pesum.c
| pesum.c: In function ‘main’:
| pesum.c:144:29: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
| 144 | char *ext = strrchr(infile, '.');
| | ^~~~~~~
| cc1: all warnings being treated as errors
| make[2]: *** [/build/reproducible-path/pesign-116/Make.rules:34: pesum.o] Error 1
| make[2]: *** Waiting for unfinished jobs....
| make[2]: Leaving directory '/build/reproducible-path/pesign-116/src'
| make[1]: *** [Makefile:29: all] Error 2
| make[1]: Leaving directory '/build/reproducible-path/pesign-116'
| dh_auto_build: error: make -j128 returned exit code 2
| make: *** [debian/rules:15: binary] Error 25
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2
The full build log is available here [1].
The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].
I would like to thanks Emanuele Rocca for doing the archive rebuild on
a fast arm64 server.
Regards
Aurelien
[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/pesign_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19