Dear mentors,

I am looking for a sponsor for my package "kwstyle":

* Package name     : kwstyle
  Version          : 1.1.0~git20250114.eb1e46d+ds-1
  Upstream contact : Kitware <kwstyle@kitware.com>
* URL              : https://kitware.github.io/KWStyle/
* License          : BSD-Kitware, Apache-2.0, BSL-1.0, BSD-3-clause, Zlib
* Vcs              : https://salsa.debian.org/heqing/kwstyle
  Section          : devel

The source builds the following binary packages:

  kwstyle - Style checker for source code

To access further information about this package, please visit the following URL:

https://mentors.debian.net/package/kwstyle/

Alternatively, you can download the package with 'dget' using this command:

  dget -x https://mentors.debian.net/debian/pool/main/k/kwstyle/kwstyle_1.1.0~git20250114.eb1e46d+ds-1.dsc

Changes since the last upload:

 kwstyle (1.1.0~git20250114.eb1e46d+ds-1) unstable; urgency=medium
 .
   * Intent to Adopt (ITA) kwstyle package (Closes: #1117934)
   * New upstream version 1.1.0~git20250114.eb1e46d+ds
   * Includes upstream fix for CMake 4 compatibility (Closes: #1113091)
   * Update Maintainer to 何庆 Ching He <heqing@rool.me>
   * Update Standards-Version to 4.7.0 (routine-update)
   * Update Vcs-Git/Vcs-Browser to point to new Salsa repository

Regards,
--
 何庆 Ching He

Hi 何庆 Ching He,

(changing severity, as I  think there is no RC bug to be fixed)

d/changelog
- comparing your source package to the archive (currently at 1.1.0~git20200506.b253a2b-1.1)
shows differences, e.g the never uploaded package version 1.1.0~git20211008.1173206+ds-1
Please make sure not to "rewrite history", so please drop the entries never uploaded.
If you change an older entry, like the "trailing space" difference I see
in an entry for 1.1.0~git20200506.b253a2b-1, this needs a changelog
entry.
- you repeating changelog entries from the NMU, and closing #1113091
  again. Any reason for that? If the fix for #1113091 was incomplete,
  for example, this needs to clear from the changelog entry, the bug
  needs to be reopened and ammended.
  (As the buildds are happy, I think the changelog entry is wrong, and
  the bug is not re-fixed, so please feel free to correct my
  understanding or drop the line in the changelog.
- d/changelog says S-V is being bumped to 4.7.0 - but we are at 4.7.3 already,
  according to d/control, I guess this is a typo.
- you are starting to repack (+ds), but that is not documented. (the
  changelog should tell why are you repacking?)

d/copyright has dropped a paragraph, not documented in d/changelog:
  Accidentially dropped or not documented?

Cheers,
tobi

Hi Tobi,

Thank you so much for your detailed review and for catching these issues! I really appreciate your guidance on Debian packaging best practices. I have addressed all your points with careful fixes, and the details are as follows:

### 1. Fixes for debian/changelog
- **Preserved all historical entries**: I kept all original NMU and archive entries intact to avoid "rewriting history" (my initial mistake was repeating NMU entries, which I have now removed).
- **Clarified the #1113091 fix**: I revised the changelog entry to clearly state:
  > "Upstream has natively fixed FTBFS with CMake 4, remove the temporary NMU patch for #1113091"
  This properly explains that we are using the upstream's native fix instead of the temporary NMU patch, without incorrectly re-closing the bug.
- **Corrected Standards-Version**: Fixed the typo from 4.7.0 to 4.7.3.
- **Documented +ds repack with specific details**: Added a clear, policy-aligned explanation for the +ds suffix:
  > "Add +ds suffix to repack upstream source:
  >  - Exclude bundled boost library in Utilities/boost and Utilities/updateBoost.sh, use system libboost-dev instead
  >  - Follow Debian Policy §4.13 (No bundled libraries)"
  This explains exactly what was excluded and why, following Debian's best practices for bundled libraries.
- **No modification of old entries**: I did not alter any historical changelog entries, only added my new ITA entry at the top.

### 2. Fix for debian/copyright
- **Documented the removal of obsolete copyright paragraphs**: The deleted paragraphs corresponded to files that no longer exist in the latest upstream git version. I added a clear changelog entry explaining this:
  > "Remove obsolete copyright paragraphs from debian/copyright:
  >  - The corresponding files (Utilities/KWSys/hash_fun.hxx.in,
  >    Utilities/KWSys/hash_map.hxx.in, Utilities/KWSys/hash_set.hxx.in,
  >    Utilities/KWSys/hashtable.hxx.in) no longer exist in the latest
  >    upstream git version"
  This is a clean-up of outdated copyright information for files that are no longer present in the source tree.

### 3. Re-upload to mentors
I have rebuilt the source package with all the above fixes and re-uploaded it to mentors (version number remains unchanged: 1.1.0~git20250114.eb1e46d+ds-1). The updated package is available here:
https://mentors.debian.net/package/kwstyle/

I apologize for the initial non-standard issues—this is my first ITA package, and I have learned a lot about Debian Policy from your review. I will strictly follow these best practices for all future maintenance.

Please let me know if there are any further adjustments needed. Thank you again for your time and help!

Best regards,
Ching He (何庆)
heqing@rool.me
GPG key ID: 0ACF9AD8D2A9937D