Dear Maintainer, I have found a bug on version 1.4-1 of `pngphoon`, it always produce a picture of the full moon. I have checked that this bug is not present on version 1.3-3.1. Thanks a lot for keeping this software alive <3 (Sorry for any bad English, this is not my native tong) Best regards, Draco Metallium (Rodrigo S. Cañibano)
Hello again,
I had some time to check the code differences from version 1.3 and 1.4
to find how to revert back to the previous behaviour. This diff undoes
the changes added to `moon.c` (ignoring those that were just blank
space removals).
I do not understand the code enough to know what was intended, nor how
it works, so I do not know how to fix this while keeping the intention
behind the changes. I hope the original author of the previous patch
can use this to find where the bug is.
Thanks!!
DIFF:
118,129d117
< xleft = fxleft + moondata->width/2 + 0.5;
< xright = fxright + moondata->width/2 + 0.5;
<
< bytexleft = xleft / 8;
< bytexright = (xright+7) / 8;
<
< /* copy moon for later modification */
< for( x = bytexleft; x < bytexright; ++x )
< {
< image->bitmap[x + imageoff] = moondata->bitmap[x + moonoff];
< }
<
151a140,148
Hi, This project has had some issues since version 1.3, which led to forks like https://github.com/oksiniichan/pngphoon-that-works, and I am aware of these problems. However, I have respected the author's changes. My patches have not caused such problems, as far as I know. But the project's code, from a quality control perspective, really needs improvements, and I am considering creating some patches to enhance it. The original repository is active and has received updates in less than a year, and we try to respect its changes as much as possible, but this has already generated some forks on GitHub by people who have developed code that, in their opinion, is correct. Furthermore, the original repository is closed to pull requests and issues. I tried to create an account there, but without success so far, and I will try to contact those responsible for the original project for possible collaborations. The code you mentioned was a change made by the project author, and this can also be sent to them. It's always important to read the package manual to verify if this is the expected behavior, and in this case, it isn't. Thank you for your report.