#1136516 knot-resolver uses pidof but does not depend on procps

Package:
src:knot-resolver
Source:
src:knot-resolver
Submitter:
Gioele Barabucci
Date:
2026-10-23 05:01:00 UTC
Severity:
normal
#1136516#5
Date:
2026-05-13 23:28:31 UTC
From:
To:
Dear maintainer(s) of knot-resolver,

it appears that knot-resolver uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of knot-resolver
  that use `pidof` at runtime;
* via the `Build-Depends:` field of knot-resolver, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of knot-resolver, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that knot-resolver uses `pidof` due to the following
code snippets:

```
path: knot-resolver_6.2.0-2/tests/packaging/interactive/workers.sh
fi
actual_processes="$(pidof kresd | wc -w)"
if [ "$actual_processes" -ne "$expected_workers" ]; then
	echo "Incorrect number of workers"
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,
#1136516#10
Date:
2026-05-14 08:25:08 UTC
From:
To:
Right, it does use pidof but only in its packaging test-suite in
tests/packaging/interactive/workers.sh
#1136516#15
Date:
2026-10-22 22:47:30 UTC
From:
To:
On Thu, 14 May 2026 10:25:08 +0200 =?UTF-8?B?VmxhZGltw61yIMSMdW7DoXQ=?= <vladimir.cunat@nic.cz> wrote:

Hi Vladimír,

IIUC that test suite is not run at build-time, is it? If that is the
case, then this bug could be closed without further action.

In the meantime I'll lower the severity of this issue to minor.

Regards,
#1136516#22
Date:
2026-10-23 04:58:19 UTC
From:
To:
Correct; `pidof` is only used during tests (as suggested by the path
where you found it).

At a quick glance, this option would apply (but I'm not good in .deb
details):