#1136584 seatd uses pidof but does not depend on procps

Package:
src:seatd
Source:
src:seatd
Submitter:
Gioele Barabucci
Date:
2026-10-16 09:05:02 UTC
Severity:
normal
Tags:
#1136584#5
Date:
2026-05-13 23:32:25 UTC
From:
To:
Dear maintainer(s) of seatd,

it appears that seatd uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of seatd
  that use `pidof` at runtime;
* via the `Build-Depends:` field of seatd, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of seatd, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that seatd uses `pidof` due to the following
code snippets:

```
path: seatd_0.9.3-1/debian/tests/seatd-launch
# Ensure seatd-launch wrapper finds and runs seatd.
SEATD_LOGLEVEL=debug seatd-launch -- sh -c 'printf "seatd PID: %d\n" $(pidof seatd)'
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

#1136584#10
Date:
2026-10-16 09:03:21 UTC
From:
To:
Control: tags -1 patch
The following 1-line patch fixes this issue

```
diff -ur a/debian/tests/control b/debian/tests/control
--- a/debian/tests/control    2026-03-03 12:04:34.000000000 +0100
+++ b/debian/tests/control    2026-10-16 11:00:48.488997248 +0200
@@ -1,5 +1,6 @@
  Tests: seatd-launch
  Restrictions: allow-stderr, needs-root
+Depends: @, procps

  Tests: libseat-dev
  Restrictions: superficial
```

Regards