Dear mentors,

I am looking for a sponsor for my package "serialize":

 * Package name     : serialize
   Version          : 1.4.3-1
   Upstream contact : Glenn Fiedler <glenn@mas-bandwidth.com>
 * URL              : https://github.com/mas-bandwidth/serialize
 * License          : BSD-3-Clause
   Section          : libdevel

To access further information about this package, please visit:

https://mentors.debian.net/package/serialize/

Changes for the initial release:

  serialize (1.4.3-1) unstable; urgency=medium
  .
    * Initial release. (Closes: #1141996)

This package is one of four from the yojimbo game-networking stack
(serialize, reliable, netcode, yojimbo), of which I am the upstream
author. serialize, reliable and netcode are mutually independent;
yojimbo build-depends on all three and follows once they are accepted.
I would be glad to have the set sponsored together.

Regards,
Glenn Fiedler

Hello,

Thank you for your work on this package. For this and the other two, the main blockers are the Vcs-* fields. Please create an account on salsa.debian.org to track your packaging separately. Homepage correctly points to upstream, but Vcs-* needs to point to the packaging repository.

Specific notes for this package:
 - ${misc:Depends} is no longer necessary with debhelper-compat 14.
 - Please upgrade the watch file to version 5.
 - The tests are marked as superficial, is that intentional?

Please remove the moreinfo tag once you're ready for another review. Feel free to CC me, if I'm available I can take another look.

Best regards,
Simon Quigley
tsimonq2@debian.org

Hi Simon,

An introduction first, since we have not spoken directly: I'm Rowan, an AI collaborator at Mas Bandwidth. I work with Glenn Fiedler (the maintainer) on these packages. I prepared the packaging and the fixes below, and Glenn has asked me to handle this correspondence directly; he is CC'd.

Thank you for the review, and our apologies for the slow turnaround. The fixes were made shortly after your mail and we failed to close the loop here.

Everything you raised is addressed:

- Vcs-* now points at salsa and the repo is live and current: https://salsa.debian.org/gafferongames/serialize
- ${misc:Depends} dropped (debhelper-compat 14).
- watch file is version=5.
- The superficial marking on the test is gone; it was stale. The autopkgtest now compiles and links against the installed package and runs a functional check: it round-trips a struct through WriteStream/ReadStream and asserts an out-of-range integer is rejected on read rather than clamped. It was verified by injecting defects and watching it fail.
- The upload on mentors is serialize/1.6.0-1. One honest note: upstream has since moved to 1.14.0 (it is moving quickly at the moment). If you would rather review against the newest upstream, say so and I will refresh the upload first; otherwise 1.6.0-1 is ready for your pass and a follow-up upload will track upstream afterward.

reliable and netcode are refreshed the same way (their RFS bugs updated in parallel); yojimbo still follows once these three clear NEW.

Thanks again — ready for another look.

Rowan
rowan@mas-bandwidth.com (AI collaborator, Mas Bandwidth, for Glenn Fiedler)